Re: [PATCH/RFC] rebase: new convenient option to edit a single commit

2014-02-28 Thread Philip Oakley
From: "Jeff King" I'd expect "-$n" to mean "rebase the last $n commits" (as opposed to everything not in the upstream). That does not work currently, of course, but: 1. It has the potential to confuse people who read it, since it's unlike what "-1" means in most of the rest of git. 2. It

Re: [PATCH/RFC] rebase: new convenient option to edit a single commit

2014-02-27 Thread Jeff King
On Fri, Feb 28, 2014 at 02:34:16PM +0700, Duy Nguyen wrote: > > Yeah, I do this a lot, too. The interface you propose makes sense to > > me, though I'm not sure how much I would use it, as I often do not know > > the specifier of the commit I want to change (was it "HEAD~3 or > > HEAD~4?"). I gue

Re: [PATCH/RFC] rebase: new convenient option to edit a single commit

2014-02-27 Thread Duy Nguyen
On Fri, Feb 28, 2014 at 1:58 PM, Jeff King wrote: > On Thu, Feb 27, 2014 at 08:01:18PM +0700, Nguyễn Thái Ngọc Duy wrote: > >> I find myself often do "git rebase -i xxx" and replace one "pick" line >> with "edit" to amend just one commit when I see something I don't like >> in that commit. This ha

Re: [PATCH/RFC] rebase: new convenient option to edit a single commit

2014-02-27 Thread Jeff King
On Thu, Feb 27, 2014 at 08:01:18PM +0700, Nguyễn Thái Ngọc Duy wrote: > I find myself often do "git rebase -i xxx" and replace one "pick" line > with "edit" to amend just one commit when I see something I don't like > in that commit. This happens often while cleaning up a series. This > automates

Re: [PATCH/RFC] rebase: new convenient option to edit a single commit

2014-02-27 Thread Matthieu Moy
Nguyễn Thái Ngọc Duy writes: > I find myself often do "git rebase -i xxx" and replace one "pick" line > with "edit" to amend just one commit when I see something I don't like > in that commit. This happens often while cleaning up a series. This > automates the "replace" step so it sends me straig

[PATCH/RFC] rebase: new convenient option to edit a single commit

2014-02-27 Thread Nguyễn Thái Ngọc Duy
I find myself often do "git rebase -i xxx" and replace one "pick" line with "edit" to amend just one commit when I see something I don't like in that commit. This happens often while cleaning up a series. This automates the "replace" step so it sends me straight to that commit. "commit --fixup" th