Re: [PATCH/RFC] read-cache: fix file time comparisons with different precisions

2015-09-29 Thread Johannes Schindelin
Hi Karsten, On 2015-09-29 12:23, Karsten Blees wrote: > Am 28.09.2015 um 14:52 schrieb Johannes Schindelin: >> Otherwise there would be that little loop-hole where (nsec % 1000) == 0 *by >> chance* and we assume the timestamps to be identical even if they are not. > > Yeah, but in this case the

Re: [PATCH/RFC] read-cache: fix file time comparisons with different precisions

2015-09-29 Thread Karsten Blees
Am 28.09.2015 um 14:52 schrieb Johannes Schindelin: > Otherwise there would be that little loop-hole where (nsec % 1000) == 0 *by > chance* and we assume the timestamps to be identical even if they are not. Yeah, but in this case the file would be racy, as racy-checks use the same comparison now.

Re: [PATCH/RFC] read-cache: fix file time comparisons with different precisions

2015-09-28 Thread Johannes Schindelin
Hi Karsten, On 2015-09-28 12:39, Karsten Blees wrote: > Different git variants record file times in the index with different > precisions, according to their capabilities. E.g. git compiled with NO_NSEC > records seconds only, JGit records the mtime in milliseconds, but leaves > ctime blank (becau

[PATCH/RFC] read-cache: fix file time comparisons with different precisions

2015-09-28 Thread Karsten Blees
Different git variants record file times in the index with different precisions, according to their capabilities. E.g. git compiled with NO_NSEC records seconds only, JGit records the mtime in milliseconds, but leaves ctime blank (because ctime is unavailable in Java). This causes performance issu