On Fri, Aug 3, 2012 at 12:39 PM, Junio C Hamano wrote:
>
> Much nicer than the drafts in earlier discussion. One micronit is
> that probably it is preferrable to do '!=' instead of '>', as we are
> only trying to see if it is unspecified on the command line (hence
> need to pay attention to confi
J Smith writes:
> The grep.extendedRegexp configuration setting enables the -E flag on grep
> by default but there are no equivalents for the -G, -F and -P flags.
>
> Rather than adding an additional setting for grep.fooRegexp for current
> and future pattern matching options, add a grep.patternT
The grep.extendedRegexp configuration setting enables the -E flag on grep
by default but there are no equivalents for the -G, -F and -P flags.
Rather than adding an additional setting for grep.fooRegexp for current
and future pattern matching options, add a grep.patternType setting that
can accept
Alright, I have revised the patch and fixed up the nits that were
picked and made a quick modification. I've added a setting for
grep.patternType for "default" which can restore the default grep
pattern matching behaviour and restores the functionality back to
grep.extendedRegexp. I added this func
On Wed, Aug 1, 2012 at 5:55 PM, Junio C Hamano wrote:
>
> As the basic structure and the direction looks good, let's start
> nitpicking ;-)
Sounds good.
> We tend to write the commit log message in imperative mood, as if
> you are giving an order to the codebase to "behave this way!". Also
> we
On Wed, 01 Aug 2012 14:55:52 -0700
Junio C. Hamano wrote:
> J Smith writes:
>
>> grep.extendedRegexp::
>> -If set to true, enable '--extended-regexp' option by default.
>> +If set to true, enable '--extended-regexp' option by default. This
>> +option is ignored when the 'grep.pattern
J Smith writes:
As the basic structure and the direction looks good, let's start
nitpicking ;-)
> Adds the grep.patternType configuration setting which sets the default
> pattern matching behavior. The values "basic", "extended", "fixed", and
> "perl" can be used to set "--basic-regexp", "--exte
Adds the grep.patternType configuration setting which sets the default
pattern matching behavior. The values "basic", "extended", "fixed", and
"perl" can be used to set "--basic-regexp", "--extended-regexp",
"--fixed-strings", and "--perl-regexp" options by default respectively.
A value of true is
8 matches
Mail list logo
