Re: [PATCH/RFC] git-commit: add a commit.verbose config variable

2016-02-26 Thread Matthieu Moy
Junio C Hamano writes: > Pranit Bauva writes: > >>> If you know you haven't finished, you may use WIP (work in progress) >>> instead of RFC in the title. >> >> I wasn't familiar with this tag. I will keep it in mind. And this is not >> included in Documentation/SubmittingPatches , so I will send

Re: [PATCH/RFC] git-commit: add a commit.verbose config variable

2016-02-26 Thread Junio C Hamano
Pranit Bauva writes: >> If you know you haven't finished, you may use WIP (work in progress) >> instead of RFC in the title. > > I wasn't familiar with this tag. I will keep it in mind. And this is not > included in Documentation/SubmittingPatches , so I will send a patch to > include WIP tag. P

Re: [PATCH/RFC] git-commit: add a commit.verbose config variable

2016-02-25 Thread Pranit Bauva
ride any value that --verbose or --no-verbose may > have set before? Yes, this was the problem. I have fixed it now. But there is a glitch. See below. Eric Sunshine: > On Thu, Feb 25, 2016 at 9:57 PM, Pranit Bauva wrote: >> From c273a02fc9cab9305cedf6e37422e257a1cc3b1e Mon Se

Re: [PATCH/RFC] git-commit: add a commit.verbose config variable

2016-02-25 Thread Eric Sunshine
Thanks for the submission. Review comments below... On Thu, Feb 25, 2016 at 9:57 PM, Pranit Bauva wrote: > From c273a02fc9cab9305cedf6e37422e257a1cc3b1e Mon Sep 17 00:00:00 2001 > From: Pranit Bauva > Date: Fri, 26 Feb 2016 07:14:18 +0530 > Subject: [PATCH/RFC] git-commit: add a co

Re: [PATCH/RFC] git-commit: add a commit.verbose config variable

2016-02-25 Thread Stefan Beller
On Thu, Feb 25, 2016 at 1:27 PM, Matthieu Moy wrote: > >> +commit.verbose:: >> + A boolean to specify whether to always include the verbose option > > Boolean is usually written with a capital letter. I disagree here, ("grep -riI boolean" suggestes to only capitalize boolean at the beginning

Re: [PATCH/RFC] git-commit: add a commit.verbose config variable

2016-02-25 Thread Matthieu Moy
Pranit Bauva writes: > From c273a02fc9cab9305cedf6e37422e257a1cc3b1e Mon Sep 17 00:00:00 2001 > From: Pranit Bauva > Date: Fri, 26 Feb 2016 07:14:18 +0530 > Subject: [PATCH/RFC] git-commit: add a commit.verbose config variable These should not appear in the body of your messa

[PATCH/RFC] git-commit: add a commit.verbose config variable

2016-02-25 Thread Pranit Bauva
>From c273a02fc9cab9305cedf6e37422e257a1cc3b1e Mon Sep 17 00:00:00 2001 From: Pranit Bauva Date: Fri, 26 Feb 2016 07:14:18 +0530 Subject: [PATCH/RFC] git-commit: add a commit.verbose config variable Since many people always run the command with this option, and would prefer not to use