Re: [PATCH/RFC] commit: add short option for --amend

2018-08-18 Thread Simon Ruderich
On Thu, Aug 16, 2018 at 08:31:17PM +0200, Nguyễn Thái Ngọc Duy wrote: > I just realized how often I type "git ci --amend". Looking back at my > ~/.bash_history (only 10k lines) this is the second most often git > command I type which may justify a short option for it (assuming that > other people u

Re: [PATCH/RFC] commit: add short option for --amend

2018-08-17 Thread Duy Nguyen
On Fri, Aug 17, 2018 at 5:26 PM Jeff King wrote: > > On Fri, Aug 17, 2018 at 04:33:30PM +0200, Duy Nguyen wrote: > > > On Fri, Aug 17, 2018 at 8:47 AM Jonathan Nieder wrote: > > > > > > Nguyễn Thái Ngọc Duy wrote: > > > > > > > --- a/builtin/commit.c > > > > +++ b/builtin/commit.c > > > > @@ -148

Re: [PATCH/RFC] commit: add short option for --amend

2018-08-17 Thread Junio C Hamano
Duy Nguyen writes: > The alternative is -A or -M which may be easier associated with > --amend. I would be confused to mistake that "git commit -A $args" would do something similar to "git add -A && git commit $args". I do my fair share of amends during the day, and I've never felt the need for

Re: [PATCH/RFC] commit: add short option for --amend

2018-08-17 Thread Jeff King
On Fri, Aug 17, 2018 at 04:33:30PM +0200, Duy Nguyen wrote: > On Fri, Aug 17, 2018 at 8:47 AM Jonathan Nieder wrote: > > > > Nguyễn Thái Ngọc Duy wrote: > > > > > --- a/builtin/commit.c > > > +++ b/builtin/commit.c > > > @@ -1489,7 +1489,7 @@ int cmd_commit(int argc, const char **argv, const > >

Re: [PATCH/RFC] commit: add short option for --amend

2018-08-17 Thread Duy Nguyen
On Fri, Aug 17, 2018 at 8:47 AM Jonathan Nieder wrote: > > Nguyễn Thái Ngọc Duy wrote: > > > --- a/builtin/commit.c > > +++ b/builtin/commit.c > > @@ -1489,7 +1489,7 @@ int cmd_commit(int argc, const char **argv, const > > char *prefix) > > STATUS_FORMAT_LONG), > >

Re: [PATCH/RFC] commit: add short option for --amend

2018-08-16 Thread Jonathan Nieder
Nguyễn Thái Ngọc Duy wrote: > --- a/builtin/commit.c > +++ b/builtin/commit.c > @@ -1489,7 +1489,7 @@ int cmd_commit(int argc, const char **argv, const char > *prefix) > STATUS_FORMAT_LONG), > OPT_BOOL('z', "null", &s.null_termination, >

Re: [PATCH/RFC] commit: add short option for --amend

2018-08-16 Thread Duy Nguyen
On Thu, Aug 16, 2018 at 8:39 PM Jeff King wrote: > > On Thu, Aug 16, 2018 at 08:31:17PM +0200, Nguyễn Thái Ngọc Duy wrote: > > > I just realized how often I type "git ci --amend". Looking back at my > > ~/.bash_history (only 10k lines) this is the second most often git > > command I type which may

Re: [PATCH/RFC] commit: add short option for --amend

2018-08-16 Thread Jeff King
On Thu, Aug 16, 2018 at 08:31:17PM +0200, Nguyễn Thái Ngọc Duy wrote: > I just realized how often I type "git ci --amend". Looking back at my > ~/.bash_history (only 10k lines) this is the second most often git > command I type which may justify a short option for it (assuming that > other people

[PATCH/RFC] commit: add short option for --amend

2018-08-16 Thread Nguyễn Thái Ngọc Duy
I just realized how often I type "git ci --amend". Looking back at my ~/.bash_history (only 10k lines) this is the second most often git command I type which may justify a short option for it (assuming that other people use this option often too, of course). The short option space for 'git commit'