On Tue, Jun 17, 2014 at 11:51:35AM -0700, Tanay Abhra wrote:
> I have read your other two replies related to it. I suggest the following
> approach
> for git_config_get_string(), it will return,
>
> 1. Return null if no value was found for the entered key.
>
> 2. Empty string (""), returned for
On 06/16/2014 10:43 PM, Jeff King wrote:
>
>> +v = git_config_get_string(alias_key);
>> +if (!v)
>> +config_error_nonbool(alias_key);
>
> What does a NULL output from git_config_get_string mean? I think with
> the current code, it means "no such key was found". In which case
On Mon, Jun 16, 2014 at 02:15:54AM -0700, Tanay Abhra wrote:
> **DOUBT**
> This patch builds on top of patch series[1]. The first patch in the
> replace `git_config` series is [2], which passed all the tests.
>
> But this patch falters at this test in t1300-repo-config.sh,
>
> git config alias.
Original implementation uses a callback based approach which has some
deficiencies like a convoluted control flow and redundant variables.
Use git_config_get_string instead of git_config to take advantage of
the config hash-table.
Signed-off-by: Tanay Abhra
---
**DOUBT**
This patch builds on top
4 matches
Mail list logo
