Re: [PATCH/RFC] Add userdiff built-in pattern for CSS code

2016-05-19 Thread William Duclot
> On Thu, May 19, 2016 at 10:45 AM, Matthieu Moy > wrote: > >> Add the info in documentation that CSS is now built-in. > > > > This doesn't add much to the patch (we can already see that from the patch > > itself). I'd remove it. > > I think you meant to say this "doesn't add much to the *commit

Re: [PATCH/RFC] Add userdiff built-in pattern for CSS code

2016-05-19 Thread Eric Sunshine
On Thu, May 19, 2016 at 10:45 AM, Matthieu Moy wrote: >> Subject: [PATCH/RFC] Add userdiff built-in pattern for CSS code >> [...snip...] >> Add the info in documentation that CSS is now built-in. > > This doesn't add much to the patch (we can already see that from th

Re: [PATCH/RFC] Add userdiff built-in pattern for CSS code

2016-05-19 Thread Matthieu Moy
> Subject: [PATCH/RFC] Add userdiff built-in pattern for CSS code We normally write subject lines as ": CSS is widely used, motivating it being included as a built-in pattern. > It must be noted that the word_regex for CSS (i.e. the regex defining what is > a word in the lang

[PATCH/RFC] Add userdiff built-in pattern for CSS code

2016-05-19 Thread William Duclot
CSS is widely used, motivating it being included as a built-in pattern. It must be noted that the word_regex for CSS (i.e. the regex defining what is a word in the language) does not consider '.' and '#' characters (in CSS selectors) to be part of the word. This behavior is documented by the test