Re: [PATCH/FINAL] status: contextually notify user about an initial commit

2017-06-21 Thread Kaartic Sivaraam
On Wed, 2017-06-21 at 19:10 -0700, Junio C Hamano wrote: > You can check by downloading what you sent out (I showed you how in > the other thread). > > It seems that there are funny non-breaking spaces in the additional > text below "---" but before the diffstat, but they are not part of > patch t

Re: [PATCH/FINAL] status: contextually notify user about an initial commit

2017-06-21 Thread Junio C Hamano
Kaartic Sivaraam writes: > The existing message, "Initial commit", makes sense for the commit template > notifying users that it's their initial commit, but is confusing when > merely checking the status of a fresh repository (or orphan branch) > without having any commits yet. > > Change the out

Re: [PATCH/FINAL] status: contextually notify user about an initial commit

2017-06-21 Thread Junio C Hamano
Kaartic Sivaraam writes: > On Wed, 2017-06-21 at 16:52 +0200, Ævar Arnfjörð Bjarmason wrote: >> No, this is a bug in your patch, the test suite should pass under >> poison. >> >> The issue is that you changed the test code I gave you (to also add >> more >> tests, yay) along the way to do: >> >

[PATCH/FINAL] status: contextually notify user about an initial commit

2017-06-21 Thread Kaartic Sivaraam
The existing message, "Initial commit", makes sense for the commit template notifying users that it's their initial commit, but is confusing when merely checking the status of a fresh repository (or orphan branch) without having any commits yet. Change the output of "status" to say "No commits yet

Re: [PATCH/FINAL] status: contextually notify user about an initial commit

2017-06-21 Thread Kaartic Sivaraam
On Wed, 2017-06-21 at 16:52 +0200, Ævar Arnfjörð Bjarmason wrote: > No, this is a bug in your patch, the test suite should pass under > poison. > > The issue is that you changed the test code I gave you (to also add > more > tests, yay) along the way to do: > > test_must_fail test_i18ngrep ..

Re: [PATCH/FINAL] status: contextually notify user about an initial commit

2017-06-21 Thread Ævar Arnfjörð Bjarmason
On Wed, Jun 21 2017, Kaartic Sivaraam jotted: > On Wed, 2017-06-21 at 08:07 +0530, Kaartic Sivaraam wrote: >> The existing message, "Initial commit", makes sense for the commit >> template >> notifying users that it's their initial commit, but is confusing when >> merely checking the status of a

Re: [PATCH/FINAL] status: contextually notify user about an initial commit

2017-06-21 Thread Kaartic Sivaraam
On Wed, 2017-06-21 at 08:07 +0530, Kaartic Sivaraam wrote: > The existing message, "Initial commit", makes sense for the commit > template > notifying users that it's their initial commit, but is confusing when > merely checking the status of a fresh repository (or orphan branch) > without having a

[PATCH/FINAL] status: contextually notify user about an initial commit

2017-06-20 Thread Kaartic Sivaraam
The existing message, "Initial commit", makes sense for the commit template notifying users that it's their initial commit, but is confusing when merely checking the status of a fresh repository (or orphan branch) without having any commits yet. Change the output of "status" to say "No commits yet