Re: [GSoC][RFC v2] Improve consistency of sequencer commands

2019-03-30 Thread Elijah Newren
On Sat, Mar 30, 2019 at 1:49 AM Rohit Ashiwal wrote: > > Hi Elijah > > On 2019-03-30 0:38 UTC Elijah Newren wrote: > > > I'm curious if you're looking at an old version of the documentation > > (...or maybe the documentation just isn't that clear?). Interactive > > rebases have supported --sign

Re: [GSoC][RFC v2] Improve consistency of sequencer commands

2019-03-30 Thread Elijah Newren
On Sat, Mar 30, 2019 at 12:16 AM Christian Couder wrote: > > 6. `[Bonus]` If everything goes well and time permits, discuss with the > > mentor(s) > > the possibility of deprecating the am backend of rebase. This point is last > > to > > work on as it provides no "cosmetic" difference on the us

Re: [GSoC][RFC v2] Improve consistency of sequencer commands

2019-03-30 Thread Rohit Ashiwal
Hi Elijah On 2019-03-30 0:38 UTC Elijah Newren wrote: > I'm curious if you're looking at an old version of the documentation > (...or maybe the documentation just isn't that clear?). Interactive > rebases have supported --signoff since commit a852ec7f273c ("rebase: > extend --signoff support",

Re: [GSoC][RFC v2] Improve consistency of sequencer commands

2019-03-30 Thread Christian Couder
Hi Rohit, On Fri, Mar 29, 2019 at 11:33 PM Rohit Ashiwal wrote: > > This is the v2 of the draft proposal[1]. I've added some details to the > proposal, > it talks more about what to implement instead of how. It is still incomplete. > > I'm currently adding more to the overview section, where I'l

Re: [GSoC][RFC v2] Improve consistency of sequencer commands

2019-03-29 Thread Elijah Newren
On Fri, Mar 29, 2019 at 4:35 PM Rohit Ashiwal wrote: > > Hi Elijah > > On Sat, Mar 30, 2019 at 4:56 AM Elijah Newren wrote: > > > > Overall this looks pretty good to me, just one question... > > > > :) > > > > 5. `[Bonus]` --signoff > > > > --signoff is new and surprises me. What's the plan

Re: [GSoC][RFC v2] Improve consistency of sequencer commands

2019-03-29 Thread Rohit Ashiwal
Hi Elijah On Sat, Mar 30, 2019 at 4:56 AM Elijah Newren wrote: > > Overall this looks pretty good to me, just one question... > :) > > 5. `[Bonus]` --signoff > > --signoff is new and surprises me. What's the plan with that one? > I was reading the documentation of git-rebase[1], where I f

Re: [GSoC][RFC v2] Improve consistency of sequencer commands

2019-03-29 Thread Elijah Newren
Hi Rohit, On Fri, Mar 29, 2019 at 3:33 PM Rohit Ashiwal wrote: > > Hiya > > This is the v2 of the draft proposal[1]. I've added some details to the > proposal, > it talks more about what to implement instead of how. It is still incomplete. > > I'm currently adding more to the overview section, w

[GSoC][RFC v2] Improve consistency of sequencer commands

2019-03-29 Thread Rohit Ashiwal
Hiya This is the v2 of the draft proposal[1]. I've added some details to the proposal, it talks more about what to implement instead of how. It is still incomplete. I'm currently adding more to the overview section, where I'll document the work done by Dscho and Alban. After that I'll find files