Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-07-08 Thread Matheus Tavares Bernardino
Thanks for the review. I'll address those issues in v8. Best, Matheus On Wed, Jul 3, 2019 at 5:57 AM SZEDER Gábor wrote: > > > diff --git a/t/t0066-dir-iterator.sh b/t/t0066-dir-iterator.sh > > index c739ed7911..8f996a31fa 100755 > > --- a/t/t0066-dir-iterator.sh > > +++ b/t/t0066-dir-iterator.

Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-07-03 Thread SZEDER Gábor
> diff --git a/t/t0066-dir-iterator.sh b/t/t0066-dir-iterator.sh > index c739ed7911..8f996a31fa 100755 > --- a/t/t0066-dir-iterator.sh > +++ b/t/t0066-dir-iterator.sh > @@ -65,4 +65,99 @@ test_expect_success 'begin should fail upon non directory > paths' ' > test_cmp expected-non-dir-output

Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-07-01 Thread Johannes Schindelin
Hi Matheus, On Fri, 28 Jun 2019, Matheus Tavares Bernardino wrote: > On Fri, Jun 28, 2019 at 9:50 AM Johannes Schindelin > wrote: > > > > Hi Matheus, > > > > On Thu, 27 Jun 2019, Matheus Tavares Bernardino wrote: > > > > > On Thu, Jun 27, 2019 at 3:47 PM Johannes Schindelin > > > wrote: > > > >

Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-06-28 Thread Matheus Tavares Bernardino
On Fri, Jun 28, 2019 at 9:50 AM Johannes Schindelin wrote: > > Hi Matheus, > > On Thu, 27 Jun 2019, Matheus Tavares Bernardino wrote: > > > On Thu, Jun 27, 2019 at 3:47 PM Johannes Schindelin > > wrote: > > > > > > On Thu, 27 Jun 2019, Matheus Tavares Bernardino wrote: > > > > > > > On Wed, Jun 2

Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-06-28 Thread Johannes Schindelin
Hi Matheus, On Thu, 27 Jun 2019, Matheus Tavares Bernardino wrote: > On Thu, Jun 27, 2019 at 3:47 PM Johannes Schindelin > wrote: > > > > On Thu, 27 Jun 2019, Matheus Tavares Bernardino wrote: > > > > > On Wed, Jun 26, 2019 at 3:04 PM Junio C Hamano wrote: > > > > > > > > Johannes Schindelin w

Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-06-27 Thread Matheus Tavares Bernardino
On Thu, Jun 27, 2019 at 3:47 PM Johannes Schindelin wrote: > > Hi Matheus, > > On Thu, 27 Jun 2019, Matheus Tavares Bernardino wrote: > > > On Wed, Jun 26, 2019 at 3:04 PM Junio C Hamano wrote: > > > > > > Johannes Schindelin writes: > > > > > > > Hi Matheus, > > > > > > > > On Tue, 18 Jun 2019,

Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-06-27 Thread Johannes Schindelin
Hi Matheus, On Thu, 27 Jun 2019, Matheus Tavares Bernardino wrote: > On Wed, Jun 26, 2019 at 3:04 PM Junio C Hamano wrote: > > > > Johannes Schindelin writes: > > > > > Hi Matheus, > > > > > > On Tue, 18 Jun 2019, Matheus Tavares wrote: > > > > > >>[...] > > >> +/* > > >> + * Look for a recursi

Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-06-27 Thread Matheus Tavares Bernardino
On Wed, Jun 26, 2019 at 3:04 PM Junio C Hamano wrote: > > Johannes Schindelin writes: > > > Hi Matheus, > > > > On Tue, 18 Jun 2019, Matheus Tavares wrote: > > > >>[...] > >> +/* > >> + * Look for a recursive symlink at iter->base.path pointing to any > >> directory on > >> + * the previous stac

Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-06-27 Thread Duy Nguyen
On Thu, Jun 27, 2019 at 1:04 AM Junio C Hamano wrote: > > Johannes Schindelin writes: > > > Hi Matheus, > > > > On Tue, 18 Jun 2019, Matheus Tavares wrote: > > > >>[...] > >> +/* > >> + * Look for a recursive symlink at iter->base.path pointing to any > >> directory on > >> + * the previous stac

Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-06-26 Thread Junio C Hamano
Johannes Schindelin writes: > Hi Matheus, > > On Tue, 18 Jun 2019, Matheus Tavares wrote: > >>[...] >> +/* >> + * Look for a recursive symlink at iter->base.path pointing to any >> directory on >> + * the previous stack levels. If it is found, return 1. If not, return 0. >> + */ >> +static int f

Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-06-26 Thread Johannes Schindelin
Hi Matheus, On Tue, 18 Jun 2019, Matheus Tavares wrote: >[...] > +/* > + * Look for a recursive symlink at iter->base.path pointing to any directory > on > + * the previous stack levels. If it is found, return 1. If not, return 0. > + */ > +static int find_recursive_symlinks(struct dir_iterator_

Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-06-25 Thread Matheus Tavares Bernardino
On Tue, Jun 25, 2019 at 3:00 PM Junio C Hamano wrote: > > Matheus Tavares writes: > > This hunk, which claims to have 25 lines in the postimage ... > > > @@ -44,6 +45,25 @@ > > * dir_iterator_advance() again. > > */ > > > > +/* > > + * Flags for dir_iterator_begin: > > + * > > + * - DIR_ITERA

Re: [GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-06-25 Thread Junio C Hamano
Matheus Tavares writes: This hunk, which claims to have 25 lines in the postimage ... > @@ -44,6 +45,25 @@ > * dir_iterator_advance() again. > */ > > +/* > + * Flags for dir_iterator_begin: > + * > + * - DIR_ITERATOR_PEDANTIC: override dir-iterator's default behavior > + * in case of an

[GSoC][PATCH v7 06/10] dir-iterator: add flags parameter to dir_iterator_begin

2019-06-18 Thread Matheus Tavares
Add the possibility of giving flags to dir_iterator_begin to initialize a dir-iterator with special options. Currently possible flags are: - DIR_ITERATOR_PEDANTIC, which makes dir_iterator_advance abort immediately in the case of an error, instead of keep looking for the next valid entry; - DIR_IT