Re: [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error

2019-03-15 Thread Christian Couder
Hi, On Fri, Mar 15, 2019 at 2:55 AM jonathan chang wrote: > > On Mon, Mar 11, 2019 at 1:59 AM Thomas Gummerer wrote: > > > > On 03/10, Jonathan Chang wrote: > > > Also I found that there is no such function as test_char_count, > > > is it worthwile to add such function? Here are some stat: > >

Re: [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error

2019-03-14 Thread jonathan chang
On Mon, Mar 11, 2019 at 1:59 AM Thomas Gummerer wrote: > > On 03/10, Jonathan Chang wrote: > > Hi, > > > > Thanks for the reviews. > > > > Here are the changes in the second version: > > - bug fixes > > - add preparatory patch > > - seperate different files to different patch > >

Re: [GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error

2019-03-10 Thread Thomas Gummerer
On 03/10, Jonathan Chang wrote: > Hi, > > Thanks for the reviews. > > Here are the changes in the second version: > - bug fixes > - add preparatory patch > - seperate different files to different patch > - change to use test_line_count in a seperate patch > > Also I found

[GSoC][PATCH v2 1/5] t0000-basic: fix an indentation error

2019-03-10 Thread Jonathan Chang
Hi, Thanks for the reviews. Here are the changes in the second version: - bug fixes - add preparatory patch - seperate different files to different patch - change to use test_line_count in a seperate patch Also I found that there is no such function as test_char_c