Re: [GSoC][PATCH v1] t9811: avoid pipe in git commands in test script

2019-04-02 Thread Khalid Ali
Thanks for the feedback Junio. I was wondering if I should resubmit the patch without my comments. Also, I was wondering if I should be adding a call to check the exit codes of this test and the file called 'actual' at the end of the script. On Mon, Apr 1, 2019 at 10:39 PM Junio C Hamano wrote:

Re: [GSoC][PATCH v1] t9811: avoid pipe in git commands in test script

2019-04-01 Thread Junio C Hamano
Khalid Ali writes: > The exit code of the upstream in a pipe is ignored thus we > should avoid using it. By writing out the output of the git command to a > file, we can test the exit codes of both the commands. End the log message here by moving the next two paragraphs below the three-dash line

[GSoC][PATCH v1] t9811: avoid pipe in git commands in test script

2019-04-01 Thread Khalid Ali
The exit code of the upstream in a pipe is ignored thus we should avoid using it. By writing out the output of the git command to a file, we can test the exit codes of both the commands. Aside from the commit message, I plan to apply for GSoC. Planning to solve the rebase/cherry-pick issue or addi