Re: [GSoC][PATCH 3/3] clone: use dir-iterator to avoid explicit dir traversal

2019-02-26 Thread Christian Couder
Hi Matheus, On Mon, Feb 25, 2019 at 3:31 AM Matheus Tavares Bernardino wrote: > > I am a little confused about what I should do next. How should I > proceed with this series? When there are different opinions about what you should do, I would suggest doing only things everyone is ok with, and th

Re: [GSoC][PATCH 3/3] clone: use dir-iterator to avoid explicit dir traversal

2019-02-25 Thread Christian Couder
On Mon, Feb 25, 2019 at 11:25 AM Ævar Arnfjörð Bjarmason wrote: > > > On Mon, Feb 25 2019, Matheus Tavares Bernardino wrote: > > > Hi, Christian and Ævar > > > > First of all, thanks for the fast and attentive reviews. > > > > I am a little confused about what I should do next. How should I > > pr

Re: [GSoC][PATCH 3/3] clone: use dir-iterator to avoid explicit dir traversal

2019-02-25 Thread Ævar Arnfjörð Bjarmason
On Mon, Feb 25 2019, Matheus Tavares Bernardino wrote: > Hi, Christian and Ævar > > First of all, thanks for the fast and attentive reviews. > > I am a little confused about what I should do next. How should I > proceed with this series? > > By what was said, I understood that the series: > 1) I

Re: [GSoC][PATCH 3/3] clone: use dir-iterator to avoid explicit dir traversal

2019-02-25 Thread Duy Nguyen
On Sun, Feb 24, 2019 at 9:45 PM Ævar Arnfjörð Bjarmason wrote: > .. > Can't the utility function we're moving to just be made to be > bug-compatible with what we're doing now with symlinks? I haven't really followed closely this thread. But I think the first step should be bug-compatible (it real

Re: [GSoC][PATCH 3/3] clone: use dir-iterator to avoid explicit dir traversal

2019-02-24 Thread Matheus Tavares Bernardino
Hi, Christian and Ævar First of all, thanks for the fast and attentive reviews. I am a little confused about what I should do next. How should I proceed with this series? By what was said, I understood that the series: 1) Is indeed an improvement under --local, because it won't deference symlink

Re: [GSoC][PATCH 3/3] clone: use dir-iterator to avoid explicit dir traversal

2019-02-24 Thread Matheus Tavares Bernardino
On Sat, Feb 23, 2019 at 6:48 PM Thomas Gummerer wrote: > > On 02/23, Matheus Tavares wrote: > > --- > > Changes in v2: > > - Improved patch message > > - Removed a now unused variable > > s/variable/parameter/ I believe? Yes, you are right! > > + while ((iter_status = dir_iterator_advance(

Re: [GSoC][PATCH 3/3] clone: use dir-iterator to avoid explicit dir traversal

2019-02-24 Thread Ævar Arnfjörð Bjarmason
On Sun, Feb 24 2019, Christian Couder wrote: > On Sat, Feb 23, 2019 at 11:48 PM Ævar Arnfjörð Bjarmason > wrote: >> >> >> On Sat, Feb 23 2019, Matheus Tavares wrote: >> >> > Replace usage of opendir/readdir/closedir API to traverse directories >> > recursively, at copy_or_link_directory functio

Re: [GSoC][PATCH 3/3] clone: use dir-iterator to avoid explicit dir traversal

2019-02-24 Thread Christian Couder
On Sat, Feb 23, 2019 at 11:48 PM Ævar Arnfjörð Bjarmason wrote: > > > On Sat, Feb 23 2019, Matheus Tavares wrote: > > > Replace usage of opendir/readdir/closedir API to traverse directories > > recursively, at copy_or_link_directory function, by the dir-iterator > > API. This simplifies the code a

Re: [GSoC][PATCH 3/3] clone: use dir-iterator to avoid explicit dir traversal

2019-02-23 Thread Ævar Arnfjörð Bjarmason
On Sat, Feb 23 2019, Matheus Tavares wrote: > Replace usage of opendir/readdir/closedir API to traverse directories > recursively, at copy_or_link_directory function, by the dir-iterator > API. This simplifies the code and avoid recursive calls to > copy_or_link_directory. Sounds good in princi

Re: [GSoC][PATCH 3/3] clone: use dir-iterator to avoid explicit dir traversal

2019-02-23 Thread Thomas Gummerer
On 02/23, Matheus Tavares wrote: > Replace usage of opendir/readdir/closedir API to traverse directories > recursively, at copy_or_link_directory function, by the dir-iterator > API. This simplifies the code and avoid recursive calls to > copy_or_link_directory. > > This process also brings some s

[GSoC][PATCH 3/3] clone: use dir-iterator to avoid explicit dir traversal

2019-02-23 Thread Matheus Tavares
Replace usage of opendir/readdir/closedir API to traverse directories recursively, at copy_or_link_directory function, by the dir-iterator API. This simplifies the code and avoid recursive calls to copy_or_link_directory. This process also brings some safe behaviour changes to copy_or_link_directo