Introduce function get_submodule_displaypath() to replace the code
occurring in submodule_init() for generating displaypath of the
submodule with a call to it.
This new function will also be used in other parts of the system
in later patches.
Mentored-by: Christian Couder
Mentored-by: Stefan Bel
On 07/10, Stefan Beller wrote:
> On Mon, Jul 10, 2017 at 4:32 PM, Brandon Williams wrote:
> >> if (!is_submodule_active(the_repository, path)) {
> >> - strbuf_reset(&sb);
> >
> > Is this line removal intended? It doesn't look related to the rest of
> > this patch.
>
> It is, as
On Mon, Jul 10, 2017 at 4:32 PM, Brandon Williams wrote:
>> if (!is_submodule_active(the_repository, path)) {
>> - strbuf_reset(&sb);
>
> Is this line removal intended? It doesn't look related to the rest of
> this patch.
It is, as &sb is re-used and has to be cleared first.
Wi
On 07/11, Prathamesh Chavan wrote:
> Introduce function get_submodule_displaypath() to replace the code
> occurring in submodule_init() for generating displaypath of the
> submodule with a call to it.
>
> This new function will also be used in other parts of the system
> in later patches.
>
> Men
Introduce function get_submodule_displaypath() to replace the code
occurring in submodule_init() for generating displaypath of the
submodule with a call to it.
This new function will also be used in other parts of the system
in later patches.
Mentored-by: Christian Couder
Mentored-by: Stefan Bel
5 matches
Mail list logo
