Re: [GIT GUI PATCH] git-gui: use vcompare when comparing the git version

2014-05-17 Thread Pat Thoyts
Junio C Hamano writes: >Junio C Hamano writes: > >> Jens Lehmann writes: >> >>> Junio, I believe this issue needs to be fixed before 2.0 final. Otherwise >>> git gui will not work inside submodules anymore due to the major version >>> number change from 1 to 2. I'd like to hear Pat's opinion on

Re: [GIT GUI PATCH] git-gui: use vcompare when comparing the git version

2014-05-14 Thread Junio C Hamano
Junio C Hamano writes: > Jens Lehmann writes: > >> Junio, I believe this issue needs to be fixed before 2.0 final. Otherwise >> git gui will not work inside submodules anymore due to the major version >> number change from 1 to 2. I'd like to hear Pat's opinion on this; even >> though I think my

Re: [GIT GUI PATCH] git-gui: use vcompare when comparing the git version

2014-05-14 Thread Junio C Hamano
Jens Lehmann writes: > Junio, I believe this issue needs to be fixed before 2.0 final. Otherwise > git gui will not work inside submodules anymore due to the major version > number change from 1 to 2. I'd like to hear Pat's opinion on this; even > though I think my patch is less risky (as it does

Re: [GIT GUI PATCH] git-gui: use vcompare when comparing the git version

2014-05-14 Thread Jens Lehmann
Junio, I believe this issue needs to be fixed before 2.0 final. Otherwise git gui will not work inside submodules anymore due to the major version number change from 1 to 2. I'd like to hear Pat's opinion on this; even though I think my patch is less risky (as it doesn't change behavior for pre-2 v

Re: [GIT GUI PATCH] git-gui: use vcompare when comparing the git version

2014-05-14 Thread Chris Packham
On 14/05/14 09:24, Jens Lehmann wrote: > Since git 2.0.0 starting git gui in a submodule using a gitfile fails with > the following error: > >No working directory ../../../ > >couldn't change working directory >to "../../../": no such file or >directory > > This is because "git r

[GIT GUI PATCH] git-gui: use vcompare when comparing the git version

2014-05-13 Thread Jens Lehmann
Since git 2.0.0 starting git gui in a submodule using a gitfile fails with the following error: No working directory ../../../ couldn't change working directory to "../../../": no such file or directory This is because "git rev-parse --show-toplevel" is only run when git gui sees a g