Re: [FIXUP] Fixup on tip of jt/http-auth-proto-v2-fix

2019-03-03 Thread Junio C Hamano
Jonathan Tan writes: >> Thanks for fixing it. >> >> Is there a particular patch this should be squashed into, or does it >> stand alone? It the latter, mind writing a commit message for it? > > Not sure if I'm using "fixup" correctly in the subject, but this is > meant to be squashed onto the t

Re: [FIXUP] Fixup on tip of jt/http-auth-proto-v2-fix

2019-02-27 Thread Jeff King
On Mon, Feb 25, 2019 at 03:49:01PM -0800, Jonathan Tan wrote: > Thanks, Peff, for noticing this. It's because the client sometimes sends > "" as a single request (that is, it flushes, and then before it > sends any data, it flushes again). And post_rpc() assumes that it can > always read somet

Re: [FIXUP] Fixup on tip of jt/http-auth-proto-v2-fix

2019-02-26 Thread Jonathan Tan
> Thanks for fixing it. > > Is there a particular patch this should be squashed into, or does it > stand alone? It the latter, mind writing a commit message for it? Not sure if I'm using "fixup" correctly in the subject, but this is meant to be squashed onto the tip of jt/http-auth-proto-v2-fix

Re: [FIXUP] Fixup on tip of jt/http-auth-proto-v2-fix

2019-02-25 Thread Jonathan Nieder
Hi, Jonathan Tan wrote: > Thanks, Peff, for noticing this. It's because the client sometimes sends > "" as a single request (that is, it flushes, and then before it > sends any data, it flushes again). And post_rpc() assumes that it can > always read something - which is usually correct, but

[FIXUP] Fixup on tip of jt/http-auth-proto-v2-fix

2019-02-25 Thread Jonathan Tan
Thanks, Peff, for noticing this. It's because the client sometimes sends "" as a single request (that is, it flushes, and then before it sends any data, it flushes again). And post_rpc() assumes that it can always read something - which is usually correct, but not in this case; we read in state