Re: [Bug report] Git incorrectly selects language in macos

2019-01-15 Thread Jonathan Nieder
Nate Weaver wrote: > Upon further digging, this is an issue in gettext's code on macOS: > The function _nl_language_preferences_default (in langprefs.c) specifically > breaks early when it sees the literal string "en" in the list (from the > "AppleLanguages" defaults key), but not when it gets "en

Re: [Bug report] Git incorrectly selects language in macos

2019-01-15 Thread Jonathan Nieder
Nate Weaver wrote: >>> On Fri, Sep 14, 2018 at 10:20 PM Niko Dzhus wrote: Looks like the issue appeared after updating git from brew. [...] A quick search revealed that brew changed how it builds git recently. I think, it just didn't include i18n by default before, so I never

Re: [Bug report] Git incorrectly selects language in macos

2019-01-15 Thread Eric Sunshine
On Tue, Jan 15, 2019 at 2:06 PM Nate Weaver wrote: > Nevermind: I've been informed that this has already been fixed on the git > trunk > for gettext, and will be in the next release. > > (See: https://savannah.gnu.org/bugs/?49560) Thanks for the follow-up report. It's good to know that this is f

Re: [Bug report] Git incorrectly selects language in macos

2019-01-15 Thread Nate Weaver
--Nate Weaver (Wevah) > On Jan 15, 2019, at 10:43:48, Nate Weaver wrote: > >> On Jan 15, 2019, at 09:35:52, Nate Weaver wrote: >> >>> On Sep 16, 2018, at 02:15:33, Eric Sunshine wrote: >>> >>> On Fri, Sep 14, 2018 at 10:20 PM Niko Dzhus wrote: Looks like the issue appeared after upda

Re: [Bug report] Git incorrectly selects language in macos

2019-01-15 Thread Nate Weaver
> On Jan 15, 2019, at 09:35:52, Nate Weaver wrote: > >> On Sep 16, 2018, at 02:15:33, Eric Sunshine wrote: >> >> On Fri, Sep 14, 2018 at 10:20 PM Niko Dzhus wrote: >>> Looks like the issue appeared after updating git from brew. >>> >>> A quick search revealed that brew changed how it builds g

Re: [Bug report] Git incorrectly selects language in macos

2019-01-15 Thread Nate Weaver
> On Sep 16, 2018, at 02:15:33, Eric Sunshine wrote: > > On Fri, Sep 14, 2018 at 10:20 PM Niko Dzhus wrote: >> Looks like the issue appeared after updating git from brew. >> >> A quick search revealed that brew changed how it builds git recently. >> I think, it just didn't include i18n by defau

Re: [Bug report] Git incorrectly selects language in macos

2018-09-16 Thread Eric Sunshine
On Fri, Sep 14, 2018 at 10:20 PM Niko Dzhus wrote: > Looks like the issue appeared after updating git from brew. > > A quick search revealed that brew changed how it builds git recently. > I think, it just didn't include i18n by default before, so I never > noticed this. > > Anybody here familiar

Re: [Bug report] Git incorrectly selects language in macos

2018-09-14 Thread Niko Dzhus
Looks like the issue appeared after updating git from brew. I tried it on a different mac laptop, git 2.18 still used English, but after updating to 2.19 it started using secondary language. A quick search revealed that brew changed how it builds git recently. I think, it just didn't include i18n

Re: [Bug report] Git incorrectly selects language in macos

2018-09-14 Thread Niko Dzhus
Tried what you suggested - it seems, it only ignores English. In you example, with Swedish as primary and German as secondary, git uses Swedish. With more that one secondary language, the one with a higher priority is being used, as expected. I also tried using non-generic English (English-UK and

Re: [Bug report] Git incorrectly selects language in macos

2018-09-14 Thread Ævar Arnfjörð Bjarmason
On Fri, Sep 14 2018, Niko Dzhus wrote: > It doesn't use English when other language is available as a secondary > language. > > Reproducing: > > 1. Open "Language & Region" in macos settings > 2. In "Preferred languages" box, set English as a primary language. > 3. Add another language, that gi

[Bug report] Git incorrectly selects language in macos

2018-09-14 Thread Niko Dzhus
It doesn't use English when other language is available as a secondary language. Reproducing: 1. Open "Language & Region" in macos settings 2. In "Preferred languages" box, set English as a primary language. 3. Add another language, that git is translated to, as a secondary language, for example,