Thanks for following up. A few minor comments:
On Tue, Sep 05, 2017 at 04:57:24PM -0400, Ross Kabus wrote:
> From: Ross Kabus
> Date: Tue, 5 Sep 2017 13:54:52 -0400
> Subject: [PATCH] commit-tree: don't append a newline with -F
Usually you'd just omit these in favor of the email headers (and re
Jeff King writes:
> On Tue, Sep 05, 2017 at 12:57:21PM -0400, Ross Kabus wrote:
>
>> On Tue, Sep 5, 2017 at 11:36 AM, Jeff King wrote:
>>
>> > So I'd argue that "git commit -F" is doing a reasonable
>> > thing, and "commit-tree -F" should probably change to match it (because
>> > it's inconsist
Gmail mangled that patch of course...
Ross Kabus
Software Engineer
www.aerotech.com | 412-968-2833
On Tue, Sep 5, 2017 at 4:57 PM, Ross Kabus wrote:
> From: Ross Kabus
> Date: Tue, 5 Sep 2017 13:54:52 -0400
> Subject: [PATCH] commit-tree: don't append a newline with -F
>
> This change makes it
From: Ross Kabus
Date: Tue, 5 Sep 2017 13:54:52 -0400
Subject: [PATCH] commit-tree: don't append a newline with -F
This change makes it such that commit-tree -F never appends a newline
character to the supplied commit message (either from file or stdin).
Previously, commit-tree -F would always a
On Tue, Sep 05, 2017 at 12:57:21PM -0400, Ross Kabus wrote:
> On Tue, Sep 5, 2017 at 11:36 AM, Jeff King wrote:
>
> > So I'd argue that "git commit -F" is doing a reasonable
> > thing, and "commit-tree -F" should probably change to match it (because
> > it's inconsistent, and because if anything
On Tue, Sep 5, 2017 at 11:36 AM, Jeff King wrote:
> So I'd argue that "git commit -F" is doing a reasonable
> thing, and "commit-tree -F" should probably change to match it (because
> it's inconsistent, and because if anything the plumbing commit-tree
> should err more on the side of not touching
On Tue, Sep 05, 2017 at 11:09:01AM -0400, Ross Kabus wrote:
> On Sat, Sep 2, 2017 at 4:33 AM, Jeff King wrote:
>
> > But I am confused by your "inconsistent with git commit porcelain"
> > comment. The porcelain git-commit definitely _does_ add a newline if one
> > isn't present (and in fact runs
On Sat, Sep 2, 2017 at 4:33 AM, Jeff King wrote:
> But I am confused by your "inconsistent with git commit porcelain"
> comment. The porcelain git-commit definitely _does_ add a newline if one
> isn't present (and in fact runs the whole thing through git-stripspace
> to clean up whitespace odditi
On Fri, Sep 01, 2017 at 02:58:52PM -0400, Ross Kabus wrote:
> When doing git commit-tree to manually create a commit object, it can be seen
> that the resulting commit's message has an extra appended newline (\n) that
> was not present in the input for either argument -m or -F. This is both
> unde
Hello,
When doing git commit-tree to manually create a commit object, it can be seen
that the resulting commit's message has an extra appended newline (\n) that
was not present in the input for either argument -m or -F. This is both
undesirable and inconsistent with the git commit porcelain comman
10 matches
Mail list logo
