On Sat, Mar 02, 2019 at 05:07:04AM +0100, SZEDER Gábor wrote:
> The completion script used to cache the list of porcelain commands,
> but then Duy came along and removed it in 3301d36b29 (completion: add
> and use --list-cmds=alias, 2018-05-20).
> [...]
Thanks for this summary.
Just for the reco
SZEDER Gábor wrote:
[... lots of good history ...]
Thanks for an excellent summary!
> Note, however, that for completeness sake, if we choose to update
> list_cmds_by_config() to read the repo's config as well, then we
> should also update the completion script to run $(__git
> --list-cmds=...),
On Fri, Mar 01, 2019 at 09:40:12PM -0500, Todd Zullinger wrote:
> Hi,
>
> Junio C Hamano wrote:
> > Todd Zullinger writes:
> >
> >> Hmm. The comments in list_cmds_by_config() made me wonder
> >> if not using a local repo config was intentional:
> >>
> >> /*
> >> * There's no ac
Hi,
Junio C Hamano wrote:
> Todd Zullinger writes:
>
>> Hmm. The comments in list_cmds_by_config() made me wonder
>> if not using a local repo config was intentional:
>>
>> /*
>> * There's no actual repository setup at this point (and even
>> * if there is, we don't re
Todd Zullinger writes:
> Hmm. The comments in list_cmds_by_config() made me wonder
> if not using a local repo config was intentional:
>
> /*
> * There's no actual repository setup at this point (and even
> * if there is, we don't really care; only global config
>
On Sat, Mar 2, 2019 at 6:08 AM Jeff King wrote:
>
> On Fri, Mar 01, 2019 at 05:15:51PM -0500, Todd Zullinger wrote:
>
> > Hmm. The comments in list_cmds_by_config() made me wonder
> > if not using a local repo config was intentional:
> >
> > /*
> > * There's no actual repository
On Fri, Mar 01, 2019 at 05:15:51PM -0500, Todd Zullinger wrote:
> Hmm. The comments in list_cmds_by_config() made me wonder
> if not using a local repo config was intentional:
>
> /*
> * There's no actual repository setup at this point (and even
> * if there is, we don'
Jeff King wrote:
> On Fri, Mar 01, 2019 at 12:34:40PM -0500, Todd Zullinger wrote:
>
>> Jeff King wrote:
>>> I can reproduce your problem, though the test you included passes for me
>>> even with the current tip of master.
>>
>> Oh, hrm. I think the issue is that completion.commands needs to be
On Fri, Mar 01, 2019 at 12:34:40PM -0500, Todd Zullinger wrote:
> Jeff King wrote:
> > I can reproduce your problem, though the test you included passes for me
> > even with the current tip of master.
>
> Oh, hrm. I think the issue is that completion.commands needs to be
> set in the global (or
Jeff King wrote:
> I can reproduce your problem, though the test you included passes for me
> even with the current tip of master.
Oh, hrm. I think the issue is that completion.commands needs to be
set in the global (or system-wide) config, via test_config_global
rather than the local repo config
On Thu, Feb 28, 2019 at 05:31:23PM -0500, Todd Zullinger wrote:
> I was playing with the completion.commands config added in
> 6532f3740b ("completion: allow to customize the completable
> command list", 2018-05-20) and noticed an issue removing
> multiple commands.
>
> I wanted to remove completi
On Thu, Feb 28, 2019 at 05:31:23PM -0500, Todd Zullinger wrote:
> Hi,
>
> I was playing with the completion.commands config added in
> 6532f3740b ("completion: allow to customize the completable
> command list", 2018-05-20) and noticed an issue removing
> multiple commands.
>
> I wanted to remov
Hi,
I was playing with the completion.commands config added in
6532f3740b ("completion: allow to customize the completable
command list", 2018-05-20) and noticed an issue removing
multiple commands.
I wanted to remove completion for cherry and mergetool, so I
added them both to the config:
g
13 matches
Mail list logo
