Re: [BUG] Colon in remote urls

2016-12-12 Thread Johannes Schindelin
Hi Klaus, you probably missed the note about reply-to-all being customary on this list. The reason is that this list is high-volume, and open to non-subscribers. You may want to get into the habit of hitting reply-to-all when responding to mails from this list, in case that you plan to continue co

Re: [BUG] Colon in remote urls

2016-12-12 Thread Klaus Ethgen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, Am Mo den 12. Dez 2016 um 12:03 schrieb Johannes Schindelin: > On Sun, 11 Dec 2016, Klaus Ethgen wrote: > > Am Sa den 10. Dez 2016 um 19:18 schrieb Johannes Schindelin: > > > On Sat, 10 Dec 2016, Klaus Ethgen wrote: > > > > Am Fr den 9. Dez 201

Re: [BUG] Colon in remote urls

2016-12-12 Thread Johannes Schindelin
Hi Klaus, On Sun, 11 Dec 2016, Klaus Ethgen wrote: > Am Sa den 10. Dez 2016 um 19:18 schrieb Johannes Schindelin: > > On Sat, 10 Dec 2016, Klaus Ethgen wrote: > > > Am Fr den 9. Dez 2016 um 22:32 schrieb Johannes Sixt: > > > > There are too many systems out there that use a backslash in path >

Re: [BUG] Colon in remote urls

2016-12-11 Thread Philip Oakley
From: "Klaus Ethgen" To: Am Sa den 10. Dez 2016 um 19:18 schrieb Johannes Schindelin: On Sat, 10 Dec 2016, Klaus Ethgen wrote: > Am Fr den 9. Dez 2016 um 22:32 schrieb Johannes Sixt: > > There are too many systems out there that use a backslash in path > > names. I > > don't think it is wis

Re: [BUG] Colon in remote urls

2016-12-11 Thread Klaus Ethgen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, Am Sa den 10. Dez 2016 um 19:18 schrieb Johannes Schindelin: > On Sat, 10 Dec 2016, Klaus Ethgen wrote: > > Am Fr den 9. Dez 2016 um 22:32 schrieb Johannes Sixt: > > > There are too many systems out there that use a backslash in path names. I >

Re: [BUG] Colon in remote urls

2016-12-10 Thread Johannes Schindelin
Hi Klaus, On Sat, 10 Dec 2016, Klaus Ethgen wrote: > -BEGIN PGP SIGNED MESSAGE- > Hash: SHA512 > > Am Fr den 9. Dez 2016 um 22:32 schrieb Johannes Sixt: > > There are too many systems out there that use a backslash in path names. I > > don't think it is wise to use it also as the quotin

Re: [BUG] Colon in remote urls

2016-12-10 Thread Klaus Ethgen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Am Sa den 10. Dez 2016 um 11:26 schrieb Jeff King: > On Sat, Dec 10, 2016 at 10:41:33AM +0100, Klaus Ethgen wrote: > > > Am Sa den 10. Dez 2016 um 9:26 schrieb Jeff King: > > > Yeah, I picked it arbitrarily as the common quoting character, but I >

Re: [BUG] Colon in remote urls

2016-12-10 Thread Klaus Ethgen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hi, Am Sa den 10. Dez 2016 um 11:24 schrieb Jeff King: > > A colon a perfectly allowed character in POSIX filesystems. > > Sure, it's allowed, but it will cause problems due to other syntactic > conventions. Try putting "/usr/path:with:colons" int

Re: [BUG] Colon in remote urls

2016-12-10 Thread Jeff King
On Sat, Dec 10, 2016 at 10:41:33AM +0100, Klaus Ethgen wrote: > Am Sa den 10. Dez 2016 um 9:26 schrieb Jeff King: > > Yeah, I picked it arbitrarily as the common quoting character, but I > > agree it probably makes backwards compatibility (and general usability > > when you have to double-backsla

Re: [BUG] Colon in remote urls

2016-12-10 Thread Jeff King
On Sat, Dec 10, 2016 at 10:29:28AM +0100, Klaus Ethgen wrote: > > I think we long time ago in 2005 have declared that a colon in a > > directory name would not work for Git repositories because of things > > like GIT_CEILING_DIRECTORIES, GIT_ALTERNATE_OBJECT_DIRECTORIES; so I > > do not think we t

Re: [BUG] Colon in remote urls

2016-12-10 Thread Klaus Ethgen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Am Sa den 10. Dez 2016 um 9:26 schrieb Jeff King: > Yeah, I picked it arbitrarily as the common quoting character, but I > agree it probably makes backwards compatibility (and general usability > when you have to double-backslash each instance) pret

Re: [BUG] Colon in remote urls

2016-12-10 Thread Klaus Ethgen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Am Fr den 9. Dez 2016 um 22:32 schrieb Johannes Sixt: > There are too many systems out there that use a backslash in path names. I > don't think it is wise to use it also as the quoting character. Well, the minority, I believe. And only the minorit

Re: [BUG] Colon in remote urls

2016-12-10 Thread Klaus Ethgen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello, Am Fr den 9. Dez 2016 um 20:07 schrieb Junio C Hamano: > Jeff King writes: > > (One other option is to just declare that the quarantine feature doesn't > > work with colons in the pathname, but stop turning it on by default. I'm > > not sur

Re: [BUG] Colon in remote urls

2016-12-10 Thread Jeff King
On Fri, Dec 09, 2016 at 11:07:25AM -0800, Junio C Hamano wrote: > Jeff King writes: > > > (One other option is to just declare that the quarantine feature doesn't > > work with colons in the pathname, but stop turning it on by default. I'm > > not sure I like that, though). > > I think we long

Re: [BUG] Colon in remote urls

2016-12-10 Thread Jeff King
On Fri, Dec 09, 2016 at 10:32:48PM +0100, Johannes Sixt wrote: > > + if (*p == '\\') > > + literal = 1; > > There are too many systems out there that use a backslash in path names. I > don't think it is wise to use it also as the quoting character. Yea

Re: [BUG] Colon in remote urls

2016-12-09 Thread Johannes Sixt
Am 09.12.2016 um 16:22 schrieb Jeff King: +const char *parse_alt_odb_entry(const char *string, int sep, + struct strbuf *out) +{ + const char *p; + int literal = 0; + + strbuf_reset(out); + + for (p = string; *p; p++) { + if (lit

Re: [BUG] Colon in remote urls

2016-12-09 Thread Junio C Hamano
Jeff King writes: > (One other option is to just declare that the quarantine feature doesn't > work with colons in the pathname, but stop turning it on by default. I'm > not sure I like that, though). I think we long time ago in 2005 have declared that a colon in a directory name would not work

Re: [BUG] Colon in remote urls

2016-12-09 Thread Jeff King
On Fri, Dec 09, 2016 at 03:02:15PM +0100, Klaus Ethgen wrote: > I have some repositories where I have a colon in the (local) url for a > remote. That was no problem until now but with 2.11.0, I see the > following problem: >~> git push >Counting objects: 11, done. >Delta compression us

[BUG] Colon in remote urls

2016-12-09 Thread Klaus Ethgen
-BEGIN PGP SIGNED MESSAGE- Hash: SHA512 Hello, I have some repositories where I have a colon in the (local) url for a remote. That was no problem until now but with 2.11.0, I see the following problem: ~> git push Counting objects: 11, done. Delta compression using up to 8 thread