Re: [PATCH v4] git-send-pack: fix --all option when used with directory

2016-04-01 Thread Stanislav Kolotinskiy
On 31/03/16 23:28, Junio C Hamano wrote: Thanks, will queue. Thanks a lot! -- Regards, Stanislav -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] git-send-pack: Fix --all option when used with directory

2016-04-01 Thread Stanislav Kolotinskiy
Thanks a lot, Jeff, your explanation really helped! -- Regards, Stanislav On 24/03/16 20:02, Jeff King wrote: On Thu, Mar 24, 2016 at 07:47:12PM +0200, Stanislav Kolotinskiy wrote: Thanks for noticing; the above explanation however does not make it very clear why the symptom exhibits itself

[PATCH v4] git-send-pack: fix --all option when used with directory

2016-03-31 Thread stanislav
From: Stanislav Kolotinskiy When using git send-pack with --all option and a target repository specification ([:]), usage message is being displayed instead of performing the actual transmission. The reason for this issue is that destination and refspecs are being set in the same conditional

Re: [PATCH] git-send-pack: Fix --all option when used with directory

2016-03-24 Thread Stanislav Kolotinskiy
perfectly fine). Well, this is some really old code (eight years old), and git version used at the moment was around 1.6. So I'm pretty much sure that it just happened to be the decision of the developer that wrote this piece of code. -- Stanislav -- To unsubscribe from this list: send the

Re: [PATCH] git-send-pack: Fix --all option when used with directory

2016-03-24 Thread Stanislav Kolotinskiy
planation and will post it here - thanks. -- Regards, Stanislav -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH v2] git-send-pack: Fix --all option when used with directory

2016-03-24 Thread Stanislav Kolotinskiy
Please ignore this thread, I sent the email without making sure that I copied commit message. I'm sorry for that. On 24/03/16 16:14, Stanislav Kolotinskiy wrote: --- builtin/send-pack.c | 2 +- t/t5400-send-pack.sh | 12 2 files changed, 13 insertions(+), 1 deletion(-)

[PATCH v3] git-send-pack: Fix --all option when used with directory

2016-03-24 Thread Stanislav Kolotinskiy
of refspecs (nr_refspecs) is 0, refspecs contain all the arguments and switches passed to send-pack. This ensures that send-pack will stop execution only when --all or --mirror switch is used in conjunction with any refs passed. Signed-off-by: Stanislav Kolotinskiy --- builtin/send-pack.c | 2

[PATCH v2] git-send-pack: Fix --all option when used with directory

2016-03-24 Thread Stanislav Kolotinskiy
--- builtin/send-pack.c | 2 +- t/t5400-send-pack.sh | 12 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/builtin/send-pack.c b/builtin/send-pack.c index f6e5d64..19f0577 100644 --- a/builtin/send-pack.c +++ b/builtin/send-pack.c @@ -225,7 +225,7 @@ int cmd_send_pack

Re: [PATCH] git-send-pack: Fix --all option when used with directory

2016-03-24 Thread Stanislav Kolotinskiy
the explanations and for the adaptation of my test to a way better version! I'm going to update the patch and will send another version. Thanks again! -- Regards, Stanislav -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord..

[PATCH] git-send-pack: Fix --all option when used with directory

2016-03-23 Thread Stanislav Kolotinskiy
of refspecs (nr_refspecs) is 0, refspecs contain all the arguments and switches passed to send-pack. This ensures that send-pack will stop execution only when --all or --mirror switch is used in conjunction with any refs passed. Signed-off-by: Stanislav Kolotinskiy --- builtin/send-pack.c

git clone --recursive should run git submodule update with flag --remote

2015-11-11 Thread Stanislav
Consider two repositories, A and B. Repo A is embedded into B by using submodule: git submodule add -b master sub-a So, submodule sub-a is set to track master branch of the repo A. Running git submodule update --remote inside repo B will automatically update and checkout submodule sub-a to t