[PATCH v3] credential-osxkeychain: support more protocols

2013-05-30 Thread Xidorn Quan
Add protocol imap, imaps, ftp and smtp for credential-osxkeychain. Signed-off-by: Xidorn Quan Acked-by: John Szakmeister Acked-by: Jeff King --- contrib/credential/osxkeychain/git-credential-osxkeychain.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/contrib

[PATCH v3] credential-osxkeychain: support more protocols

2013-05-27 Thread Xidorn Quan
Add protocol imap, imaps, ftp and smtp for credential-osxkeychain. Signed-off-by: Xidorn Quan Acked-by: John Szakmeister Acked-by: Jeff King --- contrib/credential/osxkeychain/git-credential-osxkeychain.c | 12 +++- 1 file changed, 11 insertions(+), 1 deletion(-) diff --git a/contrib

Re: [PATCH v2] credential-osxkeychain: support more protocols

2013-05-27 Thread Xidorn Quan
e implemented soon. IMO, we can add IMAP and SOCKS for now since the protocol names are clear, while it is unclear what protocol name will be used for HTTP/HTTPS proxy. I guess that some may prefer using http/https as protocol name instead of something specific. What do you think? -- Xidor

Re: [PATCH] credential-osxkeychain: support more protocols

2013-05-27 Thread Xidorn Quan
change): > > Acked-by: John Szakmeister > > HTH! Thx for your explaining, it helps a lot! After reading the doc, I have a question that when can I affirm that the list reaches a consensus? -- Xidorn Quan -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

[PATCH v2] credential-osxkeychain: support more protocols

2013-05-27 Thread Xidorn Quan
Add protocol ftp and smtp for credential-osxkeychain. Acked-by: John Szakmeister Signed-off-by: Xidorn Quan --- contrib/credential/osxkeychain/git-credential-osxkeychain.c | 6 +- 1 file changed, 5 insertions(+), 1 deletion(-) diff --git a/contrib/credential/osxkeychain/git-credential

Re: [PATCH] credential-osxkeychain: support more protocols

2013-05-27 Thread Xidorn Quan
On Mon, May 27, 2013 at 6:27 PM, John Szakmeister wrote: > > On Mon, May 27, 2013 at 3:57 AM, Xidorn Quan wrote: > > Add protocol ftp, smtp, and ssh for credential-osxkeychain. > > --- > > contrib/credential/osxkeychain/git-credential-osxkeychain.c | 8 +++- > >

[PATCH] credential-osxkeychain: support more protocols

2013-05-27 Thread Xidorn Quan
Add protocol ftp, smtp, and ssh for credential-osxkeychain. --- contrib/credential/osxkeychain/git-credential-osxkeychain.c | 8 +++- 1 file changed, 7 insertions(+), 1 deletion(-) diff --git a/contrib/credential/osxkeychain/git-credential-osxkeychain.c b/contrib/credential/osxkeychain/git-c