On Mon, Oct 14, 2019 at 02:46:29PM -0700, Jonathan Tan wrote:
> > > Well, I agree that it could be better, but with the C language as we
> > > have it now, I still slightly prefer an enum to a list of #define. Both
> > > ways, we still have to manually enter values for each flag, but with
> > > enu
d" or "int"). gdb supports the notion that a few people use
> enums this way too, but if we decide as a project to not use enums in
> this way, that's fine too. For what it's worth, I tried doing a search
> online, but most of the results I got was for C# (where it is
> recommended - they have a "[Flags]" attribute for enums), so maybe I am
> indeed in the minority.
I'll try to pick another set of constants to convert - before this is
agreed on.
Thanks,
wambui karuga
t; being immediately after the "#includes" which is why I moved them, but I'll
> > try to stick to the
> > convention from now on.
>
> Thanks for providing your justifications.
>
> > > Also, I have a slight preference for putting "= 02" on the BLAME_COPY
> > > line but that is not necessary.
> > >
> > Noted.
>
> Well, Junio provides a good reason for putting "= 02" [1], so please do
> that.
>
> [1] https://public-inbox.org/git/xmqqsgnzj4vs@gitster-ct.c.googlers.com/
Yes, I'll include it in an updated patch
Thanks
wambui karuga
On Thu, Oct 10, 2019 at 11:44:39AM -0700, Jonathan Tan wrote:
> > Convert pickaxe_blame preprocessor constants in blame.h to an enum.
> > Also replace previous instances of the constants with the new enum values.
>
> First of all, thanks for your initiative in finding a microproject and
> making a
Convert pickaxe_blame preprocessor constants in blame.h to an enum.
Also replace previous instances of the constants with the new enum values.
Signed-off-by: Wambui Karuga
---
blame.c | 8
blame.h | 12 +++-
builtin/blame.c | 17 -
3 files
reachy and
I found a list of good first issues to begin with. I'm looking forward
to working on one of the most used system in open source!
Wambui Karuga
6 matches
Mail list logo
