Hello,
[+cc: Ævar]
John Paul Adrian Glaubitz wrote:
> The testsuite is failing again on s390x and all other big-endian targets in
> Debian. For a full build log on s390x see [1].
>
> Adrian
>
>> [1]
>> https://buildd.debian.org/status/fetch.php?pkg=git&arch=s390x&ver=1%3A2.24.0%7Erc0-1&stamp=1
Hi,
John Paul Adrian Glaubitz wrote:
> Hi Gábor!
>
> On 10/20/19 1:37 AM, SZEDER Gábor wrote:
>> On Sat, Oct 19, 2019 at 11:38:40PM +0200, John Paul Adrian Glaubitz wrote:
>>> The testsuite is failing again on s390x and all other big-endian targets in
>>> Debian. For a full build log on s390x see
Junio C Hamano wrote:
> Junio C Hamano writes:
>
>> Jeff King writes:
>>
+ if (mailmap < 0)
mailmap = 0;
- }
>>>
>>> This should be "mailmap = 1" to match the commit message, no? (Which
>>> also implies we may want a new test).
>>
[...]
> +test_expect_success 'log.mai
Hi,
John Paul Adrian Glaubitz wrote:
> Recent versions of git are failing the testsuite on big-endian targets
> such as s390x in Debian.
>
> Build logs are:
>
>> https://buildd.debian.org/status/fetch.php?pkg=git&arch=s390x&ver=1%3A2.23.0%7Erc0-1&stamp=1564449102&raw=0
>> https://buildd.debian.o
Jeff King wrote:
> On Tue, Jul 30, 2019 at 09:59:17PM -0400, Todd Zullinger wrote:
>> At the risk of showing my complete lack of knowledge about
>> these tests, I was wondering if the order mattered for the
>> other tests in t0011 and t0016.
[...]
>> You've got
Jeff King wrote:
> On Tue, Jul 30, 2019 at 08:59:33PM -0400, Jeff King wrote:
>
>>> OTOH, this is not just any hashmap, but an oidmap, and I could imagine
>>> that there might be use cases where it would be beneficial if the
>>> iteration order were to match the oid order (but don't know whether w
Hi,
[added Christian, SZEDER, and Jeff to Cc as author and
helpers on the newly-added t0016-oidmap]
Randall S. Becker wrote:
> A preview of the situation with testing 2.23.0.rc0 on
> NonStop is not great. We have had some new failures right
> off the bat on our NonStop platforms. This is a previe
Hi,
Tigran Mkrtchyan wrote:
> diff --git a/Documentation/config/tag.txt b/Documentation/config/tag.txt
> index 663663bdec..675483c3c3 100644
> --- a/Documentation/config/tag.txt
> +++ b/Documentation/config/tag.txt
> @@ -8,6 +8,13 @@ tag.sort::
> linkgit:git-tag[1]. Without the "--sort=" opt
Signed-off-by: Todd Zullinger
---
These are all just minor typos I noticed while reading the
release notes.
I did find the first entry on the checkout --no-overlay read
a bit strangely with the multiple "out's" in '... checking
out paths out ...'. Is it any easier
; long is the same
> size as 'int' and nobody has complained so far). Some safety checks may
> be implemented in the future to prevent class of bugs.
>
> Reported-by: Todd Zullinger
> Signed-off-by: Nguyễn Thái Ngọc Duy
> ---
> diff.h | 2 +-
> 1 file changed, 1 in
Hi,
Sorry I missed your earlier reply which also mentioned using
$obj->can() Ævar. That's what I get for typing a reply and
then walking away for a few hours before hitting send. ;)
Ævar Arnfjörð Bjarmason wrote:
> Same, but to bikeshed a bit, at this point we can just do:
>
> diff --gi
Eric Wong wrote:
> Chris Mayo wrote:
>> git-send-email uses the TLS support in the Net::SMTP core module from
>> recent versions of Perl. Documenting the minimum version is complex
>> because of separate numbering for Perl (5.21.5~169), Net:SMTP (2.34)
>> and libnet (3.01). Version numbers from co
Duy Nguyen wrote:
> On Sat, May 25, 2019 at 12:36 AM Todd Zullinger wrote:
>> I applied this on top of master/2.22.0-rc1 and see a number
>> of compiler errors using gcc-9.1.1 with fedora's standard
>> compiler options for rpm builds.
>
> That last patch 4/3 is n
I wrote:
> Below are the compiler errors.
Well, to be precise, all but imap-send are warnings rather
than errors.
--
Todd
Hi,
Nguyễn Thái Ngọc Duy wrote:
> This should fix the diff tests failure on s360x. It's a serious problem
> and I plan to do something to prevent it from happening again.
Thanks for looking at this!
I applied this on top of master/2.22.0-rc1 and see a number
of compiler errors using gcc-9.1.1 wi
Hi,
Duy Nguyen wrote:
> On Fri, May 24, 2019 at 2:14 AM Todd Zullinger wrote:
>> I am guessing it's no coincidence that this only fails on
>> s390x and it is the only big endian architecture in the
>> fedora build system.
>
> I see a problem with -w and wro
I wrote:
> While running the 2.22.0-rc1 tests on Fedora, I hit a few
> new test failures since 2.21.0 -- but only on the s390x
> architecture.
>
> I haven't had time to dig into these the past few days, so I
> thought I would send what I do have in case the problem is
> obvious to someone else. I
[-cc: lkml, +cc: Duy as author of a good number of
diff-related commits in 2.22.0 :) ]
Hi,
While running the 2.22.0-rc1 tests on Fedora, I hit a few
new test failures since 2.21.0 -- but only on the s390x
architecture.
I haven't had time to dig into these the past few days, so I
thought I would
e other
dependencies, see e.g. the CURL and UNZIP prerequisites.
Signed-off-by: Todd Zullinger
---
As promised, I stole the second paragraph from Ævar nearly verbatim. :)
t/test-lib.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/test-lib.sh b/t/test-lib.sh
index 908ddb9c46
Hi,
Jeff King wrote:
> On Tue, May 14, 2019 at 02:14:19AM +, brian m. carlson wrote:
>
>> On Mon, May 13, 2019 at 10:05:20PM -0400, Todd Zullinger wrote:
>>> diff --git a/t/test-lib.sh b/t/test-lib.sh
>>> index 908ddb9c46..599fd70e14 100644
>>> ---
Hi,
Ævar Arnfjörð Bjarmason wrote:
>
> On Tue, May 14 2019, Jonathan Nieder wrote:
>
>> Todd Zullinger wrote:
>>
>>> The JGIT prereq uses 'type jgit' to determine whether jgit is present.
>>> While this should be sufficient, if the jgit found i
allations.
Signed-off-by: Todd Zullinger
---
I ran into such a broken jgit on Fedora >= 30¹. This is clearly a
problem in the Fedora jgit package which will hopefully be resolved
soon. But it may be good to avoid wasting time debugging tests which
fail due to a broken tool outs
Hi,
Jeff King wrote:
> The description for the "-t" option contains a sub-list of all of the
> possible file status outputs. But because of the newline separating that
> list from the description paragraph, asciidoc treats the sub-list
> entries as a continuation of the overall options list, rathe
Hi,
Junio C Hamano wrote:
> * tz/doc-apostrophe-no-longer-needed (2019-04-08) 1 commit
> - Documentation/git-show-branch: drop last use of {apostrophe}
>
> Doc formatting fix.
>
> Will merge to 'next'.
>
>
> * tz/git-svn-doc-markup-fix (2019-04-08) 1 commit
> - Documentation/git-svn: impro
Martin Ågren wrote:
> I think what's happening could be related to the fix in the first patch.
> There, it's ok to explicitly escape only the first '. The second one is
> matched to it and gets escaped implicitly. Something like that could be
> happening here, too, just that we don't want it to. (S
Hi,
Martin Ågren wrote:
> On Sat, 6 Apr 2019 at 00:51, Todd Zullinger wrote:
>> Here's what I have currently. I haven't tested this much with
>> asciidoctor-1.5.x releases (or maybe not at all -- it's been a
>> week or so since I worked on this).
>
&g
the {apostrophe} is rendered literally with Asciidoctor
(at least with 1.5.5-2.0.3). Avoid this by using single-quotes.
Escaping the leading single-quote allows the content to render properly
in AsciiDoc and Asciidoctor.
Signed-off-by: Todd Zullinger
---
Documentation/git-show-branch.txt | 2 +
the whole paragraph in this way.
There's lots more monospacing to be done in this document, but since our
main motivation is addressing AsciiDoc/Asciidoctor discrepancies like
this one, let's just convert this one paragraph.
Signed-off-by: Todd Zullinger
---
Documentation/git-svn.txt
The second paragraph in the CONFIGURATION section intends to emphasize
the word 'must' with bold type. Adjust the formatting slightly to
provide similar results between asciidoc and asciidoctor.
Signed-off-by: Todd Zullinger
---
I debated changing 'must' from bold to italic
Hi,
Martin Ågren wrote:
> On Fri, 5 Apr 2019 at 03:40, Todd Zullinger wrote:
>> There are two other changes I've got queued locally. One in
>> git-show-branch.txt removes the last use of {apostrophe}.
>> Another in git-svn.txt is a bit of a work-around for a
>>
leading single-quote. This renders properly in asciidoc
and asciidoctor.
Signed-off-by: Todd Zullinger
---
Maybe it would be easier to change the example commit messages
and avoid having to nest single quotes within double quotes? I
don't know if that's much preferable to escaping only the
brian m. carlson wrote:
> On Sat, Mar 30, 2019 at 02:00:14PM -0400, Todd Zullinger wrote:
>> Thanks for the very useful docbook5/xmlto details!
>>
>> The hard-coded use of the non-namespaced stylesheets in
>> xmlto is unfortunate. I hadn't gotten far enough alon
Hi,
Martin Ågren wrote:
> On Sat, 30 Mar 2019 at 19:30, Todd Zullinger wrote:
>>
>> Just chipping away at the remaining differences between asciidoc and
>> asciidoctor.
>>
>> Todd Zullinger (2):
>> Documentation/rev-list-options: wrap --date= block with
Hi,
Jeff Hostetler wrote:
> On 3/30/2019 2:30 PM, Todd Zullinger wrote:
>> The '^### ' lines were added in 1cd828ddc8 ("git-status.txt: describe
>> --porcelain=v2 format", 2016-08-11). I'm _presuming_ they were made
>> with markdown syntax in
Jeff King wrote:
> On Sat, Mar 30, 2019 at 02:30:01PM -0400, Todd Zullinger wrote:
>
>> Asciidoc uses either one-line or two-line syntax for document/section
>> titles[1]. The two-line form is used in git-status. Fix a few section
>> titles in the porcelain v2 section
Hi,
Jeff King wrote:
> On Sat, Mar 30, 2019 at 02:30:00PM -0400, Todd Zullinger wrote:
>
>> Using "+" to continue multiple list items is more tedious and
>> error-prone than wrapping the entire block with "--" block markers.
>>
>> When using asc
Hi Junio,
Junio C Hamano wrote:
> * sg/asciidoctor-in-ci (2019-04-01) 6 commits
> - ci: fix AsciiDoc/Asciidoctor stderr check in the documentation build job
> - ci: stick with Asciidoctor v1.5.8 for now
> - ci: install Asciidoctor in 'ci/install-dependencies.sh'
> - Documentation/technical/pro
quot;--" block
markers to correctly format the block.
When using asciidoc there is no change in how the content is rendered.
Signed-off-by: Todd Zullinger
---
The issue this fixes can be seen in the git-log and git-rev-list docs on
git-scm.com:
https://git-scm.com/docs/git-log#Documentation/
Just chipping away at the remaining differences between asciidoc and
asciidoctor.
Todd Zullinger (2):
Documentation/rev-list-options: wrap --date= block with "--"
Documentation/git-status: fix titles in porcelain v2 section
Documentation/git-status.txt | 12
Doc
Asciidoc uses either one-line or two-line syntax for document/section
titles[1]. The two-line form is used in git-status. Fix a few section
titles in the porcelain v2 section which were inadvertently using
markdown syntax.
[1] http://asciidoc.org/userguide.html#X17
Signed-off-by: Todd
Hi Ævar,
Ævar Arnfjörð Bjarmason wrote:
> diff --git a/Documentation/git-gc.txt b/Documentation/git-gc.txt
> index 66386439b7..c037a46b09 100644
> --- a/Documentation/git-gc.txt
> +++ b/Documentation/git-gc.txt
> @@ -45,28 +45,12 @@ OPTIONS
> --auto::
> With this option, 'git gc' checks whe
Hi,
brian m. carlson wrote:
> On Tue, Mar 26, 2019 at 09:06:03PM -0400, Todd Zullinger wrote:
>> There's still the matter of 2.0 dropping docbook45. I'll
>> try to get around to testing 1.5.x releases with docbook5 to
>> see if they work reasonably well. If not
Hi,
I wrote:
> Jeff King wrote:
>> That seems like a bug in asciidoctor, which ought to be quoting the "<".
>> We certainly can't quote it ourselves (we don't even know that our
>> backend output is going to a format that needs angle brackets quoted).
>
> Yep, it seems so. I filed this upstream:
Hi,
Jeff King wrote:
> On Sun, Mar 24, 2019 at 12:21:31PM -0400, Todd Zullinger wrote:
>> I'm curious why manpage builds work for you and not for me.
>
> I think it's because I'm an idiot. I must have only been using 2.0.0
> when I was looking at the XML out
Hi,
Jeff King wrote:
> On Sat, Mar 23, 2019 at 03:27:56PM -0400, Todd Zullinger wrote:
>
>> I updated my system to asciidoctor-2.0.0 last night and now
>> I can't even generate the man pages properly, because the
>> docbook45 converter was removed. I'll hav
Hi,
Martin Ågren wrote:
> On Wed, 20 Mar 2019 at 19:17, Todd Zullinger wrote:
>> Martin Ågren wrote:
>>> {litdd} now renders as --. We should find some other way to
>>> produce '--'. This should then be a simple change, as we're already
>
Junio C Hamano wrote:
> Todd Zullinger writes:
>
>> Other than a follow-up to update the commit reference in 4/4
>> after 1/4 is in the final form on pu, I think this might be good.
>> If it's easier, we can skip 4/4 and I'll resend it after the
>> othe
Jeff King wrote:
> On Tue, Mar 19, 2019 at 08:12:54AM +0100, Martin Ågren wrote:
>
>>> I just tried with asciidoc 2.0.0.rc.2, which came out last week. It does
>>> seem to work from the command line:
>>>
>>> $ make USE_ASCIIDOCTOR=Yes \
>>> ASCIIDOC_DOCBOOK=docbook5 \
>>> ASCII
Hi,
Martin Ågren wrote:
> On Sun, 17 Mar 2019 at 20:44, Todd Zullinger wrote:
>> Martin Ågren wrote:
>> +ASCIIDOC_EXTRA += -a mansource="Git $(GIT_VERSION)" -a manmanual="Git
>> Manual"
>
> So to be honest, I still don't understand how this w
From: Jeff King
Normally code that is checking config before we've decided to do
setup_git_directory() would use read_early_config(), which uses
discover_git_directory() to tentatively see if we're in a repo,
and if so to add it to the config sequence.
But list_cmds() uses the caching configset
SZEDER Gábor
Signed-off-by: Todd Zullinger
---
contrib/completion/git-completion.bash | 8
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/contrib/completion/git-completion.bash
b/contrib/completion/git-completion.bash
index 499e56f83d..e505f04ff7 100644
--- a/co
for tokens starting with "-", it accidentally passes the
original non-terminated string, meaning that only the final one worked.
Switch to using the strbuf.
Reported-by: Todd Zullinger
Signed-off-by: Jeff King
---
help.c| 4 ++--
t/t9902-completion.sh | 2 +-
2 files c
6532f3740b ("completion: allow to customize the completable command
list", 2018-05-20) added the completion.commands config variable.
Multiple commands may be added or removed, separated by a space.
Demonstrate the failure of multiple removals.
Signed-off-by: Todd Zullinger
--
n the final form on pu, I think this might be good.
If it's easier, we can skip 4/4 and I'll resend it after the
others are on pu.
Jeff King (2):
git: read local config in --list-cmds
completion: fix multiple command removals
Todd Zullinger (2):
t9902: test multiple remova
d76ce4f734 ("log,diff-tree: add --combined-all-paths option",
2019-02-07) added tests for files containing tabs.
When the tests are run with bash, the lack of quoting during the file
setup causes 'ambiguous redirect' errors.
Signed-off-by: Todd Zullinger
---
Hi,
I noticed
user-manual.html in git.1 (currently
it is listed in brackets inline rather than as a footnote)
Reference:
https://lore.kernel.org/lkml/20180424150456.17353-1-ti...@suse.de/
Signed-off-by: Todd Zullinger
---
Documentation/Makefile | 8
Documentation/asciid
for tokens starting with "-", it accidentally passes the
original non-terminated string, meaning that only the final one worked.
Switch to using the strbuf.
Reported-by: Todd Zullinger
Signed-off-by: Jeff King
---
help.c| 4 ++--
t/t9902-completion.sh | 2 +-
2 files c
Hi,
Duy Nguyen wrote:
> Poking this thread before it goes completely dead...
I've been meaning to send out a re-rolled version. I didn't
realize 2 weeks had slipped by already. :/
> On Sat, Mar 2, 2019 at 12:34 AM Todd Zullinger wrote:
>>
>> The completion.comman
From: Jeff King
Normally code that is checking config before we've decided to do
setup_git_directory() would use read_early_config(), which uses
discover_git_directory() to tentatively see if we're in a repo,
and if so to add it to the config sequence.
But list_cmds() uses the caching configset
6532f3740b ("completion: allow to customize the completable command
list", 2018-05-20) added the completion.commands config variable.
Multiple commands may be added or removed, separated by a space.
Demonstrate the failure of multiple removals.
Signed-off-by: Todd Zullinger
--
SZEDER Gábor
Signed-off-by: Todd Zullinger
---
Junio, I referenc the commit id for "git: read local config in
--list-cmds" which is earlier in this series, so the id will, of
course, differ when you apply it. Let me know if you'd prefer
this commit to be dropped and resent once t
Hi,
Jeffrey Walton wrote:
> Fedora 29, x86_64. One failed self test:
>
> *** t0021-conversion.sh ***
[...]
> not ok 13 - disable filter with empty override
> #
> # test_config_global filter.disable.smudge false &&
> # test_config_global filter.disable.clean false &&
>
SZEDER Gábor wrote:
[... lots of good history ...]
Thanks for an excellent summary!
> Note, however, that for completeness sake, if we choose to update
> list_cmds_by_config() to read the repo's config as well, then we
> should also update the completion script to run $(__git
> --list-cmds=...),
Hi,
Junio C Hamano wrote:
> Todd Zullinger writes:
>
>> Hmm. The comments in list_cmds_by_config() made me wonder
>> if not using a local repo config was intentional:
>>
>> /*
>> * There's no actual repository setup at this point (and
Jeff King wrote:
> On Fri, Mar 01, 2019 at 12:34:40PM -0500, Todd Zullinger wrote:
>
>> Jeff King wrote:
>>> I can reproduce your problem, though the test you included passes for me
>>> even with the current tip of master.
>>
>> Oh, hrm. I think the iss
SZEDER Gábor wrote:
> On Fri, Mar 01, 2019 at 01:22:52PM -0500, Eric Sunshine wrote:
>> On Fri, Mar 1, 2019 at 12:35 PM Todd Zullinger wrote:
>>> 6532f3740b ("completion: allow to customize the completable command
>>> list", 2018-05-20) added the completion.c
From: Jeff King
6532f3740b ("completion: allow to customize the completable
command list", 2018-05-20) added the completion.commands config
variable.
The documentation states multiple commands may be added,
separated by spaces. Adding multiple commands to remove fails,
only removing the last co
which
arrived only a few seconds later). Thanks to both of you for the
very quick replies!
I'll leave it to those who know better to follow up with a change to
use string_list_split().
Here's a first stab at improving the docs and fixing the bug.
Jeff King (1):
completion: fix multiple
6532f3740b ("completion: allow to customize the completable command
list", 2018-05-20) added the completion.commands config variable.
Multiple commands may be added or removed, separated by a space.
Demonstrate the failure of multiple removals.
Signed-off-by: Todd Zullinger
--
The completion.commands config var must be set in either the system-wide
or global config file. The completion script does not read a local
repository config.
Signed-off-by: Todd Zullinger
---
Documentation/config/completion.txt | 3 ++-
Documentation/git.txt | 3 ++-
2 files
Hi,
I was playing with the completion.commands config added in
6532f3740b ("completion: allow to customize the completable
command list", 2018-05-20) and noticed an issue removing
multiple commands.
I wanted to remove completion for cherry and mergetool, so I
added them both to the config:
g
Hi,
Robert P. J. Day wrote:
>
> not so much a git issue as what looks like a fedora packaging issue.
Yeah, it's just a minor packaging issue. The gitweb
manpages are included in the main git package rather than in
the gitweb package with the rest of the gitweb files. I'll
fix that for future
Junio C Hamano wrote:
> Ævar Arnfjörð Bjarmason writes:
>
>> It was my reading of the seek=* section ("the implementation shall seek
>> to the specified offset"). I didn't spot that bit covered in of=*. Yeah,
>> I see that's defined & safe after reading that.
>
> OK, so...
>
> -- >8 --
> From:
Hi,
Randall S. Becker wrote:
> On February 21, 2019 15:00, I wrote:
>> t9020 subtests 1,2,5,6 failed - Not new. unsurprising as there is no SVN or
>> perl with SVN module on platform. It might be useful to have a detection to
>> skip of Perl SVN is not present.
>
> While this is a bit of a hack,
m f628825481 ("t/lib-httpd: handle running under
>> --valgrind", 2012-07-24) and 89c57ab3f0 ("t: pass GIT_TRACE through
>> Apache", 2015-03-13), respectively.
>>
>> Signed-off-by: Todd Zullinger
>> ---
>> I missed this with rc0, but poking throug
Jeff King wrote:
> On Thu, Feb 14, 2019 at 01:35:13AM -0500, Todd Zullinger wrote:
>
>> 07c3c2aa16 ("tests: define GIT_TEST_SIDEBAND_ALL", 2019-01-16) added
>> GIT_TEST_SIDEBAND_ALL to the apache.conf PassEnv list. Avoid warnings
>> from Apache when t
Jeff King wrote:
> Yeah, I do have the feeling that not many people really exercise our -rc
> candidates. I'm not sure how to improve that. We could try to push
> packagers to make them available (and I think Jonathan already does for
> Debian's "experimental" track).
Similarly, I try to make them
nd", 2012-07-24) and 89c57ab3f0 ("t: pass GIT_TRACE through
Apache", 2015-03-13), respectively.
Signed-off-by: Todd Zullinger
---
I missed this with rc0, but poking through build logs I noticed a number
of 'AH01506: PassEnv variable GIT_TEST_SIDEBAND_ALL was undefined'
SZEDER Gábor wrote:
> On Sat, Feb 09, 2019 at 06:05:53PM -0500, Todd Zullinger wrote:
>> SZEDER Gábor wrote:
>>> Just curious: how did you noticed the missing GPGSM prereq?
>>
>> I just grep the build output for '# SKIP|skipped:' and then
>> filter
Hi,
Keith Smiley wrote:
>> On Feb 8, 2019, at 22:27, Todd Zullinger wrote:
>>
>> Hi Sergey,
>>
>> There was a previous discussion of this in December 2017,
>> which might be useful:
>>
>> https://public-inbox.org/git/01020160a0004473-277c3
SZEDER Gábor wrote:
> On Thu, Feb 07, 2019 at 10:17:44PM -0500, Todd Zullinger wrote:
>> Looking through the build logs for the fedora git packages, I noticed it
>> was missing the GPGSM prereq.
>
> Just curious: how did you noticed the missing GPGSM prereq?
I just grep
[-cc: linux-kernel & git-packagers]
SZEDER Gábor wrote:
> On Fri, Feb 08, 2019 at 03:11:29PM -0500, Todd Zullinger wrote:
>> It made me wonder how I had missed it in my own testing.
>> This one requires SHELL_PATH to be bash, while I only set
>> TEST_SHELL_PATH to bash fo
Hi Sergey,
There was a previous discussion of this in December 2017,
which might be useful:
https://public-inbox.org/git/01020160a0004473-277c3d7c-4e3b-4c50-9d44-4a106f37f1d9-000...@eu-west-1.amazonses.com/
It didn't end with a patch applied, but it's likely worth
reading to help you make a case
SZEDER Gábor wrote:
> On Thu, Feb 07, 2019 at 10:17:45PM -0500, Todd Zullinger wrote:
>> When gpgsm is installed, lib-gpg.sh attempts to update trustlist.txt to
>> relax the checking of some root certificate requirements. The path to
>> "${GNUPGHOME}" contains s
SZEDER Gábor wrote:
> On Fri, Feb 08, 2019 at 05:48:27AM -0500, Randall S. Becker wrote:
>> We have a few new breakages on the NonStop port in 2.21.0-rc0. The first is
>> in t5403, as below:
[...]
>> The post-checkout hook is:
>> #!/usr/local/bin/bash
>> echo "$@" >$GIT_DIR/post-checkout.args
>>
d and sets the
GPGSM prereq. While we're here, drop the space after ">>".
Signed-off-by: Todd Zullinger
---
t/lib-gpg.sh | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/t/lib-gpg.sh b/t/lib-gpg.sh
index f1277bef4f..207009793b 100755
--- a/t/lib-gpg.sh
nough control
for most cases.
¹ https://dev.gnupg.org/T2964
² https://fedoraproject.org/wiki/Changes/GnuPG2_as_default_GPG_implementation
Todd Zullinger (2):
t/lib-gpg: quote path to ${GNUPGHOME}/trustlist.txt
t/lib-gpg: drop redundant killing of gpg-agent
t/lib-gpg.sh | 3 +--
1 file changed, 1 insertion(+), 2 deletions(-)
--
Todd
les if tests are run multiple times.
Add a cleanup script to force flushing the gpg-agent for that GNUPGHOME
(if any) before setting up the GPG relevant-environment.
Killing gpg-agent once per test is sufficient.
Signed-off-by: Todd Zullinger
---
t/lib-gpg.sh | 1 -
1 file changed, 1 deletio
The git-multi-pack-index doc links to technical/multi-pack-index.html.
Ensure it is built to prevent a broken link.
Signed-off-by: Todd Zullinger
---
While building 2.20.0-rc0 I noticed the broken link from
git-multi-pack-index to technical/multi-pack-index.html.
Documentation/Makefile | 1
Jeff King wrote:
> On Fri, Sep 07, 2018 at 07:22:05PM -0400, Todd Zullinger wrote:
>
>> With curl-7.61.1 cookies are sorted by creation-time¹. Sort the output
>> used in the 'cookies stored in http.cookiefile when http.savecookies
>> set' test before co
e attribute for cookies", 2018-08-28)
Signed-off-by: Todd Zullinger
---
[Resending with the list in Cc; sorry for spamming you,
Junio, Jeff, and Gábor.]
The in-development version of Fedora updated to the recently
released curl-7.61.1 in the past few days. This isn't
breakage from the 2.1
Hi Jeff,
Jeff King wrote:
> .gitignore | 1 -
> Makefile | 22 --
> contrib/svn-fe/.gitignore | 4 -
> contrib/svn-fe/Makefile| 105 ---
> contrib/svn-fe/svn-fe.c| 18 --
> contrib/svn-fe/svn-fe.txt | 71 -
> contr
Hi,
Robert P. J. Day wrote:
> On Sat, 4 Aug 2018, Junio C Hamano wrote:
>> In other words, I think this patch can be a fine addition to
>> somebody else's project (i.e. random collection of scripts that may
>> help Git users), so let's see how I can offer comments/inputs to
>> help you improve it.
ocumentation with a DOC_GENERIC Makefile knob.
The default generic paths may be further customized via the
DOC_ETC_GITCONFIG and DOC_ETC_GITATTRIBUTES variables.
Define DOC_GENERIC in dist-doc make target to ensure generic paths are
used in the generated html and manpage tarballs.
Helped
Junio C Hamano wrote:
> Jeff King writes:
>
>> Specifically, I'm thinking of:
>>
>> 1. The pre-built documentation that Junio builds for
>> quick-install-doc. This _could_ be customized during the "quick"
>> step, but it's probably not worth the effort. However, we'd want
>> some
Junio C Hamano wrote:
> Todd Zullinger writes:
>
>> The default core.excludesfile path is $XDG_CONFIG_HOME/git/ignore.
>> $HOME/.config/git/ignore is used if XDG_CONFIG_HOME is empty or unset,
>
> ... because $HOME/.config is the default value for XDG_CONFIG_HOME
>
I wrote:
> Jeff King wrote:
>> (Related, there's a build target in the local Makefile for using
>> asciidoctor; does it need updated, too?)
>
> I didn't test asciidoctor specficially, but it also respects
> the ASCIIDOC_EXTRA parameters, so I think it will work just
> as well. I'll try
Jeff King wrote:
> On Wed, Jun 27, 2018 at 12:56:37AM -0400, Todd Zullinger wrote:
>
>> Replace `$(prefix)/etc/gitconfig` and `$(prefix)/etc/gitattributes` in
>> generated documentation with the paths chosen when building. Readers of
>> the documentation should not ne
other times using `/etc/gitconfig` to refer to the system-wide
config file.
Update the SYNOPSIS of gitattributes(5) to include the system-wide
config file as well.
Signed-off-by: Todd Zullinger
---
I noticed this while looking to update gitattributes.txt to
note the system-wide config file. I t
The default core.excludesfile path is $XDG_CONFIG_HOME/git/ignore.
$HOME/.config/git/ignore is used if XDG_CONFIG_HOME is empty or unset,
as described later in the document.
Signed-off-by: Todd Zullinger
---
Documentation/gitignore.txt | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff
1 - 100 of 233 matches
Mail list logo
