On Sun, 12 Aug 2018 at 09:19, Nguyễn Thái Ngọc Duy wrote:
Hi,
> + trace_performance_leave("cache_tree_update");
I would suggest trace_performance_leave() calls use __func__ instead.
That way, there's no ambiguity if the function name ever changes.
Kindly,
Thomas
ore perl modules. Every
perl program does this, and they don't go down this route of having copies of
various CPAN modules just in case. So why should we? We're not a special
snowflake.
-- Thomas Adam
n spare time hacking ;-)
>
> I guess the full solution is to make Mail::Address a hard dependency?
This is what I was suggesting, and then as a follow-up, addressing the point
that there's a bunch of require() hacks to also get around needing
hard-dependencies.
-- Thomas Adam
On Thu, Nov 30, 2017 at 03:12:17PM -0500, Jeff King wrote:
> On Wed, Nov 29, 2017 at 06:35:16PM +0000, Thomas Adam wrote:
>
> > On Wed, Nov 29, 2017 at 03:37:50PM +0100, lars.schnei...@autodesk.com wrote:
> > > + if (print_waiting_for_editor) {
> > > +
On Thu, Nov 30, 2017 at 02:55:35PM +0100, Lars Schneider wrote:
>
> > On 29 Nov 2017, at 19:35, Thomas Adam wrote:
> >
> > On Wed, Nov 29, 2017 at 03:37:50PM +0100, lars.schnei...@autodesk.com wrote:
> >> + if (print_waiting_for_editor) {
> >> +
ypically unbuffered on most systems I've used, and
although the call to fflush() is harmless, I suspect it's not having any
effect. That said, there's plenty of other places in Git which seems to think
fflush()ing stderr actually does something.
-- Thomas Adam
ay not
have additional functionality depending on which modules are installed. Given
the pretty good state of packaging across those platforms which Git runs on, I
would argue we're now in a much better position to explicitly check for
non-core modules at BEGIN{} time, and moan loudly if they're not installed.
-- Thomas Adam
to the
> appropriate bits. Maybe Matthieu or Remi (CC'ed) might want to chime in
> on other options?
Trying to come up with a reinvention of regexps for email addresses is asking
for trouble, not to mention a crappy rod for your own back. Don't do that.
This is why people use Mail::Address.
https://metacpan.org/pod/distribution/MailTools/lib/Mail/Address.pod
-- Thomas Adam
id;
Oops. This was my typo from my original suggestion. The hash is
'%namespace_id', not '%namespaces_id'. However, how did this slip through
testing? I'm assuming you blindly copied this from my example, which although
quick to do, is only being caught because of my sharp eyes...
-- Thomas Adam
; s/_/ /g; $_;
} split(/[ \n]/, run_git("config --get-all
remote.${remotename}.namespaces"));
This would, once again, avoid creating @tracked_namespaces, and iterating over
it.
Note that this isn't about trying to 'golf' this; it's a performance
consideration.
Kindly,
Thomas Adam
paces) { s/ /_/g; }
I am sure we can improve upon the need to process @namespaces twice:
my @namespaces = map { s/ /_/g; $_; } sort keys %namespaces_id;
-- Thomas Adam
bly wiser to
transition this to using Carp in the long run -- it would decrease the
round-trip time to debugging should there be a situation where that was
needed, and hence I would recommend using "warn" for less-severe
errors/debugging.
-- Thomas Adam
On Thu, Nov 02, 2017 at 06:26:43PM -0400, Antoine Beaupré wrote:
> On 2017-11-02 22:18:07, Thomas Adam wrote:
> > Hi,
> >
> > On Thu, Nov 02, 2017 at 05:25:18PM -0400, Antoine Beaupré wrote:
> >> +print {*STDERR} "$#{$mw_pages} found in namespace
>
Hi,
On Thu, Nov 02, 2017 at 05:25:18PM -0400, Antoine Beaupré wrote:
> +print {*STDERR} "$#{$mw_pages} found in namespace $local_namespace
> ($namespace_id)\n";
How is this any different to using warn()? I appreciate you're using a
globbed filehandle, but it seems superfluous to me.
Ki
:' -k2 -nr
Given this, I then did some maths on the total lines from each of those files
and to work out a percentage by file, and over all.
What I'm curious to know is whether this approach of using "git blame" is a
good approach or not.
Thanks for your time.
-- Thomas Adam
that removing it is a bad idea, then good, we don't have to
> bother discussing that option. :)
Ah, oops! I was meaning more, whether to print the message in the
case where the branch was uptodate, but now I appreciate it's cached.
Apologies for the confusion.
-- Thomas A
cache was
last updated? That is:
"branch-X is uptodate with origin/branch-X (as of DD-MM-YY HH:MM:SS)"
No one's suggesting that this message is removed, I'm not sure where
you got that from?
-- Thomas Adam
--
To unsubscribe from this list: send the line "unsubscr
understand how to use git-fetch, it's more a case of
whether even printing that message is useful? I appreciate it can
only go on the cached value, but it is still misleading to print that
in the case where the cache might not be up to date. Of course,
determining that is a different pro
ward
[...]
Clearly, it's obvious that "Your branch is up-to-date with
'fvwmorg/master'." is misleading. Note that in this case, there's no
passwords or other hindrances to Git being able to work out that a
branch is behind another.
Any light that can be shed on t
llowing new subdirs
I wonder whether previous discussions on this still count? See:
http://marc.info/?l=git&m=129650572621523&w=1
-- Thomas Adam
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More m
ter that.
Have a look at contrib/rerere-train.sh
-- Thomas Adam
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
getting your own way.
You have a fork of git which you created, go away and use it.
-- Thomas Adam
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
ed $decoded check.
> + ($decoded, sub { encode_utf8(shift) }) :
> + ($orig, sub { shift });
> +}
> +
-- Thomas Adam
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
*/
> + if (!stopped_sha) {
> + stopped_sha = "a commit";
> + must_free_stopped_sha = 0;
> + }
Rather than having to assign a toggle of deciding when to free
stopped_sha, how much overhead would be introduced by just doing:
if (!stopped_sha)
stopped_sha = st
problem is still here, and isn't going to go
away, no matter how much referring to these guidelines might help.
That is why I think this is the wrong thing to do.
-- Thomas Adam
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a message to majord...@vger.kernel.org
More majordomo info at http://vger.kernel.org/majordomo-info.html
nflicts with this idea, so lets
>
> s/lets/let's/ (contraction of "let us")
Ah, the contraction versus the first person singular. In this case
where the context is concluding in decision, rather than making a
statement ("Let's go to the shops", for example) then
It is currently not possible to use the short-form output of git status
without declaring an alias to do so.
This isn't always desirable therfore, define a git config option which can
be set to display the short-form: status.shortwithbranch
Signed-off-by: Thomas Adam
---
builtin/commit.c
this would relate to that, if at all?
Kindly,
Thomas Adam (1):
status: Allow for short-form via config option
builtin/commit.c | 12
1 file changed, 12 insertions(+)
--
1.7.11.4
--
To unsubscribe from this list: send the line "unsubscribe git" in
the body of a mess
.
And no, you cannot philosophise this, or wriggle out of it through
idealism or some other "charter" or "code of conduct" -- as reviewers
of your code, we have to interact with you to be able to better it.
But you seem very reluctant to do that.
The fact that we're even ha
nd the
> resulting `git log` output is ugly. So, I was wondering if it would
> be a good idea to wrap these one-liners to 72 characters
> automatically.
Can't you do this already? From "git-log(1)":
%w([[,[,]]]): switch line wrapping, like the -w
option of git-shortlog(1).
30 matches
Mail list logo
