[PATCH v7] fetch-pack.c: use oidset to check existence of loose object

2.227s avg: 11.896s On my MacBook Air which has slower lstat(2). * with this patch 14.501s * master 1m16.027s `git fetch` on slow disk will be improved largely. Signed-off-by: Takuto Ikuta --- cache.h | 2 ++ fetch-pack.c | 45 ++--- sha1_file.c |

Re: [PATCH v3] fetch-pack.c: use oidset to check existence of loose object

2018年3月14日(水) 2:53 Junio C Hamano : > Takuto Ikuta writes: > >> During fetch, everything_local() tries to mark common part by > >> walking the refs the other side advertised upon the first contact, > >> so it is correct that the number of checks is not reduced

[PATCH v6] fetch-pack.c: use oidset to check existence of loose object

2.227s avg: 11.896s On my MacBook Air which has slower lstat(2). * with this patch 14.501s * master 1m16.027s `git fetch` on slow disk will be improved largely. Signed-off-by: Takuto Ikuta --- cache.h | 2 ++ fetch-pack.c | 45 ++--- sha1_file.c |

Re: [PATCH v3] fetch-pack.c: use oidset to check existence of loose object

2018-03-10 3:00 GMT+09:00 Junio C Hamano : > Takuto Ikuta writes: > >> Yes, I just wanted to say 'git fetch' invokes fetch-pack. >> fetch-pack is skipped when running git fetch repeatedly while >> remote has no update by quickfetch. So I disabled it to see th

[PATCH v5] fetch-pack.c: use oidset to check existence of loose object

g: 11.896s On my MacBook Air which has slower lstat(2). * with this patch 14.501s * master 1m16.027s `git fetch` on slow disk will be improved largely. Signed-off-by: Takuto Ikuta --- cache.h | 2 ++ fetch-pack.c | 45 ++--- sha1_file.c | 3 ++

[PATCH v4] fetch-pack.c: use oidset to check existence of loose object

7s 11.175s 12.227s avg: 11.896s On my MacBook Air which has slower lstat(2). * with this patch 14.501s * master 1m16.027s `git fetch` on slow disk will be improved largely. Signed-off-by: Takuto Ikuta --- cache.h | 2 ++ fetch-pack.c | 45 ++--- s

Re: [PATCH] fetch-pack.c: use oidset to check existence of loose object

2018-03-09 3:42 GMT+09:00 Junio C Hamano : > Takuto Ikuta writes: >> This patch stores existing loose objects in hashmap beforehand and use >> it to check existence instead of using lstat. >> >> With this patch, the number of lstat calls in `git fetch` is reduced

Re: [PATCH] fetch-pack.c: use oidset to check existence of loose object

2018-03-09 2:19 GMT+09:00 René Scharfe : > Am 08.03.2018 um 13:06 schrieb Takuto Ikuta: >> +static int add_loose_objects_to_set(const struct object_id *oid, >> + const char *path, >> + void *data) >> +{

[PATCH v3] fetch-pack.c: use oidset to check existence of loose object

er lstat(2). * with this patch 14.501s * master 1m16.027s `git fetch` on slow disk will be improved largely. Signed-off-by: Takuto Ikuta --- cache.h | 2 ++ fetch-pack.c | 26 +++--- sha1_file.c | 3 +++ 3 files changed, 28 insertions(+), 3 deletions(-) diff --git a/cache.h

[PATCH v2 1/1] fetch-pack.c: use oidset to check existence of loose object

er lstat(2). * with this patch 14.501s * master 1m16.027s `git fetch` on slow disk will be improved largely. Signed-off-by: Takuto Ikuta --- cache.h | 2 ++ fetch-pack.c | 26 +++--- sha1_file.c | 3 +++ 3 files changed, 28 insertions(+), 3 deletions(-) diff --git a/cache.h

[PATCH v2 0/1] fetch-pack.c: use oidset to check existence of loose object

I removed unnecessary type cast, added comment in everthing_local(...), changed flag name and updated description. Takuto Ikuta (1): fetch-pack.c: use oidset to check existence of loose object cache.h | 2 ++ fetch-pack.c | 26 +++--- sha1_file.c | 3 +++ 3 files

[PATCH] fetch-pack.c: use oidset to check existence of loose object

patch 14.501s * master 1m16.027s `git fetch` on slow disk will be improved largely. Signed-off-by: Takuto Ikuta --- cache.h | 2 ++ fetch-pack.c | 22 +++--- sha1_file.c | 3 +++ 3 files changed, 24 insertions(+), 3 deletions(-) diff --git a/cache.h b/cache.h index

Re: [PATCH] Use OBJECT_INFO_QUICK to speedup git fetch-pack

Hi, Thank you for merging! Takuto 2017-11-28 20:27 GMT+09:00 Johannes Schindelin : > Hi, > > On Tue, 28 Nov 2017, Takuto Ikuta wrote: > >> As long as this PR is included in next Git for Windows release, I >> won't suffer from slow git fetch. >> https://githu

Re: [PATCH] Use OBJECT_INFO_QUICK to speedup git fetch-pack

ednesday, >> > to allow for a new cURL version to be bundled. >> >> Is this an updated 2.15.0 or are you planning to package 2.15.1? > > If there is a 2.15.1 to pick up for me, I'll take it. Otherwise it'll be > Git for Windows v2.15.0(2). > > Ciao, > Dscho -- Takuto Ikuta Software Engineer in Tokyo Chrome Infrastructure (goma team)

Re: [PATCH] Use OBJECT_INFO_QUICK to speedup git fetch-pack

t; refs > benefits from that patch. And it would be nice to know how much a > real life scenario actually does improve. > > Thanks. In chromium repository, your 5th patch does not improve performance, took more than 5 minutes to run fetch on windows. 4th patch is very important for the repository in daily fetch. I hope your 4th patch will be merged. Thanks. -- Takuto Ikuta Software Engineer in Tokyo Chrome Infrastructure (goma team)

[PATCH] Use OBJECT_INFO_QUICK to speedup git fetch-pack

remote refs, git fetch takes more than 3 minutes if fetch-pack runs on my windows workstation. This patch improves the time to around 17 seconds in the same machine. Signed-off-by: Takuto Ikuta --- fetch-pack.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/fetch-pack.c b/fetch