Re: [PATCH] fix segv with corrupt tag object

2019-08-26 Thread Stefan Sperling
On Mon, Aug 26, 2019 at 10:20:20AM -0700, Junio C Hamano wrote: > Stefan Sperling writes: > > > The root cause of this bug seems to be that the valid assumption > > that obj->parsed implies a successfully parsed object is broken by > > parse_tag_buffer() because thi

Re: [PATCH] fix segv with corrupt tag object

2019-08-26 Thread Stefan Sperling
On Sun, Aug 25, 2019 at 09:52:56AM +0200, René Scharfe wrote: > Am 25.08.19 um 01:09 schrieb Stefan Sperling: > > A tag object which lacks newlines won't be parsed correctly. > > Git fails to detect this error and crashes due to a NULL deref: > > > > $ git arch

[PATCH] fix segv with corrupt tag object

2019-08-24 Thread Stefan Sperling
A tag object which lacks newlines won't be parsed correctly. Git fails to detect this error and crashes due to a NULL deref: $ git archive 1.0.0 Segmentation fault (core dumped) $ git checkout 1.0.0 Segmentation fault (core dumped) $ See the attached tarball for a reproduction repository. Also mi