Re: [PATCH v4] git-send-pack: fix --all option when used with directory

On 31/03/16 23:28, Junio C Hamano wrote: Thanks, will queue. Thanks a lot! -- Regards, Stanislav -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] git-send-pack: Fix --all option when used with directory

Thanks a lot, Jeff, your explanation really helped! -- Regards, Stanislav On 24/03/16 20:02, Jeff King wrote: On Thu, Mar 24, 2016 at 07:47:12PM +0200, Stanislav Kolotinskiy wrote: Thanks for noticing; the above explanation however does not make it very clear why the symptom exhibits itself

Re: [PATCH] git-send-pack: Fix --all option when used with directory

On 24/03/16 19:37, Jeff King wrote: I guess a follow-up to my question is: what does "git send-pack" do that "git push" does not? Again, this is just for my curiosity (the answer may be "nothing, we just happened to build our scripts around send-pack", and that is perfectly fine). Well, this is s

Re: [PATCH] git-send-pack: Fix --all option when used with directory

On 24/03/16 18:11, Junio C Hamano wrote: Please see "git shortlog --no-merges" output from recent history and notice that s/Fix/fix/ would make things more consistent. Thanks for letting me know, I'll update that. Thanks for noticing; the above explanation however does not make it very clear wh

Re: [PATCH v2] git-send-pack: Fix --all option when used with directory

Please ignore this thread, I sent the email without making sure that I copied commit message. I'm sorry for that. On 24/03/16 16:14, Stanislav Kolotinskiy wrote: --- builtin/send-pack.c | 2 +- t/t5400-send-pack.sh | 12 2 files changed, 13 insertions(+), 1 deletion(-)

[PATCH v3] git-send-pack: Fix --all option when used with directory

of refspecs (nr_refspecs) is 0, refspecs contain all the arguments and switches passed to send-pack. This ensures that send-pack will stop execution only when --all or --mirror switch is used in conjunction with any refs passed. Signed-off-by: Stanislav Kolotinskiy --- builtin/send-pack.c | 2

[PATCH v2] git-send-pack: Fix --all option when used with directory

--- builtin/send-pack.c | 2 +- t/t5400-send-pack.sh | 12 2 files changed, 13 insertions(+), 1 deletion(-) diff --git a/builtin/send-pack.c b/builtin/send-pack.c index f6e5d64..19f0577 100644 --- a/builtin/send-pack.c +++ b/builtin/send-pack.c @@ -225,7 +225,7 @@ int cmd_send_pack

Re: [PATCH] git-send-pack: Fix --all option when used with directory

On 23/03/16 23:22, Jeff King wrote: Not that it matters for this bug, but for my own curiosity, what do you use "send-pack --all" for? I've generally assumed that nobody directly calls send-pack themselves these days, but of course we have no data to support that either way. So I am always intere

[PATCH] git-send-pack: Fix --all option when used with directory

of refspecs (nr_refspecs) is 0, refspecs contain all the arguments and switches passed to send-pack. This ensures that send-pack will stop execution only when --all or --mirror switch is used in conjunction with any refs passed. Signed-off-by: Stanislav Kolotinskiy --- builtin/send-pack.c