Re: [PATCH] push: Alias pushurl from push rewrites

2013-03-28 Thread Rob Hoelz
On Thu, 28 Mar 2013 12:25:07 -0700 Jonathan Nieder wrote: > Josh Triplett wrote: > > > Related to this, as a path forward, I do think it makes sense to > > have a setting usable as an insteadOf that only applies to pushurl, > > even though pushInsteadOf won't end up serving that purpose. That >

Re: [PATCH] push: Alias pushurl from push rewrites

2013-03-27 Thread Rob Hoelz
On Wed, 27 Mar 2013 15:56:56 -0700 Jonathan Nieder wrote: > Rob Hoelz wrote: > > > My mistake; I had not seen it! I thought you may have found a bug > > in my implementation, so I wanted to double check. =) > > Well, I had found an unfortunate consequence of the imple

Re: [PATCH] push: Alias pushurl from push rewrites

2013-03-27 Thread Rob Hoelz
On Wed, 27 Mar 2013 15:47:35 -0700 Jonathan Nieder wrote: > Hi, > > Rob Hoelz wrote: > > On Wed, 27 Mar 2013 11:23:45 -0700 > > Jonathan Nieder wrote: > > >> Suppose I configure > >> > >>[url "git://anongit.myserver.example

Re: [PATCH] push: Alias pushurl from push rewrites

2013-03-27 Thread Rob Hoelz
On Wed, 27 Mar 2013 15:07:18 -0700 Junio C Hamano wrote: > Jonathan Nieder writes: > > > Sorry, typo. The configuration in the example above should have > > been > > > > [url "git://anongit.myserver.example.com/"] > > insteadOf = myserver.example.com: > > [url "myserver.exa

[PATCH] push: Alias pushurl from push rewrites

2013-03-27 Thread Rob Hoelz
posed to pushInsteadOf values for expanding the pushurl alias. This commit fixes that. Signed-off-by: Rob Hoelz --- Documentation/config.txt | 3 +- remote.c | 6 +++- t/t5516-fetch-push.sh| 77 +++- 3 files changed, 75 ins

Re: [PATCH] push: Alias pushurl from push rewrites

2013-03-27 Thread Rob Hoelz
On Wed, 27 Mar 2013 11:23:45 -0700 Jonathan Nieder wrote: > Rob Hoelz wrote: > > > --- a/remote.c > > +++ b/remote.c > > @@ -465,7 +465,11 @@ static void alias_all_urls(void) > > if (!remotes[i]) > > continue; >

[PATCH] push: Alias pushurl from push rewrites

2013-03-27 Thread Rob Hoelz
posed to pushInsteadOf values for expanding the pushurl alias. This commit fixes that. Signed-off-by: Rob Hoelz --- remote.c | 6 +++- t/t5516-fetch-push.sh | 77 +++ 2 files changed, 82 insertions(+), 1 deletion(-) diff --git a/

Re: [PATCH] push: Alias pushurl from push rewrites

2013-03-27 Thread Rob Hoelz
On Wed, 20 Mar 2013 07:35:58 -0700 Junio C Hamano wrote: > Rob Hoelz writes: > > > On 3/19/13 7:08 PM, Junio C Hamano wrote: > >> Jonathan Nieder writes: > >> > >>> Junio C Hamano wrote: > >>>> Jonathan Nieder write

Re: [PATCH] push: Alias pushurl from push rewrites

2013-03-20 Thread Rob Hoelz
On 3/19/13 7:08 PM, Junio C Hamano wrote: > Jonathan Nieder writes: > >> Junio C Hamano wrote: >>> Jonathan Nieder writes: Test nits: ... Hope that helps, Jonathan Nieder (3): push test: use test_config where appropriate push test: simplify check of push res

[PATCH] push: Alias pushurl from push rewrites

2013-03-18 Thread Rob Hoelz
posed to pushInsteadOf values for expanding the pushurl alias. This commit fixes that. Signed-off-by: Rob Hoelz --- remote.c | 2 +- t/t5516-fetch-push.sh | 81 +++ 2 files changed, 82 insertions(+), 1 deletion(-) diff --git a/

Re: [PATCH] push: Alias pushurl from push rewrites

2013-03-18 Thread Rob Hoelz
On Sun, 17 Mar 2013 16:35:59 -0700 Junio C Hamano wrote: > Rob Hoelz writes: > > > git push currently doesn't consider pushInsteadOf when > > using pushurl; this tests and fixes that. > > > > If you use pushurl with an alias that has a pushInsteadOf > &g

Re: [PATCH] push: Alias pushurl from push rewrites

2013-03-18 Thread Rob Hoelz
On 3/18/13 12:35 AM, Junio C Hamano wrote: > Rob Hoelz writes: > >> git push currently doesn't consider pushInsteadOf when >> using pushurl; this tests and fixes that. >> >> If you use pushurl with an alias that has a pushInsteadOf configuration >> value

[PATCH] push: Alias pushurl from push rewrites

2013-03-17 Thread Rob Hoelz
thub: [url "git://github.com/myuser/"] insteadOf = mygithub: [url "g...@github.com:myuser/"] pushInsteadOf = mygithub: [remote "origin"] url = github:organization/project pushurl = mygithub:project Signed-off-by: Rob Hoelz --- remote.c

Re: [PATCH] remote..pushurl does not consider aliases when pushing

2013-03-17 Thread Rob Hoelz
On Sun, 17 Mar 2013 15:14:32 -0700 Junio C Hamano wrote: > Rob Hoelz writes: > > > Hi everyone! I found a bug in Git today and wrote up a fix; I did > > my best to conform to the rules layed out in > > Documentation/SubmittingPatches, but please let me know if I need &

[PATCH] remote..pushurl does not consider aliases when pushing

2013-03-17 Thread Rob Hoelz
ine I modified. I hope my commit messages explain the problem I encountered well enough; if not, I can always go back and amend them. Patches follow. -Rob >From 5007b11e86c0835807632cb41e6cfa75ce9a1aa1 Mon Sep 17 00:00:00 2001 From: Rob Hoelz Date: Sun, 17 Mar 2013 21:49:20 +0100 Subject: [P