Since due to some reason, the previous patch-series list was
unavailable on the mailing list, I have re-posted the series.
It is available at:
https://public-inbox.org/git/20180202045745.5076-1-pc44...@gmail.com/
Thanks,
Prathamesh Chavan
make the 'path' variable available and
document it as a deprecated synonym of 'sm_path'.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
Documentation/git-submodule.txt | 10 ++
1 file changed, 6 insertions(+), 4 deletions
uot;--super-prefix displaypath",
to the args argv_array structure. Other required arguments and the
input of submodule-foreach is also appended to this argv_array.
Helped-by: Brandon Williams
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
buil
It was observed that the variable '$displaypath' was accessible but
undocumented. Hence, document it.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
Documentation/git-submodule.txt | 6 --
t/t7407-submodule-foreach.
It does not contain the topmost superproject as the author assumed,
but the direct superproject, such that $toplevel/$sm_path is the
actual absolute path of the submodule.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
Documentation/git
ies-3
Build #202
Prathamesh Chavan (5):
submodule foreach: correct '$path' in nested submodules from a
subdirectory
submodule foreach: document '$sm_path' instead of '$path'
submodule foreach: clarify the '$toplevel' variable documentation
submo
task. With a human on
the keyboard the feedback loop is short and the changed behavior can be
adapted to quickly unlike some automation that can break silently.
Discussed-with: Ramsay Jones
Signed-off-by: Prathamesh Chavan
Signed-off-by: Stefan Beller
---
git-submodule.sh | 1 -
ies-3
Build #202
Prathamesh Chavan (5):
submodule foreach: correct '$path' in nested submodules from a
subdirectory
submodule foreach: document '$sm_path' instead of '$path'
submodule foreach: clarify the '$toplevel' variable documentation
submo
It was observed that the variable '$displaypath' was accessible but
undocumented. Hence, document it.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
Documentation/git-submodule.txt | 6 --
t/t7407-submodule-foreach.
uot;--super-prefix displaypath",
to the args argv_array structure. Other required arguments and the
input of submodule-foreach is also appended to this argv_array.
Helped-by: Brandon Williams
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
buil
It does not contain the topmost superproject as the author assumed,
but the direct superproject, such that $toplevel/$sm_path is the
actual absolute path of the submodule.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
Documentation/git
task. With a human on
the keyboard the feedback loop is short and the changed behavior can be
adapted to quickly unlike some automation that can break silently.
Discussed-with: Ramsay Jones
Signed-off-by: Prathamesh Chavan
Signed-off-by: Stefan Beller
---
git-submodule.sh | 1 -
make the 'path' variable available and
document it as a deprecated synonym of 'sm_path'.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
Documentation/git-submodule.txt | 10 ++
1 file changed, 6 insertions(+), 4 deletions
c_submodule_cb() and print_default_remote().
The function print_default_remote() is introduced for getting
the default remote as stdout.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 193 +
: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 147
git-submodule.sh| 55 +
2 files changed, 148 insertions(+), 54 deletions(-)
diff --git a/builtin/submodule
ad of die_errno.
As before you can find this series at:
https://github.com/pratham-pc/git/commits/patch-series-2
And its build report is available at:
https://travis-ci.org/pratham-pc/git/builds/
Branch: patch-series-2
Build #197
Prathamesh Chavan (2):
submodule: port submodule subcommand 's
: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 147
git-submodule.sh| 55 +
2 files changed, 148 insertions(+), 54 deletions(-)
diff --git a/builtin/submodule
c_submodule_cb() and print_default_remote().
The function print_default_remote() is introduced for getting
the default remote as stdout.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 195 +
public-inbox.org/git/xmqq7esq4tf6@gitster.mtv.corp.google.com/
Prathamesh Chavan (2):
submodule: port submodule subcommand 'sync' from shell to C
submodule: port submodule subcommand 'deinit' from shell to C
builtin/submodule--helper.c | 342 ++
On Wed, Jan 10, 2018 at 2:54 AM, Junio C Hamano wrote:
> Prathamesh Chavan writes:
>
>> The same mechanism is used even for porting this submodule
>> subcommand, as used in the ported subcommands till now.
>> The function cmd_deinit in split up after porting into four
>
: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 153
git-submodule.sh| 55 +---
2 files changed, 154 insertions(+), 54 deletions(-)
diff --git a/builtin/submodule
c_submodule_cb() and print_default_remote().
The function print_default_remote() is introduced for getting
the default remote as stdout.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 192 +
ranch: patch-series-2
Build #195
[1]: https://public-inbox.org/git/20170807211900.15001-6-pc44...@gmail.com/
[2]: https://public-inbox.org/git/20170807211900.15001-7-pc44...@gmail.com/
[3]: https://public-inbox.org/git/20171006132415.2876-4-pc44...@gmail.com/
Prathamesh Chavan (2):
submodule:
Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 35 +++
1 file changed, 23 insertions(+), 12 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 06ed02f99..56c1c52e2 100644
--- a/builtin/submodule
189
The above changes are also push on github and are available at:
https://github.com/pratham-pc/git/commits/patch-series-1-next
Prathamesh Chavan (3):
submodule--helper: introduce get_submodule_displaypath()
submodule--helper: introduce for_each_listed_submodule()
submodule: port submodule
Introduce function for_each_listed_submodule() and replace a loop
in module_init() with a call to it.
The new function will also be used in other parts of the
system in later patches.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin
tefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 198
git-submodule.sh| 61 +-
2 files changed, 199 insertions(+), 60 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--help
tefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 207
git-submodule.sh| 61 +
2 files changed, 208 insertions(+), 60 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--help
Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 35 +++
1 file changed, 23 insertions(+), 12 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 818fe74f0..cdae54426 100644
--- a/builtin/submodule
Introduce function for_each_listed_submodule() and replace a loop
in module_init() with a call to it.
The new function will also be used in other parts of the
system in later patches.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin
re you can find this series at:
https://github.com/pratham-pc/git/commits/patch-series-1
And its build report is available at:
https://travis-ci.org/pratham-pc/git/builds/
Branch: patch-series-1
Build #184
Prathamesh Chavan (3):
submodule--helper: introduce get_submodule_displaypath()
su
Introduce function for_each_listed_submodule() and replace a loop
in module_init() with a call to it.
The new function will also be used in other parts of the
system in later patches.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin
Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 38 ++
1 file changed, 26 insertions(+), 12 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 818fe74f0..d24ac9028 100644
--- a/builtin/submodule
printing.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 63 +
git-submodule.sh| 16 ++--
2 files changed, 65 insertions(+), 14 deletions(-)
diff --git a
ds/
Branch: patch-series-1
Build #179
Thanks, Han-Wen Nienhuys for reviewing the previous patch series.
Prathamesh Chavan (4):
submodule--helper: introduce get_submodule_displaypath()
submodule--helper: introduce for_each_listed_submodule()
submodule: port set_name_rev() from shell to C
bcommand
as it is no longer used.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 162 +++-
git-submodule.sh| 49 +-
2 files changed, 147 insertions(+), 6
n its list. The function submodule_status() is responsible
for generating the status each submodule it is called for, and
then calls print_status().
Finally, the function print_status() handles the printing of submodule's
status.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signe
Introduce function for_each_listed_submodule() and replace a loop
in module_init() with a call to it.
The new function will also be used in other parts of the
system in later patches.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin
Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 37 +
1 file changed, 25 insertions(+), 12 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 818fe74f0..e25854371 100644
--- a/builtin/submodule
printing.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 63 +
git-submodule.sh| 16 ++--
2 files changed, 65 insertions(+), 14 deletions(-)
diff --git a
h-series-1-next
Prathamesh Chavan (4):
submodule--helper: introduce get_submodule_displaypath()
submodule--helper: introduce for_each_listed_submodule()
submodule: port set_name_rev() from shell to C
submodule: port submodule subcommand 'status' from shell to C
builtin/
7;ll see the dirty merges and will resend the whole series after reviewing
the dirty merge and sending a new one with/without changes as required.
Thanks,
Prathamesh Chavan
n its list. The function submodule_status() is responsible
for generating the status each submodule it is called for, and
then calls print_status().
Finally, the function print_status() handles the printing of submodule's
status.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signe
printing.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 63 +
git-submodule.sh| 16 ++--
2 files changed, 65 insertions(+), 14 deletions(-)
diff --git a
Introduce function for_each_listed_submodule() and replace a loop
in module_init() with a call to it.
The new function will also be used in other parts of the
system in later patches.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin
Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 38 +-
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 84562ec83..e666f84ba 100644
--- a/builtin/submodule
series at:
https://github.com/pratham-pc/git/commits/week-14-1
And its build report is available at:
https://travis-ci.org/pratham-pc/git/builds/
Branch: week-14-1
Build #164
Prathamesh Chavan (4):
submodule--helper: introduce get_submodule_displaypath()
submodule--helper: introduce
t. The function submodule_status() is responsible
for generating the status each submodule it is called for, and
then calls print_status().
Finally, the function print_status() handles the printing of submodule's
status.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-b
printing.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 63 +
git-submodule.sh| 16 ++--
2 files changed, 65 insertions(+), 14 deletions(-)
diff --git a
Introduce function for_each_submodule() and replace a loop
in module_init() with a call to it.
The new function will also be used in other parts of the
system in later patches.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule
Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 38 +-
1 file changed, 25 insertions(+), 13 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 84562ec83..e666f84ba 100644
--- a/builtin/submodule
/week-14-1
And the build report is available at:
https://travis-ci.org/pratham-pc/git/builds/
Branch: week-14-1
Build #163
Prathamesh Chavan (4):
submodule--helper: introduce get_submodule_displaypath()
submodule--helper: introduce for_each_submodule()
submodule: port set_name_rev() from she
SUMMARY OF MY PROJECT:
Git submodule subcommands are currently implemented by using shell script
'git-submodule.sh'. There are several reasons why we'll prefer not to
use the shell script. My project intends to convert the subcommands into
C code, thus making them builtins. This will increase Git'
On Mon, Aug 21, 2017 at 10:17 PM, Heiko Voigt wrote:
> On Mon, Aug 21, 2017 at 09:45:14PM +0530, Prathamesh Chavan wrote:
>> Function set_name_rev() is ported from git-submodule to the
>> submodule--helper builtin. The function get_name_rev() generates the
>> value of
n its list. The function submodule_status() is responsible
for generating the status each submodule it is called for, and
then calls print_status().
Finally, the function print_status() handles the printing of submodule's
status.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-b
Beller
Signed-off-by: Prathamesh Chavan
---
As said in the previous update,
a short patch series is floated for the maintainer's review,
and is consisting of the following changes:
* introduce function get_submodule_displaypath()
* introduce function for_each_submodule_list()
* port fun
Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 63 +
git-submodule.sh| 16 ++--
2 files changed, 65 insertions(+), 14 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin
Introduce function for_each_submodule_list() and
replace a loop in module_init() with a call to it.
The new function will also be used in other parts of the
system in later patches.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin
SUMMARY OF MY PROJECT:
Git submodule subcommands are currently implemented by using shell script
'git-submodule.sh'. There are several reasons why we'll prefer not to
use the shell script. My project intends to convert the subcommands into
C code, thus making them builtins. This will increase Git'
tored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
In this new version, the following changes have been made:
* A comment was added to clarify why the env variables were made
available only for the case of argc == 1.
builtin/submodule--helper.c | 142 ++
It was observed that the variable '$displaypath' was accessible but
undocumented. Hence, document it.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
Documentation/git-submodule.txt | 6 --
t/t7407-submodule-foreach.
eventually calling the generate_submodule_summary() function.
The function generate_submodule_summary() takes care of generating
the summary for each submodule and then calls the function
print_summary() for printing it.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Pratham
make the 'path' variable available and
document it as a deprecated synonym of 'sm_path'.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
Documentation/git-submodule.txt | 10 ++
1 file changed, 6 insertions(+), 4 deletions
It does not contain the topmost superproject as the author assumed,
but the direct superproject, such that $toplevel/$sm_path is the
actual absolute path of the submodule.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
Documentation/git
task. With a human on
the keyboard the feedback loop is short and the changed behavior can be
adapted to quickly unlike some automation that can break silently.
Discussed-with: Ramsay Jones
Signed-off-by: Prathamesh Chavan
Signed-off-by: Stefan Beller
---
git-submodule.sh | 1 -
Change the scope of function count_lines for allowing the function
to be reused in other parts of the code as well.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
diff.c | 2 +-
diff.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff
n its list. The function submodule_status() is responsible
for generating the status each submodule it is called for, and
then calls print_status().
Finally, the function print_status() handles the printing of submodule's
status.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-b
print_default_remote().
The function print_default_remote() is introduced for getting
the default remote as stdout.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 183 ++
: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 148
git-submodule.sh| 55 +---
2 files changed, 149 insertions(+), 54 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule
Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 6abdad329..7af4de09b 100644
--- a/builtin/submodule
inbox.org/git/CAGZ79kbyyR54me_+wQDZRrikqKTp_a98yozVfr8P85QHfyyy=q...@mail.gmail.com/
[5]: https://travis-ci.org/pratham-pc/git/builds/
[6]: https://github.com/pratham-pc/git/commits/week-12
Prathamesh Chavan (13):
submodule--helper: introduce get_submodule_displaypath()
submodule--helper: introduce for_each_subm
Introduce function for_each_submodule_list() and
replace a loop in module_init() with a call to it.
The new function will also be used in other parts of the
system in later patches.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin
Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 63 +
git-submodule.sh| 16 ++--
2 files changed, 65 insertions(+), 14 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin
On Sat, Aug 5, 2017 at 10:25 PM, Christian Couder
wrote:
> On Sat, Aug 5, 2017 at 12:28 PM, Prathamesh Chavan wrote:
>> On Tue, Aug 1, 2017 at 4:57 AM, Christian Couder
>> wrote:
>>> On Mon, Jul 31, 2017 at 10:56 PM, Prathamesh Chavan
>>> wrote:
>>
On Tue, Aug 1, 2017 at 4:57 AM, Christian Couder
wrote:
> On Mon, Jul 31, 2017 at 10:56 PM, Prathamesh Chavan wrote:
>
>> * variable head was no longer used in module_summary() and instead the strbuf
>> was utilized.
>
> Good but there might be a few problems in the w
On Tue, Aug 1, 2017 at 3:12 AM, Stefan Beller wrote:
> On Mon, Jul 31, 2017 at 1:56 PM, Prathamesh Chavan wrote:
>> The same mechanism is used even for porting this submodule
>> subcommand, as used in the ported subcommands till now.
>> The function cmd_deinit in split
On Tue, Aug 1, 2017 at 2:42 AM, Stefan Beller wrote:
> On Mon, Jul 31, 2017 at 1:56 PM, Prathamesh Chavan wrote:
>> This aims to make git-submodule 'status' a built-in. Hence, the function
>> cmd_status() is ported from shell to C. This is done by introducing
>>
alling the print_submodule_summary() function.
Finally, the print_submodule_summary() takes care of generating
and printing the summary for each submodule.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
In this new version, the following changes have
It does not contain the topmost superproject as the author assumed,
but the direct superproject, such that $toplevel/$sm_path is the
actual absolute path of the submodule.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
Documentation/git
print_default_remote().
The function print_default_remote() is introduced for getting
the default remote as stdout.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
In this new version, the following changes have been made:
* There was no good reas
Change the scope of function count_lines for allowing the function
to be reused in other parts of the code as well.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
diff.c | 2 +-
diff.h | 1 +
2 files changed, 2 insertions(+), 1 deletion(-)
diff
make the 'path' variable available and
document it as a deprecated synonym of 'sm_path'.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
This patch is same as its previous version.
Although here I'll like to add a point that
It was observed that the variable '$displaypath' was accessible but
undocumented. Hence, document it.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
In this new version, the following changes have been made:
* Spelling mistake in
: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
In this new version, the following changes have been made:
* In the function deinit_submodule, since the test is_git_directory()
adds an additional condition, instead is_directory() is used to check
if "sm_path/.git" is a directory
tored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
In this new version, the following changes have been made:
* Comment style is improved in the function runcommand_in_submodule()
* Comment in added about why the variable "path" was exposed via args
argv_array instead of expos
task. With a human on
the keyboard the feedback loop is short and the changed behavior can be
adapted to quickly unlike some automation that can break silently.
Discussed-with: Ramsay Jones
Signed-off-by: Prathamesh Chavan
Signed-off-by: Stefan Beller
---
git-submodule.sh | 1 -
n its list. The function submodule_status() is responsible
for generating the status each submodule it is called for, and
then calls print_status().
Finally, the function print_status() handles the printing of submodule's
status.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-b
Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
In this new version, the following changes have been made:
* The variable namerev from print_name_rev is now freed at the end of the
function.
builtin/submodule--helper.c | 64 +
git
Introduce function for_each_submodule_list() and
replace a loop in module_init() with a call to it.
The new function will also be used in other parts of the
system in later patches.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
builtin
Beller
Signed-off-by: Prathamesh Chavan
---
builtin/submodule--helper.c | 33 ++---
1 file changed, 22 insertions(+), 11 deletions(-)
diff --git a/builtin/submodule--helper.c b/builtin/submodule--helper.c
index 6abdad329..7af4de09b 100644
--- a/builtin/submodule
SUMMARY OF MY PROJECT:
Git submodule subcommands are currently implemented by using shell script
'git-submodule.sh'. There are several reasons why we'll prefer not to
use the shell script. My project intends to convert the subcommands into
C code, thus making them builtins. This will increase Git'
On Sun, Jul 30, 2017 at 10:58 AM, Christian Couder
wrote:
> On Sun, Jul 30, 2017 at 12:23 AM, Prathamesh Chavan wrote:
>
>> +static int module_summary(int argc, const char **argv, const char *prefix)
>> +{
>> + struct summary_cb info = SUMMARY_CB_INIT;
&
It was observed that the variable '$displaypath' was accessible but
undocumented. Hence, document it.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
In this new version, the following changes have been made:
* Spelling mistake in
tored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
In this new version, the following changes have been made:
* Comment style is improved in the function runcommand_in_submodule()
* Comment in added about why the variable "path" was exposed via args
argv_array instead of expos
make the 'path' variable available and
document it as a deprecated synonym of 'sm_path'.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
This patch is same as its previous version.
Although here I'll like to add a point that
It does not contain the topmost superproject as the author assumed,
but the direct superproject, such that $toplevel/$sm_path is the
actual absolute path of the submodule.
Discussed-with: Ramsay Jones
Signed-off-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
Documentation/git
task. With a human on
the keyboard the feedback loop is short and the changed behavior can be
adapted to quickly unlike some automation that can break silently.
Discussed-with: Ramsay Jones
Signed-off-by: Prathamesh Chavan
Signed-off-by: Stefan Beller
---
git-submodule.sh | 1 -
alling the print_submodule_summary() function.
Finally, the print_submodule_summary() takes care of generating
and printing the summary for each submodule.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
In this new version, the following changes have
: Stefan Beller
Signed-off-by: Prathamesh Chavan
---
In this new version, the following changes have been made:
* In the function deinit_submodule, since the test is_git_directory()
adds an additional condition, instead is_directory() is used to check
if "sm_path/.git" is a directory
n its list. The function submodule_status() is responsible
for generating the status each submodule it is called for, and
then calls print_status().
Finally, the function print_status() handles the printing of submodule's
status.
Mentored-by: Christian Couder
Mentored-by: Stefan Beller
Signed-off-b
1 - 100 of 220 matches
Mail list logo
