From: Pranit Bauva
Reimplement the `bisect_autostart()` shell function in C and add the
C implementation from `bisect_next()` which was previously left
uncovered. Also add a subcommand `--bisect-autostart` to
`git bisect--helper` be called from `bisect_state()` from
git-bisect.sh .
Using
From: Pranit Bauva
The `bisect-clean-state` subcommand is no longer used in the shell
script while the C code uses `bisect_clean_state()` thus remove the
subcommand.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
Signed-off-by: Tanushree Tumane
From: Pranit Bauva
Reimplement the `bisect_replay` shell function in C and also add
`--bisect-replay` subcommand to `git bisect--helper` to call it from
git-bisect.sh
Using `--bisect-replay` subcommand is a temporary measure to port shell
function to C so as to use the existing test suite. As
From: Pranit Bauva
The `--write-terms` subcommand is no longer used in the shell script and
the function `write_terms()` is called from the C implementation of
`set_terms()` and `bisect_start()`.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Mentored-by: Johannes Schindelin
From: Pranit Bauva
Dequoting the arguments was introduced in 25b48b5c to port the function
`bisect_next()` but after the `bisect_replay()` porting, the dequoting
is carried out itself when it passes the arguments to `bisect_start()`
in a simpler way thus dequoting again isn't required. So r
From: Pranit Bauva
Reimplement the `bisect_skip()` shell function in C and also add
`bisect-skip` subcommand to `git bisect--helper` to call it from
git-bisect.sh
Using `--bisect-skip` subcommand is a temporary measure to port shell
function to C so as to use the existing test suite. As more
From: Pranit Bauva
The `--check-and-set-terms` subcommand is no longer used in the shell
script and the function `check_and_set_terms()` is called from the C
implementation.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Mentored-by: Johannes Schindelin
Signed-off-by: Pranit Bauva
From: Pranit Bauva
Reimplement the `bisect_state()` shell function in C and also add a
subcommand `--bisect-state` to `git-bisect--helper` to call it from
git-bisect.sh .
Using `--bisect-state` subcommand is a temporary measure to port shell
function to C so as to use the existing test suite
From: Pranit Bauva
The `--next-all` subcommand is no longer used in the shell script and
the function `bisect_next_all()` is called from the C implementation of
`bisect_next()`.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
Signed-off-by: Tanushree
From: Pranit Bauva
The `--bisect-autostart` subcommand is no longer used in the shell
script and the function `bisect_autostart()` is called from the C
implementation.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Mentored-by: Johannes Schindelin
Signed-off-by: Pranit Bauva
From: Pranit Bauva
The `--bisect-auto-next` subcommand is no longer used in the shell
script and the function `bisect_auto_next()` is called from the C
implementation.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Mentored-by: Johannes Schindelin
Signed-off-by: Pranit Bauva
From: Pranit Bauva
Reimplement the `bisect_log()` shell function in C and also add
`--bisect-log` subcommand to `git bisect--helper` to call it from
git-bisect.sh .
Using `--bisect-log` subcommand is a temporary measure to port shell
function to C so as to use the existing test suite. As more
From: Pranit Bauva
The `--check-expected-revs` subcommand is no longer used in the shell
script and the function `check_expected_revs()` is called from the C
implementation of `bisect_next()`.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Mentored-by: Johannes Schindelin
Signed
From: Pranit Bauva
The `--bisect-write` subcommand is no longer used in the shell script
and the function `bisect_write()` is called from the C implementation.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Mentored-by: Johannes Schindelin
Signed-off-by: Pranit Bauva
Signed-off
From: Pranit Bauva
Reimplement the `bisect_next()` and the `bisect_auto_next()` shell function
in C and add the subcommands to `git bisect--helper` to call it from
git-bisect.sh .
Using `--bisect-next` and `--bisect-auto-start` subcommands is a
temporary measure to port shell function to C so
From: Pranit Bauva
As more and more calls are happening to the subcommands in `git
bisect--helper`, more specifically when `bisect_start $rev` is converted to
`git bisect--helper --bisect-start $rev` it is necessary to dequote the
arguments because of shell to C conversion.
Mentored-by
From: Pranit Bauva
Since we want to get rid of git-bisect.sh it would be necessary to
convert those exit() calls to return statements so that errors can be
reported.
Emulate try catch in C by converting `exit()` to
`return `. Follow POSIX conventions to return
to indicate error.
Turn `exit
From: Pranit Bauva
Since we want to get rid of git-bisect.sh it would be necessary to
convert those exit() calls to return statements so that errors can be
reported.
Emulate try catch in C by converting `exit()` to
`return `. Follow POSIX conventions to return
to indicate error.
Turn `exit
From: Pranit Bauva
Since we want to get rid of git-bisect.sh it would be necessary to
convert those exit() calls to return statements so that errors can be
reported.
Emulate try catch in C by converting `exit()` to
`return `. Follow POSIX conventions to return
to indicate error.
Turn `exit
From: Pranit Bauva
Since we want to get rid of git-bisect.sh it would be necessary to
convert those exit() calls to return statements so that errors can be
reported.
Emulate try catch in C by converting `exit()` to
`return `. Follow POSIX conventions to return
to indicate error.
Turn `exit
From: Pranit Bauva
Since we want to get rid of git-bisect.sh it would be necessary to
convert those exit() calls to return statements so that errors can be
reported.
Emulate try catch in C by converting `exit()` to
`return `. Follow POSIX conventions to return
to indicate error.
Turn `exit
From: Pranit Bauva
With the conversion of `bisect_auto_next()` in previous commit,
`bisect_start()` has been successfully ported to C.
Add the subcommands to `git bisect--helper` and call it from
git-bisect.sh.
Remove `bisect_start()` shell method and call `git bisect--helper
--bisect-start
From: Pranit Bauva
Since we want to get rid of git-bisect.sh it would be necessary to
convert those exit() calls to return statements so that errors can be
reported.
Emulate try catch in C by converting `exit()` to
`return `. Follow POSIX conventions to return
to indicate error.
Modify
From: Pranit Bauva
Reimplement `bisect_next_check` shell function in C and add
`bisect-next-check` subcommand to `git bisect--helper` to call it from
git-bisect.sh .
`bisect_voc` shell function is no longer useful now and is replaced by
using a char *[] of "new|bad" and "g
From: Pranit Bauva
Reimplement the `get_terms` and `bisect_terms` shell function in C and
add `bisect-terms` subcommand to `git bisect--helper` to call it from
git-bisect.sh .
Using `--bisect-terms` subcommand is a temporary measure to port shell
function in C so as to use the existing test
From: Pranit Bauva
Reimplement the `bisect_start` shell function partially in C and add
`bisect-start` subcommand to `git bisect--helper` to call it from
git-bisect.sh .
The last part is not converted because it calls another shell function.
`bisect_start` shell function will be completed after
From: Pranit Bauva
Reimplement `bisect_reset` shell function in C and add a `--bisect-reset`
subcommand to `git bisect--helper` to call it from git-bisect.sh .
Using `bisect_reset` subcommand is a temporary measure to port shell
functions to C so as to use the existing test suite. As more
From: Pranit Bauva
is_empty_file() can help to refactor a lot of code. This will be very
helpful in porting "git bisect" to C.
Suggested-by: Torsten Bögershausen
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin
From: Pranit Bauva
Reimplement the `bisect_write` shell function in C and add a
`bisect-write` subcommand to `git bisect--helper` to call it from
git-bisect.sh
Using `--bisect-write` subcommand is a temporary measure to port shell
function in C so as to use the existing test suite. As more
From: Pranit Bauva
Reimplement the `check_and_set_terms` shell function in C and add
`check-and-set-terms` subcommand to `git bisect--helper` to call it from
git-bisect.sh
Using `--check-and-set-terms` subcommand is a temporary measure to port
shell function in C so as to use the existing test
Hey Martin,
On Sat, Oct 28, 2017 at 1:34 AM, Martin Ågren wrote:
> On 27 October 2017 at 17:06, Pranit Bauva wrote:
>> + for (i = 0; i < argc; i++) {
>> + if (!strcmp(argv[i], "--term-good"))
>> +
Hey Martin,
On Fri, Oct 27, 2017 at 11:05 PM, Martin Ågren wrote:
> On 27 October 2017 at 17:06, Pranit Bauva wrote:
>> + /*
>> +* have bad (or new) but not good (or old). We could bisect
>> +* although
Hey Junio,
On Fri, Oct 27, 2017 at 11:49 PM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> - bisect_write "$state" "$rev"
>> + git bisect--helper --bisect-write "$state" "$rev" "$TERM_GOOD"
>&g
Hey Martin,
On Fri, Oct 27, 2017 at 10:58 PM, Martin Ågren wrote:
> On 27 October 2017 at 17:06, Pranit Bauva wrote:
>> +static void free_terms(struct bisect_terms *terms)
>> +{
>> + if (!terms->term_good)
>> + free((void *) terms->term_good)
Hey Stephan,
On Mon, Oct 30, 2017 at 10:04 PM, Stephan Beyer wrote:
> On 10/27/2017 05:06 PM, Pranit Bauva wrote:
>> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
>> index 0f9c3e63821b8..ab0580ce0089a 100644
>> --- a/builtin/bisect--helper.c
>> +++
nged from
> "unrecognised option: '$arg'"
> to
> "unrecognised option: '%s'"
> anyway, it does not result in further work for the translators to
> correct it to
> "unrecognized option: '%s'"
Yeah Sure!
Regards,
Pranit Bauva
t for
>
> printf(_("We are not bisecting.\n"));
> return 0;
>
> but please also express it with these two lines. (Or what is the point
> of returning a non-zero value only in the case when nothing could be
> printed?)
I was just being a little lazy I suppose. I will stick to doing it in
two lines and avoiding fancy things.
Regards,
Pranit Bauva
Hey Junio,
On Fri, Oct 27, 2017 at 11:10 PM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> +static int bisect_reset(const char *commit)
>> +{
>> + struct strbuf branch = STRBUF_INIT;
>> +
>> + if (!commit) {
>> + if (strbuf_rea
Hey,
I forgot to mention. One can find the travis build here[1] which is passing.
[1]: https://travis-ci.org/git/git/builds/293725346
Regards,
Pranit Bauva
Signed-off-by: Pranit Bauva
---
Hey,
This is the part 2 of the initial series[1] on bisect re-write. When I
submitted my patches of the part 1 of the bisect series, Ramsay informed
that he has been working on my previous patches and pointed me to his
patches. I have incorporated his changes into
`bisect_append_log_quoted` to keep things short
and crisp.
Helped-by: Ramsay Jones
Helped-by: Stephan Beyer
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 228 ++-
git-bisect.sh| 132
are ported, this subcommand will be retired but its implementation will
be called by some other methods.
Also use error() to report "no terms defined" and accordingly change the
test in t6030.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
--
by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 91 +++-
git-bisect.sh| 60 +++
2 files changed, 94 insertions(+), 57 deletions(-)
diff --git a/builtin/bisect--helper.c b/buil
-by: Pranit Bauva
---
builtin/bisect--helper.c | 41 -
git-bisect.sh| 36
2 files changed, 44 insertions(+), 33 deletions(-)
diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
index 6295f53c850a8
is_empty_file() can help to refactor a lot of code. This will be very
helpful in porting "git bisect" to C.
Suggested-by: Torsten Bögershausen
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/am.c | 20 ++--
cache.h
() to set the values of members in `struct
bisect_terms`.
Helped-by: Ramsay Jones
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 107 +--
git-bisect.sh| 25 ++-
2
Signed-off-by: Pranit Bauva
---
t/t6030-bisect-porcelain.sh | 120 ++--
1 file changed, 60 insertions(+), 60 deletions(-)
diff --git a/t/t6030-bisect-porcelain.sh b/t/t6030-bisect-porcelain.sh
index 55835ee4a4715..f9e61c6540e57 100755
--- a/t/t6030-bisect
Hey Junio,
On Tue, Oct 3, 2017 at 9:21 AM, Junio C Hamano wrote:
> Ramsay Jones writes:
>
>> On 02/10/17 14:44, Pranit Bauva wrote:
>> [snip]
>>>...
>> Yes, I also meant to tidy that up by removing some, now
>> redundant, initialisation later in that fun
N_("update BISECT_HEAD instead of checking out the
> current commit")),
> OPT_END()
> @@ -140,17 +111,14 @@ int cmd_bisect__helper(int argc, const char **argv,
> const char *prefix)
> return bisect_next_all(prefix, no_checkout);
> case WRITE_TERMS:
> if (argc != 2)
> - return error(_("--write-terms requires two
> arguments"));
> + die(_("--write-terms requires two arguments"));
> return write_terms(argv[0], argv[1]);
> case BISECT_CLEAN_STATE:
> if (argc != 0)
> - return error(_("--bisect-clean-state requires no
> arguments"));
> + die(_("--bisect-clean-state requires no arguments"));
> return bisect_clean_state();
> - case CHECK_EXPECTED_REVS:
> - check_expected_revs(argv, argc);
> - return 0;
> default:
> - return error("BUG: unknown subcommand '%d'", cmdmode);
> + die("BUG: unknown subcommand '%d'", cmdmode);
I will keep the return rather than die since Christian and I had a few
conversations long back.
Regards,
Pranit Bauva
www.bauva.com
Hey Stephan,
On Sat, Sep 30, 2017 at 12:24 AM, Stephan Beyer wrote:
>
> Hi Pranit,
>
> On 09/29/2017 08:49 AM, Pranit Bauva wrote:
> > It has been a long time since this series appeared on the mailing list.
> > The previous version v15[1] is now split into many parts
Add test to explicitly check that 'git bisect reset' is working as
expected. This is already covered implicitly by the test suite.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
I faced this problem while converting `bisect_clean_state` and
implementation will
be called by some other method.
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 36 +---
git-bisect.sh| 22 +++---
2 files changed, 36 insertions(+), 22
Signed-off-by: Pranit Bauva
---
bisect.c | 42 ++
bisect.h | 2 ++
builtin/bisect--helper.c | 10 +-
git-bisect.sh| 26 +++---
4 files changed, 56 insertions(+), 24 deletions(-)
diff --git
ting test suite. As more
functions are ported, this subcommand would be retired but its
implementation will be called by some other method.
Helped-by: Eric Sunshine
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c
d-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
Hey,
It has been a long time since this series appeared on the mailing list.
The previous version v15[1] is now split into many parts and I am
sending the first part right now, will focus on getting this merged and
will be introduced for write_terms().
Helped-by: Johannes Schindelein
Mentored-by: Lars Schneider
Mentored-by: Christian Couder
Signed-off-by: Pranit Bauva
---
builtin/bisect--helper.c | 60 +++-
git-bisect.sh| 31
d its way into "next". (There were also recent discussions
> on other bisect strategies [3] and it's probably only a matter of time
> until a new big patchset on bisect--helper comes up...)
I am sorry I haven't found much time on it. I actually came across a
bug and haven't been able to fix that so I had just not worked on it
then. I almost forgot that you too had a patch series and this series
is important for you. I will start working on this and send a re-roll
soon.
Regards,
Pranit Bauva
inside
the repo will get the first preference and then the global
~/.gitconfig.
This will work for you assuming that you have different repos for your
company and for your open source work. Will this solve your problem?
Regards,
Pranit Bauva
> }
> }
>
Did you purposely miss the one in line number 278 of
builtin/show-branch.c because I think you only touched up the parts
which were related to "refs/" but didn't explicitly mention it in the
commit message?
if (starts_with(pretty_str, "[PATC
ob)
> - free(good_glob);
> - if (!bad_syn)
> - free(bad_syn);
> - if (!good_syn)
> - free(good_syn);
> + free(bad_ref);
> + free(good_glob);
> + free(bad_syn);
> + free(good_syn);
> return retval;
> }
This helps a lot ;) Thanks!
Regards,
Pranit Bauva
f you send another iteration of the patch series), please squash
> this fix in.
>
> Signed-off-by: Johannes Schindelin
Thanks for making this fix! :) I will squash it in.
Regards,
Pranit Bauva
be able to help with actual project ideas
but I will try. I will do it within a week or so.
Regards,
Pranit Bauva
hink it would be more appropriate to use
git-scm.org domain. We can forward all .com requests to .org and try
to move all reference we know about, to .org. What do you all think?
Regards,
Pranit Bauva
re not recognized */
> --
It is highly recommended to follow the pre existing style of code and
commits. In the micro project list, I think it is mentioned that this
similar thing is implemented in git-merge so you should try and dig
the commit history of that file to find the similar change.
If you do this, then you will find out that there is a very short and
sweet way to do it. I won't directly point out the commit.
strbuf API should be used when you need to modify the contents of the
string. I think you have a little confusion.
If you declare the string as,
const char *str = "foo";
then, you can also do,
str = "bar";
But you can't do,
str[1] = 'z';
I hope you get what I am saying, if not, search for it.
Regards,
Pranit Bauva
Hey Kevin,
Sorry for the previous message.
On Sun, Feb 5, 2017 at 2:47 AM, Pranit Bauva wrote:
> Hey Kevin,
>
> On Fri, Feb 3, 2017 at 11:59 PM, Kevin Layer wrote:
>> It should be possible to quietly create a branch.
I think `git branch` is already quiet. Are you seeing
Hey Kevin,
On Fri, Feb 3, 2017 at 11:59 PM, Kevin Layer wrote:
> It should be possible to quietly create a branch.
>
> Thanks.
>
> Kevin
t;i18n: git-parse-remote.sh: mark strings for translation",
> 2016-04-19), the argument is no longer used. Remove it.
>
> Signed-off-by: Siddharth Kannan
This looks good to me! Thanks :)
Regards,
Pranit Bauva
Hey SIddharth,
> Subject: parse-remote: Remove reference to unused op_prep
^
Minor nit: after the colon, we generally don't use the word starting
with an uppercase letter which I think can be figured out when you run
`git log -p git-parse-remote.sh`
On Sa
Hey Siddharth,
On Fri, Feb 3, 2017 at 11:58 PM, Siddharth Kannan
wrote:
> - Remove the third argument of error_on_missing_default_upstream that is no
> longer required
> - FIXME to remove this argument was added in commit 045fac5845
This is not exactly correct. Well, this is the commit you get
(SMTP blocked by institute
proxy) but I have included it as a link[1]. And here is the PR[2].
[1]:
https://patch-diff.githubusercontent.com/raw/git/git.github.io/pull/219.patch
[2]: https://github.com/git/git.github.io/pull/219
Regards,
Pranit Bauva
Hey Cornelius,
On Wed, Jan 25, 2017 at 5:49 AM, wrote:
> From: Cornelius Weig
>
> Git does not create a history for tags, in contrast to common
> expectation to simply version everything. This can be changed by using
> the `--create-reflog` flag when creating the tag. However, a config
> option
Hey Junio,
On Tue, Jan 24, 2017 at 12:06 AM, Junio C Hamano wrote:
> Pranit Bauva writes:
>
>> We can probably make it useful with some extended efforts. I use
>> git-blame and I sometimes find that I don't need things like the name
>> of the author, time, timezo
the effort. I personally find this `format`
feature useful.
Regards,
Pranit Bauva
test_must_fail should only be used for testing git commands. To test the
failure of other commands use `!`.
Reported-by: Stefan Beller
Signed-off-by: Pranit Bauva
---
t/t3510-cherry-pick-sequence.sh | 6 +++---
t/t5504-fetch-receive-strict.sh | 2 +-
t/t5516-fetch-push.sh| 2
The exit code of the upstream in a pipe is ignored thus we should avoid
using it. By writing out the output of the git command to a file, we can
test the exit codes of both the commands.
Signed-off-by: Pranit Bauva
---
t/t9813-git-p4-preserve-users.sh | 8
1 file changed, 4 insertions
v3 while
> queuing, or I may forget about it after looking at other topics ;-)
> in which case you may want to send v4 with the fix?
Yeah sure! No problem! :)
Regards,
Pranit Bauva
Hey Luke,
On Wed, Jan 4, 2017 at 2:41 PM, Luke Diamand wrote:
> On 3 January 2017 at 19:57, Pranit Bauva wrote:
>> The exit code of the upstream in a pipe is ignored thus we should avoid
>> using it. By writing out the output of the git command to a file, we can
>> test t
test_must_fail should only be used for testing git commands. To test the
failure of other commands use `!`.
Reported-by: Stefan Beller
Signed-off-by: Pranit Bauva
---
t/t3510-cherry-pick-sequence.sh | 6 +++---
t/t5504-fetch-receive-strict.sh | 2 +-
t/t5516-fetch-push.sh| 2
The exit code of the upstream in a pipe is ignored thus we should avoid
using it. By writing out the output of the git command to a file, we can
test the exit codes of both the commands.
Signed-off-by: Pranit Bauva
---
t/t9813-git-p4-preserve-users.sh | 8
1 file changed, 4 insertions
Hey Stefan,
On Tue, Jan 3, 2017 at 11:28 PM, Stefan Beller wrote:
> On Mon, Jan 2, 2017 at 10:45 AM, Pranit Bauva wrote:
>> The exit code of the upstream in a pipe is ignored thus we should avoid
>> using it.
>
> for commands under test, i.e. git things. Other parts
context = diff_interhunk_context_default;
> options->ws_error_highlight = ws_error_highlight_default;
> DIFF_OPT_SET(options, RENAME_EMPTY);
On a first look, it seems that we can overwrite the default config
values by using a different command line argument which is good.
Also, tests are missing. It seems that t/t4032 might be a good place
to add those tests.
Rest all is quite good! :)
Regards,
Pranit Bauva
The exit code of the upstream in a pipe is ignored thus we should avoid
using it. By writing out the output of the git command to a file, we can
test the exit codes of both the commands.
Signed-off-by: Pranit Bauva
---
t/t9813-git-p4-preserve-users.sh | 8
1 file changed, 4 insertions
test_must_fail should only be used for testing git commands. To test the
failure of other commands use `!`.
Reported-by: Stefan Beller
Signed-off-by: Pranit Bauva
---
t/t3510-cherry-pick-sequence.sh | 6 +++---
t/t5504-fetch-receive-strict.sh | 2 +-
t/t5516-fetch-push.sh| 2
> git p4 commit >actual 2>&1 &&
> ! grep "git author.*does not match" actual &&
>
> -- Hannes
This seems better! Since I am at it, I can remove the traces of pipes
in an another patch.
Regards,
Pranit Bauva
erify the next bisection state then find the
>>>> next bisection state"), BISECT_AUTO_NEXT),
>>>
>>> The next bisection *state* is found?
>>
>> checkout is more appropriate. I don't remember why I used "find".
>
> "checkout the next bisection commit" maybe?
Seems better. Thanks!
Regards,
Pranit Bauva
test_must_fail should only be used for testing git commands. To test the
failure of other commands use `!`.
Reported-by: Stefan Beller
Signed-off-by: Pranit Bauva
---
t/t3510-cherry-pick-sequence.sh | 6 +++---
t/t5504-fetch-receive-strict.sh | 2 +-
t/t5516-fetch-push.sh| 2
Hey Stephan,
On Tue, Nov 22, 2016 at 3:05 AM, Stephan Beyer wrote:
> Hi Pranit,
>
> in this mail I review the "second part" of your patch: the transition of
> bisect_next and bisect_auto_next to C.
>
> On 10/14/2016 04:14 PM, Pranit Bauva wrote:
>> diff --git a/
d confusion about how to split the commits, but then I then
decided to dump it all together so that it compiles (I was finding it
difficult to split into meaningful parts which also compiled).
> However, I was reviewing this superficially, to be honest. This mail
> skips the next and autonext
e idiomatic way?
>
> I just found out that "test_must_fail grep ..." is a common
> idiom, so what about:
Is there any particular reason to use "grep" instead of "test_cmp"? To
check for non-zero error code, you can always use "! test_cmp".
Regards,
Pranit Bauva
Hey Stephan,
On Thu, Nov 17, 2016 at 5:17 AM, Stephan Beyer wrote:
> Hi,
>
> On 10/14/2016 04:14 PM, Pranit Bauva wrote:
>> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
>> index d84ba86..c542e8b 100644
>> --- a/builtin/bisect--helper.c
>&g
Hey Stephan,
On Wed, Dec 7, 2016 at 1:03 AM, Pranit Bauva wrote:
>> I don't understand why the return value is int and not void. To avoid a
>> "return 0;" line when calling this function?
>
> Initially I thought I would be using the return value but now I
>
Hey Stephan,
On Wed, Dec 7, 2016 at 5:24 AM, Stephan Beyer wrote:
> Hi Pranit,
>
> On 12/06/2016 11:40 PM, Pranit Bauva wrote:
>> On Tue, Nov 22, 2016 at 5:42 AM, Stephan Beyer wrote:
>>> On 10/14/2016 04:14 PM, Pranit Bauva wrote:
>>>> +static int bisect_sta
Hey Stephan,
On Wed, Dec 7, 2016 at 4:35 AM, Stephan Beyer wrote:
> Hey Pranit,
>
> On 12/06/2016 10:14 PM, Pranit Bauva wrote:
>>>> +
>>>> + if (argc == 0) {
>>>> + printf(_("Your current terms are %s for the old state\nand &q
e to leak memory... but Git is rather written
> as a scripting tool than a genuine library, so perhaps many people here
> do not care about it as long as it works...
Thanks for taking out your time to review my series extremely
carefully. I will try to post a v16 next week probably.
> On 10/
Hey Stephan,
On Fri, Nov 18, 2016 at 1:55 AM, Stephan Beyer wrote:
> Hi Pranit,
>
> On 10/14/2016 04:14 PM, Pranit Bauva wrote:
>> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
>> index 3f19b68..c6c11e3 100644
>> --- a/builtin/bisect--helper.c
>&g
Hey Stephan,
On Fri, Nov 18, 2016 at 3:17 AM, Stephan Beyer wrote:
> Hi,
>
> On 10/14/2016 04:14 PM, Pranit Bauva wrote:
>> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
>> index 493034c..c18ca07 100644
>> --- a/builtin/bisect--helper.c
>&g
Hey Stephan,
On Tue, Nov 22, 2016 at 5:42 AM, Stephan Beyer wrote:
> Hi,
>
> On 10/14/2016 04:14 PM, Pranit Bauva wrote:
>> Reimplement the `bisect_state` shell function in C and also add a
>> subcommand `--bisect-state` to `git-bisect--helper` to call it from
>>
Hey Stephan,
On Thu, Nov 17, 2016 at 3:10 PM, Stephan Beyer wrote:
> Hi,
>
> I've only got some minors to mention here ;)
>
> On 10/14/2016 04:14 PM, Pranit Bauva wrote:
>> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
>> index c542e8b..3f19b6
Hey Stephan,
On Fri, Nov 18, 2016 at 3:02 AM, Stephan Beyer wrote:
> Hi,
>
> On 10/14/2016 04:14 PM, Pranit Bauva wrote:
>> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
>> index 317d671..6a5878c 100644
>> --- a/builtin/bisect--helper.c
>&g
Hey Stephan,
On Mon, Nov 21, 2016 at 1:45 AM, Stephan Beyer wrote:
> Hi,
>
> On 10/14/2016 04:14 PM, Pranit Bauva wrote:
>> diff --git a/builtin/bisect--helper.c b/builtin/bisect--helper.c
>> index 502bf18..1767916 100644
>> --- a/builtin/bisect--helper.c
>&g
1 - 100 of 603 matches
Mail list logo