Re: Re: [PATCH] userdiff: add build-in pattern for shell

2017-03-29 Thread Pickfire
Junio C Hamano wrote: > Ivan Tham writes: > > > Shell are widely used but comes with lots of different patterns. The > > build-in pattern aim for POSIX-compatible shells with some additions: > > > > - Notably ${g//re/s} and ${g#cut} > > - "function" from bash > > > > Signed-off-by: Ivan Tham >

Re: Re: Re: Microproject | Add more builtin patterns for userdiff

2017-03-28 Thread Pickfire
Jacob Keller wrote: > On Tue, Mar 28, 2017 at 10:53 AM, Pickfire wrote: > > > > Yes, I can't reproduce it outside the test suite. I have added the builtin > > and yet the test fails. test_decode_color gets same output as expect but > > still it fails, should I

Re: Re: Microproject | Add more builtin patterns for userdiff

2017-03-28 Thread Pickfire
Stefan Beller wrote: > On Tue, Mar 28, 2017 at 3:46 AM, Pickfire wrote: > > > EOF > > > > echo '* diff="cpp"' > .gitmodules > > Did you mean .gitattributes? Yeah, that's a spelling error.

Re: Re: Microproject | Add more builtin patterns for userdiff

2017-03-28 Thread Pickfire
Jacob Keller wrote: > On Tue, Mar 28, 2017 at 3:46 AM, Pickfire wrote: > > While I was working buildins shell patterns for user diffs. I noticed that > > the tests t4034 passes but I can reproduce it manually with: > > > > mkdir cpp/ && cd cpp/ &&

Microproject | Add more builtin patterns for userdiff

2017-03-28 Thread Pickfire
While I was working buildins shell patterns for user diffs. I noticed that the tests t4034 passes but I can reproduce it manually with: mkdir cpp/ && cd cpp/ && git init cat > pre b ab a>=b a==b a!=b a&b a

Re: Re: Re: Re: GSoC Project | Convert interactive rebase to C

Johannes Schindelin wrote: > On Sat, 25 Mar 2017, Ivan Tham wrote: > > > Johannes Schindelin wrote: > > > On Tue, 21 Mar 2017, Ivan Tham wrote: > > > > Stefan Beller wrote: > > > > > On Mon, Mar 20, 2017 at 9:41 AM, Ivan Tham > > > > > wrote: > > > > > > > > > > > I am interested to work on "