Re: [git-for-windows] Git for Windows v2.24.0-rc0, was Re: [ANNOUNCE] Git v2.24.0-rc0

2019-10-22 Thread Philip Oakley
it/mingw64/../etc/gitconfig`  --system, while the release notes simplify the path to C:/Program Files/Git/etc/gitconfig Dunno if that's worth a minor fix to the release notes to clarify for the broader Windows community. Maybe others can comment if they think it's even worth it. Phil

Re: [PATCH v2 9/9] pack-objects: improve partial packfile reuse

2019-10-20 Thread Philip Oakley
es (esp when int (32) is extended to 64 bit size_t, rather than being 64 bit in the first place) Philip

[PATCH v5] Doc: Bundle file usage

2019-10-20 Thread Philip Oakley
Improve the command description, including paragraph spacing. Git URLs can accept bundle files for fetch, pull and clone, include in that section. Include git clone in the bundle usage description. Correct the quoting of . Detail the options for cloning a complete repo. Signed-off-by: Philip

Re: [PATCH v4] Doc: Bundle file usage

2019-10-20 Thread Philip Oakley
On 20/10/2019 02:10, Jeff King wrote: On Fri, Oct 18, 2019 at 09:30:52PM +0100, Philip Oakley wrote: +`git clone` can use any bundle created without negative refspecs +(e.g., `new`, but not `old..new`). +If you want to match `git clone --mirror`, which would clone other +refs such as `refs

Re: [PATCH v2 5/9] pack-bitmap: introduce bitmap_walk_contains()

2019-10-19 Thread Philip Oakley
Hi Christian, On 19/10/2019 19:55, Christian Couder wrote: Hi Philip, On Sat, Oct 19, 2019 at 5:25 PM Philip Oakley wrote: Hi Christian, can I check one thing? Yeah, sure! Thanks for taking a look at my patches! On 19/10/2019 11:35, Christian Couder wrote: +int bitmap_walk_contains

Re: [PATCH v2 9/9] pack-objects: improve partial packfile reuse

2019-10-19 Thread Philip Oakley
.h index 6ab6033dbe..bcd03b8993 100644 --- a/pack-bitmap.h +++ b/pack-bitmap.h @@ -50,7 +50,8 @@ void test_bitmap_walk(struct rev_info *revs); struct bitmap_index *prepare_bitmap_walk(struct rev_info *revs); int reuse_partial_packfile_from_bitmap(struct bitmap_index *, struct packed_git **packfile, - uint32_t *entries, off_t *up_to); + uint32_t *entries, + struct bitmap **reuse_out); int rebuild_existing_bitmaps(struct bitmap_index *, struct packing_data *mapping, kh_oid_map_t *reused_bitmaps, int show_progress); void free_bitmap_index(struct bitmap_index *); Apologies if these are dumb queries.. Philip

Re: [PATCH v2 5/9] pack-bitmap: introduce bitmap_walk_contains()

2019-10-19 Thread Philip Oakley
versal has been performed by prepare_bitmap_walk(), this can be -- Philip

Re: [PATCH v1] config/branch: state that .merge is the remote ref

2019-10-19 Thread Philip Oakley
Hi Junio, On 19/10/2019 00:11, Junio C Hamano wrote: Philip Oakley writes: branch..merge::     Defines, for the local branch , the upstream branch ref     _on the remote_ (as given by branch..remote).     The upstream ref may be different from the local branch ref. optionally s/different

Re: Git Gui: Branch->create currently fails...

2019-10-18 Thread Philip Oakley
Hi Pratyush On 16/10/2019 19:52, Pratyush Yadav wrote: On 14/10/19 11:11PM, Philip Oakley wrote: On 14/10/2019 18:57, Pratyush Yadav wrote: list "refs/heads/MSVC-README" [list "commit" "056fb95c8e983ec07e9f5f8baa0b119bf3d13fed" [concat "" "Philip O

[PATCH v2] config/branch: state that .merge is the remote ref

2019-10-18 Thread Philip Oakley
The branch..merge value typically looks just like a local ref. Tell the reader it is the ref name at the remote, which may be different. Signed-off-by: Philip Oakley --- Documentation/config/branch.txt | 6 -- 1 file changed, 4 insertions(+), 2 deletions(-) diff --git a/Documentation

Re: [PATCH v1] config/branch: state that .merge is the remote ref

2019-10-18 Thread Philip Oakley
Hi Junio, On 18/10/2019 02:32, Junio C Hamano wrote: Philip Oakley writes: branch..merge:: Defines, together with branch..remote, the upstream branch - for the given branch. It tells 'git fetch'/'git pull'/'git rebase' which + for the given

[PATCH v4] Doc: Bundle file usage

2019-10-18 Thread Philip Oakley
Improve the command description, including paragraph spacing. Git URLs can accept bundle files for fetch, pull and clone, include in that section. Include git clone in the bundle usage description. Correct the quoting of . Detail the options for cloning a complete repo. Signed-off-by: Philip

Re: [PATCH v3] Doc: Bundle file usage

2019-10-18 Thread Philip Oakley
On 18/10/2019 19:15, Pratyush Yadav wrote: On 18/10/19 04:15PM, Philip Oakley wrote: From: Philip Oakley Improve the command description, including paragraph spacing. Git URLs can accept bundle files for fetch, pull and clone, include in that section. Include git clone in the bundle usage

[PATCH v3] Doc: Bundle file usage

2019-10-18 Thread Philip Oakley
From: Philip Oakley Improve the command description, including paragraph spacing. Git URLs can accept bundle files for fetch, pull and clone, include in that section. Include git clone in the bundle usage description. Correct the quoting of . Detail the options for cloning a complete repo

[PATCH v2] t/README: the test repo does not have global or system configs

2019-10-18 Thread Philip Oakley
Also, fix minor wording mistake in referenced config section. Signed-off-by: Philip Oakley --- The basic --local config also doesn't appear to be well defined here. test-lib.sh sets GIT_TEMPLATE_DIR="$GIT_BUILD_DIR"/templates/blt If no config template then..? e

Re: Raise your hand to Ack jk/code-of-conduct if your Ack fell thru cracks

2019-10-17 Thread Philip Oakley
equired. Thus, while the CoC is good, for clarifying the egregious behaviour issues, it doesn't really address the wider 'Diversity and Equality' *expectations* within the community. Philip [1] https://github.com/git-for-windows/git/pull/661#issuecomment-186846113 [2] &quo

Re: [RFC PATCH v1] t/README: the test repo does not have global or system configs

2019-10-16 Thread Philip Oakley
On 16/10/2019 17:47, SZEDER Gábor wrote: On Wed, Oct 16, 2019 at 01:45:15PM +0100, Philip Oakley wrote: Signed-off-by: Philip Oakley --- While tring to get to grips with some Git-for-Windows config settings for testing >4GiB files, I couldn't find any note in the readme about the tes

[RFC PATCH v1] t/README: the test repo does not have global or system configs

2019-10-16 Thread Philip Oakley
Signed-off-by: Philip Oakley --- While tring to get to grips with some Git-for-Windows config settings for testing >4GiB files, I couldn't find any note in the readme about the test system config file sources. Is this the right place for the information, is it complete enough, an

[PATCH v1] config/branch: state that .merge is the remote ref

2019-10-16 Thread Philip Oakley
The branch..merge value typically looks just like a local ref. Tell the reader it is the ref name at the remote, which may be different. Signed-off-by: Philip Oakley --- This confusion had me scratching my head for many minutes recently. A simple clarification would avoid such mental model

Re: [PATCH v2] Doc: Bundle file usage

2019-10-16 Thread Philip Oakley
On 16/10/2019 10:57, Philip Oakley wrote: From: Philip Oakley Oops - the From: line still has my old email address. Is a resend preferred, or can it be fixed locally? P. Git URLs can accept bundle files for fetch, pull and clone, include in that section. Include git clone in the bundle

[PATCH v2] Doc: Bundle file usage

2019-10-16 Thread Philip Oakley
From: Philip Oakley Git URLs can accept bundle files for fetch, pull and clone, include in that section. Include git clone in the bundle usage description. Correct the quoting of . Detail the options for cloning a complete repo. Signed-off-by: Philip Oakley --- This takes up the advice from

Re: Git Gui: Branch->create currently fails...

2019-10-14 Thread Philip Oakley
On 14/10/2019 18:57, Pratyush Yadav wrote: list "refs/heads/MSVC-README" [list "commit" "056fb95c8e983ec07e9f5f8baa0b119bf3d13fed" [concat "" "Philip Oakley"] [reformat_date [concat "" "Sun May 19 22:33:37 2019 +0100"]] &qu

Re: Git Gui: Branch->create currently fails...

2019-10-14 Thread Philip Oakley
er lines). There is an empty line 4901 (CRLF) Yeah, that's a lot of refs! On my git.git clone, I get 1299 lines, and I have git.git, my fork of git.git, and gitster in my remotes. the last two lines are: list "refs/heads/branch-patterns" [list "commit" "b245

Re: Git Gui: Branch->create currently fails...

2019-10-12 Thread Philip Oakley
Hi Pratyus, On 08/10/2019 01:00, Pratyush Yadav wrote: On 07/10/19 11:02PM, Philip Oakley wrote: I'd never used the Branch:Create before (this is via mouse) and it threw an error, which appears to be repeatable, so I'm reporting it at the moment so I'm afraid I can't repro

Re: [PATCH] git-rev-list.txt: prune options in synopsis

2019-10-11 Thread Philip Oakley
ge to understand the three layers of man page that needed reading). I had proposed a patch many years ago [1] but the feedback wasn't positive, though my SO question continues [2] to get votes. Philip [1] https://public-inbox.org/git/1348010734-664-2-git-send-email-philipo

Re: [PATCH v3 00/13] ci: include a Visual Studio build & test in our Azure Pipeline

2019-10-10 Thread Philip Oakley
could be copied into the man/guide pages, especially for the project pages. At the moment I'm trying to get the >4Gb on Window' series sorted, which though working has been a load of bear traps for testing and configs and VS compiling, etc. But yes, it is on the back-list. -- Philip

Re: [PATCH v3 00/13] ci: include a Visual Studio build & test in our Azure Pipeline

2019-10-09 Thread Philip Oakley
section of the range-diff man page, especially if the upstream commit message is already in place. #leftoverdocs ? Philip

Re: Git Gui: Branch->create currently fails...

2019-10-07 Thread Philip Oakley
On 07/10/2019 23:02, Philip Oakley wrote: I'd never used the Branch:Create before (this is via mouse) and it threw an error, which appears to be repeatable, so I'm reporting it at the moment so I don't forget ... (I'm chasing down other issue at the moment ;-) Forgot to

Git Gui: Branch->create currently fails...

2019-10-07 Thread Philip Oakley
0 $title"     (procedure "::choose_rev::new" line 2)     invoked from within "::choose_rev::new $w.rev [mc "Starting Revision"]"     (procedure "branch_create::dialog" line 35)     invoked from within "branch_create::dialog"     (menu invoke) -- Philip

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-06 Thread Philip Oakley
s input is probably the most important aspect, no matter the particular route used for the input. So thanks to both of you (Dscho, Pratyush) for *facilitating* the contribution flow. -- Philip

Re: [PATCH] Feature: custom guitool commands can now have custom keyboard shortcuts

2019-10-06 Thread Philip Oakley
uts" list, and "GUI-local" list (and hence, elsewhere, a "Cola-local" list) I don't use Cola at all, so this is just a bikeshed comment... -- Philip

Re: unsibscribe git

2019-10-05 Thread Philip Oakley
On 05/10/2019 17:14, Alexander Litvinov wrote: unsibscribe git try sending to majordomo, see http://vger.kernel.org/vger-lists.html#git

Re: [PATCH 2/2] git-gui: support for diff3 conflict style

2019-10-04 Thread Philip Oakley
On 04/10/2019 16:22, Bert Wesarg wrote: On Thu, Oct 3, 2019 at 11:40 PM Philip Oakley wrote: On 03/10/2019 21:54, Pratyush Yadav wrote: My only remaining bikeshed question it prompted was to check which parts would be committed as part of committing the whole "hunk". But haven

Re: Git Basics Episode 1 GUI

2019-10-04 Thread Philip Oakley
uot;GitHub for Mac graphical client". Philip Best regards On 4 Oct 2019, at 11:14, Philip Oakley <mailto:philipoakley@iee.email>> wrote: On 04/10/2019 08:19, Colin Agnew wrote: Could you confirm which GUI is featured in the first video? Please advise - thanks Dunno, Do you

Re: Git Basics Episode 1 GUI

2019-10-04 Thread Philip Oakley
it will be `git gui` which is a Tcl/Tk script and included as part of the Git repo. Philip

Re: [Outreachy] Outreachy internship program

2019-10-03 Thread Philip Oakley
used. I tend to develop on to of the patched Windows version of git, and usually there is enough separation that the patches transfer direct to the Linux upstream. HTHs Philip - Emily On Thu, Oct 3, 2019 at 12:40 PM gespinoz gespinoz wrote: Hello, Great! Thanks for the tips Emily! T

Re: [PATCH 2/2] git-gui: support for diff3 conflict style

2019-10-03 Thread Philip Oakley
to work fine on my quick testing. That looks like just the answer I was hoping for! Thanks. -- Philip

Re: subscribing to list.

2019-10-03 Thread Philip Oakley
On 03/10/2019 19:02, Rohit Sanjay wrote: subscribe me try http://vger.kernel.org/vger-lists.html#git for more info... (email to majord...@vger.kernel.org  body = `subscribe git`) -- Philip PS. the list uses bottom posting https://en.wikipedia.org/wiki/Posting_style

Re: [PATCH 2/2] git-gui: support for diff3 conflict style

2019-10-03 Thread Philip Oakley
On 30/09/2019 13:17, Bert Wesarg wrote: Pratyush, On Sun, Sep 29, 2019 at 5:04 PM Pratyush Yadav wrote: Hi Philip, Bert, Is there any way I can test this change? Philip, I ran the rebase you mention in the GitHub issue [0], and I get that '9c8cba6862abe5ac821' is an unknown rev

Re: [PATCH v2] doc: MyFirstContribution: fix cmd placement instructions

2019-09-26 Thread Philip Oakley
more explicit LGTM. Thanks. Philip Documentation/MyFirstContribution.txt | 10 +- 1 file changed, 5 insertions(+), 5 deletions(-) diff --git a/Documentation/MyFirstContribution.txt b/Documentation/MyFirstContribution.txt index f867037..5e9b808 100644 --- a/Document

Re: sizeof(var) vs sizeof(type), was Re: [PATCH] git: use COPY_ARRAY and MOVE_ARRAY in handle_alias()

2019-09-26 Thread Philip Oakley
uideline in our documentation? Better yet: can we create a Coccinelle script to fix it automatically? -Stolee How about 'Both'. We can't assume all contributors have Coccinelle on their OS/system. Philip

Re: Bi-Weekly Standup - Time/timezone in calendar?

2019-09-25 Thread Philip Oakley
On 25/09/2019 15:32, Thomas Gummerer wrote: On 09/25, Philip Oakley wrote: Hi, At the Virtual Git Contributors Summit we discussed (#13) the bi-weekly standup meetings (mentioned in the Git Rev News edition 55 under 'News/Various'). The Git Events calendar [1] that's linked fr

Re: [DISCUSSION] Growing the Git community

2019-09-25 Thread Philip Oakley
Hi Pierre, On 25/09/2019 14:36, Pierre Tardy wrote: As a community, our number one goal is for Git to continue to be the best distributed version control system. At minimum, it should continue to be the most widely-used DVCS. I'd rather we stated our goal in terms of what problems we are trying

Bi-Weekly Standup - Time/timezone in calendar?

2019-09-25 Thread Philip Oakley
endar sheet. Is this google calendar trying to be too clever, or should "1700 UTC" be included in the event details? I don't use Google calendar except for occasional reference. Philip [1] https://calendar.google.com/calendar/embed?src=nk8ph2kh4p5tgfcctb8i7dm6d4%40group.calendar.google.com

Re: git-gui: failure to distinguish 3-way common ancestors in hunk markers (#2340)

2019-09-25 Thread Philip Oakley
prepare my rerere cache [how to do /that/ ?] and the rebase) On Wed, Sep 25, 2019 at 12:05 AM Philip Oakley wrote: Hi list, cc Pratyush, [resend without attached png file] While rebasing an old series, I had a 3-way merge fall back that didn't show the `||| merged common ancestor

Fwd: git-gui: failure to distinguish 3-way common ancestors in hunk markers (#2340)

2019-09-24 Thread Philip Oakley
e has been there a while. Philip

git-gui: failure to distinguish 3-way common ancestors in hunk markers (#2340)

2019-09-24 Thread Philip Oakley
being separated. I opened a Git for Windows issue https://github.com/git-for-windows/git/issues/2340 and attach the screenshot of the git-gui markers. I've not had any chance to look at the underlying code, but thought it worth reporting. I guess the issue has been there a while. Philip

Re: Git in Outreachy December 2019?

2019-09-23 Thread Philip Oakley
But it looks like those don't get printed for git-commit? -Peff Also there is a lot of common problems and issues that can be mined from StackOverflow for similar "Did You Mean..?"user problems. Philip

Re: [PATCH v2 0/6] multi-pack-index: add --no-progress

2019-09-20 Thread Philip Oakley
promised? Normally the 'git log --oneline' should fit within the line, so ~50 chars. Philip Documentation/git-multi-pack-index.txt | 6 ++- builtin/multi-pack-index.c | 18 +-- builtin/repack.c | 2 +- midx.c

Re: [DISCUSSION] Growing the Git community

2019-09-20 Thread Philip Oakley
e systemy comments are about ensuring we are solving the right problems and ensuring we don't miss some issue that will negate any good work here. -- Philip II. Approach The action items below match the problems listed above. 1. Improve the documentation for contributing to Git. In pre

Re: [PATCH] doc: MyFirstContribution: fix cmd placement instructions

2019-09-20 Thread Philip Oakley
r `psuh` immediately before it, Maybe feature the "alphabetical" sort order (i.e. include the word here), so that other see it (use of alphabetical sorting) that little more obviously in the tutorial material. Philip in order to keep the declarations sorted: @@ -123,7 +

Re: Git versioning policy - PatchMyPC compatibility on Windows

2019-09-14 Thread Philip Oakley
re is some discussion about the semver approach on https://github.com/git-for-windows/git/issues/2223 and how the .windows. indicates patches beyond the upstream releases. Semver isn't sufficient in these cases. Philip

Re: [PATCH 2/2] git-gui: add hotkey to toggle "Amend Last Commit" check button/menu

2019-09-12 Thread Philip Oakley
he shift on, rather than being a special extra key. Philip

Re: [PATCH] git-gui: convert new/amend commit radiobutton to checketton

2019-09-12 Thread Philip Oakley
On 12/09/2019 20:44, Bert Wesarg wrote: Its a bi-state anyway and also safes one line in the menu. s/safes/saves/  ? Signed-off-by: Bert Wesarg --- Philip

Re: [PATCH 1/2] git-gui: warn if the commit message contains lines longer than the set limit

2019-09-06 Thread Philip Oakley
- Disable word wrapping (it should be configurable, like you said) Configurable wrapping point - yes, would be nice (a feeling of control, that I'd probably never change ;-). Thoughts? Birger Philip

Re: Git does not recognise directory named '${sys:DATA_ROOT_DIR}'

2019-09-03 Thread Philip Oakley
Thank you for reminding me of the empty-tree case :-) Makes me wonder if git status could maybe warn about empty trees as 'untracked'? Philip

Re: [PATCH 1/1] rebase -r: let `label` generate safer labels

2019-09-02 Thread Philip Oakley
mately the label could be tweaked to have say the 4char prefix to fool the Windows 'starts with' name detection - which assumes I understand how some of those bad filenames are detected... On Mon, Sep 2, 2019, 5:24 PM Philip Oakley wrote: On 02/09/2019 19:29, Junio C Hamano wrote:

Re: [PATCH 1/1] rebase -r: let `label` generate safer labels

2019-09-02 Thread Philip Oakley
Oh, just seen dscho's "we make sure that the labels are unique, via the `label_oid()` function!", maybe needs mentioning in the commit message if re-rolled. Philip

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-02 Thread Philip Oakley
On 02/09/2019 13:25, Pratyush Yadav wrote: On 01/09/19 11:27PM, Philip Oakley wrote: Hi Pratyus, On 01/09/2019 12:32, Pratyush Yadav wrote: Hi Birger, In case you haven't been following the list, Pat has been inactive recently, so I am acting as the interim maintainer of git-gui fo

Re: [BUG} stash show does not show untracked files stashed (reposted)

2019-09-02 Thread Philip Oakley
I'd guess 1 file changed, 0 insertions(+), 0 deletions(-), *3 files untracked* as they are what's meant to be in the stash... (obviously format to taste) Philip

Re: Retrieve version-string on shallow clone

2019-09-02 Thread Philip Oakley
y tagged) you still don't have that history upon which to describe them. Start by getting a bit more history depth, then see if you need to fetch some of the tags (or at least any specific tags of interest). Philip

Re: [PATCH] git-gui: Add hotkeys to set widget focus

2019-09-01 Thread Philip Oakley
that these hotkey nicely have numbers so can easily be used for reference.. Philip [1] https://stackoverflow.com/questions/6007823/is-there-a-help-page-for-the-git-gui-options-dialog

Re: How to track history of personal changes in a repository?

2019-08-31 Thread Philip Oakley
or updates sometimes, leading to unexpected effects if the user has the wrong mental model, thinking that Git would ignore their changes... Philip

Re: [PATCH v9 9/9] rebase: teach rebase --keep-base

2019-08-25 Thread Philip Oakley
common case, introduce the --keep-base option as a shortcut. This allows us to rewrite the above as git rebase -i --keep-base master and git rebase -x ./test.sh --keep-base master respectively. [remainder snipped] [also Eric Sunshine dropped due to temporary sending difficulties] Philip

Re: [Feature Request] Option to make .git not read-only in cloned repos

2019-08-25 Thread Philip Oakley
s, so the consequence will be that such files are read-only. Philip (*) I'm primarily a Windows user, so certain Linux nuances pass me by ;-). I simply delete the repo folder then click the gui dialog to agree to delete the r/o files. Simples.

Re: [PATCH] t7300-clean: demonstrate deleting nested repo with an ignored file breakage

2019-08-25 Thread Philip Oakley
Hi Szeder, On 25/08/2019 19:59, SZEDER Gábor wrote: 'git clean -fd' must not delete an untracked directory if it belongs s/untracked// I don't believe it should matter either way for a sub-module (sub-directory). to a different Git repository or worktree. msybr split the assertion from the f

Re: [PATCH v2 20/23] .gitignore: touch up the entries regarding Visual Studio

2019-08-25 Thread Philip Oakley
Hi Szeder, On 25/08/2019 20:09, SZEDER Gábor wrote: On Sun, Aug 25, 2019 at 02:20:32PM +0100, Philip Oakley wrote: Hi Szeder, On 25/08/2019 13:07, SZEDER Gábor wrote: On Mon, Jul 29, 2019 at 01:08:14PM -0700, Philip Oakley via GitGitGadget wrote: Add the Microsoft .manifest pattern, and do

Re: [PATCH v2 20/23] .gitignore: touch up the entries regarding Visual Studio

2019-08-25 Thread Philip Oakley
Hi Szeder, On 25/08/2019 13:07, SZEDER Gábor wrote: On Mon, Jul 29, 2019 at 01:08:14PM -0700, Philip Oakley via GitGitGadget wrote: Add the Microsoft .manifest pattern, and do not anchor the 'Debug' and 'Release' entries at the top-level directory, to allow for multip

Re: [PATCH v3 13/13] format-patch: learn --infer-cover-subject option

2019-08-24 Thread Philip Oakley
On 24/08/2019 09:03, Denton Liu wrote: On Fri, Aug 23, 2019 at 01:18:44PM -0700, Junio C Hamano wrote: Philip Oakley writes: Perhaps the `--infer-cover-subject` the config option needs to be multi-valued to include: "subject" (always expect short first lines) or "m

Re: [PATCH v3 13/13] format-patch: learn --infer-cover-subject option

2019-08-23 Thread Philip Oakley
ject Here***),      with the "true" being used when expecting both as previously described. -- Philip As an aside, for format-patch to learn a --branch-version option that creates a branch with the '-vN' suffix to the current branch when the -vN option is used would be a

Re: [ANNOUNCE] Git Rev News edition 54

2019-08-21 Thread Philip Oakley
ossible project idea for capturing usage counts by instrumenting the _() function to count how often those 4674 po strings are used over some duration, especially in larger establishments with a range of users.. Maybe something for the project ideas files. Philip

[PATCH] .mailmap: update email address of Philip Oakley

2019-08-11 Thread Philip Oakley
My IEE 'home for life' email service is being withdrawn on 30 Sept 2019. Replace with my new email domain. I also have a secondary (backup) 'home for life' through . Signed-off-by: Philip Oakley Signed-off-by: Philip Oakley --- .mailmap | 1 + 1 file changed, 1 insert

Re: $> git branch splat response considered harmful

2019-08-09 Thread Philip Oakley
nd documentation could be more helpful for pointing to the appropriate plumbing commands for these scripting issues (and it could reduce list noise..). -- Philip

[PATCH v2 0/1] git-p4: auto-delete named temporary file

2019-08-02 Thread Philip McGraw via GitGitGadget
gadget/git/releases/tag/pr-303%2Fphilip-mcgraw%2Fgit-p4-auto-delete-named-temporary-file-v3-v2 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-303/philip-mcgraw/git-p4-auto-delete-named-temporary-file-v3-v2 Pull-Request: https://github.com/gitgitgadget/git/pull/303 Range-diff

[PATCH 0/1] git-p4: auto-delete named temporary file

2019-08-01 Thread Philip McGraw via GitGitGadget
gadget/git/releases/tag/pr-303%2Fphilip-mcgraw%2Fgit-p4-auto-delete-named-temporary-file-v3-v1 Fetch-It-Via: git fetch https://github.com/gitgitgadget/git pr-303/philip-mcgraw/git-p4-auto-delete-named-temporary-file-v3-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/303 -- gitgitgadget

RE: [PATCH] git-p4: close temporary file before removing

2019-08-01 Thread Philip McGraw
> From: Andrey > Sent: Wednesday, 31 July, 2019 21:35 > To: Philip McGraw > Cc: git@vger.kernel.org; l...@diamand.org > Subject: Re: [PATCH] git-p4: close temporary file before removing > > 31.07.2019, 17:52, "Philip McGraw" : > > 2019.07.31 10:09 Andrey &

[PATCH 0/1] git-p4: close temporary file before removing

2019-07-31 Thread Philip McGraw via GitGitGadget
github.com/gitgitgadget/git pr-301/philip-mcgraw/git-p4-close-temporary-file-before-remove-v2-v1 Pull-Request: https://github.com/gitgitgadget/git/pull/301 -- gitgitgadget

RE: [PATCH] git-p4: close temporary file before removing

2019-07-31 Thread Philip McGraw
2019.07.31 10:09 Andrey >31.07.2019, 09:53, "Philip McGraw" : >>>  30.07.2019, 13:37, "Philip McGraw" : >>>  > python os.remove() throws exceptions on Windows platform when attempting >>>  > to remove file while it is still open. Need

RE: [PATCH] git-p4: close temporary file before removing

2019-07-31 Thread Philip McGraw
> 30.07.2019, 13:37, "Philip McGraw" : > > python os.remove() throws exceptions on Windows platform when attempting > > to remove file while it is still open. Need to grab filename while file > > open, > > close file handle, then remove by name. Apparently ot

[PATCH] git-p4: close temporary file before removing

2019-07-30 Thread Philip McGraw
python os.remove() throws exceptions on Windows platform when attempting to remove file while it is still open. Need to grab filename while file open, close file handle, then remove by name. Apparently other platforms are more permissive of removing files while busy. reference: https://docs.pytho

[PATCH v2 09/23] contrib/buildsystems: ignore gettext stuff

2019-07-29 Thread Philip Oakley via GitGitGadget
From: Philip Oakley Git's build contains steps to handle internationalization. This caused hiccups in the parser used to generate QMake/Visual Studio project files. As those steps are irrelevant in this context, let's just ignore them. Signed-off-by: Philip Oakley Signed-off-by

[PATCH v2 05/23] contrib/buildsystems: ignore invalidcontinue.obj

2019-07-29 Thread Philip Oakley via GitGitGadget
From: Philip Oakley Since 4b623d8 (MSVC: link in invalidcontinue.obj for better POSIX compatibility, 2014-03-29), invalidcontinue.obj is linked in the MSVC build, but it was not parsed correctly by the buildsystem. Ignore it, as it is known to Visual Studio and will be handled elsewhere. Also

[PATCH v2 10/23] contrib/buildsystems: redirect errors of the dry run into a log file

2019-07-29 Thread Philip Oakley via GitGitGadget
From: Philip Oakley Rather than swallowing the errors, it is better to have them in a file. To make it obvious what this is about, use the file name 'msvc-build-makedryerrors.txt'. Further, if the output is empty, simply delete that file. As we target Git for Windows' SDK (wh

[PATCH v2 08/23] contrib/buildsystems: handle quoted spaces in filenames

2019-07-29 Thread Philip Oakley via GitGitGadget
From: Philip Oakley The engine.pl script expects file names not to contain spaces. However, paths with spaces are quite prevalent on Windows. Use shellwords() rather than split() to parse them correctly. Helped-by: Junio C Hamano Signed-off-by: Philip Oakley Signed-off-by: Johannes Schindelin

[PATCH v2 20/23] .gitignore: touch up the entries regarding Visual Studio

2019-07-29 Thread Philip Oakley via GitGitGadget
From: Philip Oakley Add the Microsoft .manifest pattern, and do not anchor the 'Debug' and 'Release' entries at the top-level directory, to allow for multiple projects (one per target). Signed-off-by: Philip Oakley Signed-off-by: Johannes Schindelin --- .gitignore | 5 +

[PATCH v2 07/23] contrib/buildsystems: fix misleading error message

2019-07-29 Thread Philip Oakley via GitGitGadget
From: Philip Oakley The error message talked about a "lib option", but it clearly referred to a link option. Signed-off-by: Philip Oakley Signed-off-by: Johannes Schindelin --- contrib/buildsystems/engine.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH v2 02/23] Vcproj.pm: list git.exe first to be startup project

2019-07-29 Thread Philip Oakley via GitGitGadget
From: Philip Oakley Visual Studio takes the first listed application/library as the default startup project [1]. Detect the 'git' project and place it at the head of the project list, rather than at the tail. Export the apps list before libs list for both the projects and global str

[PATCH v2 13/23] contrib/buildsystems: handle the curl library option

2019-07-29 Thread Philip Oakley via GitGitGadget
From: Philip Oakley Upon seeing the '-lcurl' option, point to the libcurl.lib. While there, fix the elsif indentation. Signed-off-by: Philip Oakley Signed-off-by: Johannes Schindelin --- contrib/buildsystems/engine.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) di

[PATCH v2 11/23] contrib/buildsystems: optionally capture the dry-run in a file

2019-07-29 Thread Philip Oakley via GitGitGadget
From: Philip Oakley Add an option for capturing the output of the make dry-run used in determining the msvc-build structure for easy debugging. You can use the output of `--make-out ` in subsequent runs via the `--in ` option. Signed-off-by: Philip Oakley Signed-off-by: Johannes Schindelin

From Philip Twite

2019-07-26 Thread Philip
-- Thanks for your last email response to me. The information required should include the following-: Your full names Your address Telephone number Your private email Occupation AgeThis is to enable my further discussion with you in confidence. Best regards and wishes to you. Philip Twite

[PATCH 07/24] contrib/buildsystems: fix misleading error message

2019-07-18 Thread Philip Oakley via GitGitGadget
From: Philip Oakley The error message talked about a "lib option", but it clearly referred to a link option. Signed-off-by: Philip Oakley Signed-off-by: Johannes Schindelin --- contrib/buildsystems/engine.pl | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git

[PATCH 09/24] contrib/buildsystems: ignore gettext stuff

2019-07-18 Thread Philip Oakley via GitGitGadget
From: Philip Oakley Git's build contains steps to handle internationalization. This caused hiccups in the parser used to generate QMake/Visual Studio project files. As those steps are irrelevant in this context, let's just ignore them. Signed-off-by: Philip Oakley Signed-off-by

[PATCH 08/24] contrib/buildsystems: handle quoted spaces in filenames

2019-07-18 Thread Philip Oakley via GitGitGadget
From: Philip Oakley The engine.pl script expects file names not to contain spaces. However, paths with spaces are quite prevalent on Windows. Use shellwords() rather than split() to parse them correctly. Helped-by: Junio C Hamano Signed-off-by: Philip Oakley Signed-off-by: Johannes Schindelin

[PATCH 13/24] contrib/buildsystems: handle the curl library option

2019-07-18 Thread Philip Oakley via GitGitGadget
From: Philip Oakley Upon seeing the '-lcurl' option, point to the libcurl.lib. While there, fix the elsif indentation. Signed-off-by: Philip Oakley Signed-off-by: Johannes Schindelin --- contrib/buildsystems/engine.pl | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) di

[PATCH 05/24] contrib/buildsystems: ignore invalidcontinue.obj

2019-07-18 Thread Philip Oakley via GitGitGadget
From: Philip Oakley Since 4b623d8 (MSVC: link in invalidcontinue.obj for better POSIX compatibility, 2014-03-29), invalidcontinue.obj is linked in the MSVC build, but it was not parsed correctly by the buildsystem. Ignore it, as it is known to Visual Studio and will be handled elsewhere. Also

[PATCH 10/24] contrib/buildsystems: redirect errors of the dry run into a log file

2019-07-18 Thread Philip Oakley via GitGitGadget
From: Philip Oakley Rather than swallowing the errors, it is better to have them in a file. To make it obvious what this is about, use the file name 'msvc-build-makedryerrors.txt'. Further, if the output is empty, simply delete that file. As we target Git for Windows' SDK (wh

[PATCH 11/24] contrib/buildsystems: optionally capture the dry-run in a file

2019-07-18 Thread Philip Oakley via GitGitGadget
From: Philip Oakley Add an option for capturing the output of the make dry-run used in determining the msvc-build structure for easy debugging. You can use the output of `--make-out ` in subsequent runs via the `--in ` option. Signed-off-by: Philip Oakley Signed-off-by: Johannes Schindelin

[PATCH 20/24] .gitignore: touch up the entries regarding Visual Studio

2019-07-18 Thread Philip Oakley via GitGitGadget
From: Philip Oakley Add the Microsoft .manifest pattern, and do not anchor the 'Debug' and 'Release' entries at the top-level directory, to allow for multiple projects (one per target). Signed-off-by: Philip Oakley Signed-off-by: Johannes Schindelin --- .gitignore | 5 +

[PATCH 02/24] Vcproj.pm: list git.exe first to be startup project

2019-07-18 Thread Philip Oakley via GitGitGadget
From: Philip Oakley Visual Studio takes the first listed application/library as the default startup project [1]. Detect the 'git' project and place it at the head of the project list, rather than at the tail. Export the apps list before libs list for both the projects and global str

Re: Git Test Coverage Report (Wed. July 10)

2019-07-11 Thread Philip Oakley
'master@{1}' builtin/branch.c 1fde99cf 841) die(_("The -a, and -r, options to 'git branch' do not take a branch name.\n" [snip] Commits introducting uncovered code: ... Philip Oakley 1fde99cf doc branch: provide examples for listing remote tracking branches

  1   2   3   4   5   6   7   8   9   10   >