Re: [PATCH] pretty format string support for reflog times

2016-07-27 Thread Phil Pennock
On 2016-07-27 at 14:32 -0400, Jeff King wrote: > Yeah, I agree the "!" test for "did it work" is counter-intuitive if you're > coming from other languages, but it's pretty normal for C code bases > (especially ours). For stuff returning pointers, sure. > Ah. Yeah, those are wrong and bad. We shou

Re: [PATCH] pretty format string support for reflog times

2016-07-27 Thread Phil Pennock
On 2016-07-27 at 13:56 -0400, Jeff King wrote: > On Wed, Jul 27, 2016 at 04:14:14AM -0400, Phil Pennock wrote: > > +*/ > > + case 'T': > > + if (get_reflog_timeinfo(×tamp, &tz, > > c->pretty_ctx->reflog_info))

Re: [PATCH] pretty format string support for reflog times

2016-07-27 Thread Phil Pennock
On Wed, Jul 27, 2016, at 09:58, Jeff King wrote: > On Wed, Jul 27, 2016 at 04:14:14AM -0400, Phil Pennock wrote: > > The reflog contains timestamp information, but these were not exposed to > > `--pretty`. Four of the six author/committer format string > > second-letters wer

Re: [PATCH] pretty format string support for reflog times

2016-07-27 Thread Phil Pennock
On 2016-07-27 at 04:14 -0400, Phil Pennock wrote: > pretty.c | 36 > reflog-walk.c | 16 > reflog-walk.h | 3 +++ > t/t4205-log-pretty-formats.sh | 26 +

[PATCH] pretty format string support for reflog times

2016-07-27 Thread Phil Pennock
reimplementing the specification of the five added timestamp rendering cases. Instead, we allow exporting the timestamp information from the reflog, and if we get it, we add the same data. No memory alloc and string construction/parsing, a small amount of duplication of meaning. Si

Re: .gitignore sub-dir exclusions not overriding '*'

2014-11-19 Thread Phil Pennock
On 2014-11-19 at 16:48 +0700, Duy Nguyen wrote: > On Wed, Nov 19, 2014 at 10:40 AM, Phil Pennock > wrote: > > Expected to work as .gitignore in top-level of repo: > > > > * > > !**/*.asc > > !.gitignore > > > > gitignore man page has th

.gitignore sub-dir exclusions not overriding '*'

2014-11-18 Thread Phil Pennock
The behaviour below is seen with both git 1.8.3.2 and git 2.1.3; I am not subscribed to the vger list, please keep me in the CC list. Use-case: git repo which only holds PGP-encrypted files with a .asc extension, no matter which sub-directory they're in, or if in the top directory. Simple layout;

Re: [PATCH] zsh completion: 5.0.3 compat, use emulate

2014-04-30 Thread Phil Pennock
On 2014-04-30 at 05:00 -0500, Felipe Contreras wrote: > Felipe Contreras wrote: > > Phil Pennock wrote: > > > The bash completion pulled into zsh was being pulled in _as_ zsh, but > > > used patterns which relied on falling through as unhandled. In zsh > > > 5

[PATCH] zsh completion: 5.0.3 compat, use emulate

2013-12-16 Thread Phil Pennock
config file, which stickily preserves compatibility options in the function context. This usage of "emulate" came in with zsh 4.3.10, released 2009-06-01. Signed-off-by: Phil Pennock --- nb: I am not on the git mailing-list, please keep me CC'd. I have read SubmittingPatches but

[PATCH] gitweb: make remote_heads config setting work.

2012-11-05 Thread Phil Pennock
patibility issues. We strip underscores from keys before looking through git-config output for them. Signed-off-by: Phil Pennock " --- gitweb/gitweb.perl |3 ++- 1 file changed, 2 insertions(+), 1 deletion(-) diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl index 10ed9e5..f2144c8 1007