Re: git submodule deinit resulting in BUG: builtin/submodule--helper.c:1045: module_list_compute should not choke on empty pathspec

2018-03-28 Thread Peter Oberndorfer
On 2018-03-28 00:56, Stefan Beller wrote: > On Tue, Mar 27, 2018 at 12:55 PM Peter Oberndorfer > wrote: Hi, as expected your patch fixed the BUG output. Thanks! >> 2) Should "git submodule deinit" work on submodules that were removed by > upstream already? > >

git submodule deinit resulting in BUG: builtin/submodule--helper.c:1045: module_list_compute should not choke on empty pathspec

2018-03-27 Thread Peter Oberndorfer
Hi, i tried to run "git submodule deinit xxx" on a submodule that was recently removed from the Rust project. But git responded with a BUG/Core dump (and also did not remove the submodule directory from the checkout). ~/src/rust/rust$ git submodule deinit src/rt/hoedown/ error: pathspec 'src/rt/

Re: Searching explanation of different diff algorithms

2013-09-25 Thread Peter Oberndorfer
On 2013-09-25 10:55, Ondřej Bílka wrote: > On Wed, Sep 25, 2013 at 09:24:15AM +0200, Thomas Koch wrote: >> Is there any explanation available of the different merrits and drawbacks of >> the diff algorithms that Git supports? >> >> I'm not satisfied with the default diff but have enough processing

Re: crash on git diff-tree -Ganything for new files with textconv filter

2013-06-03 Thread Peter Oberndorfer
On 2012-11-07 22:13, Jeff King wrote: > On Wed, Nov 07, 2012 at 10:10:59PM +0100, Peter Oberndorfer wrote: > >>>> For me the key to reproduce the problem was to have 2 commits. >>>> Adding the file in the root commit it did not work. [1] >>> You probably w

Re: git-gui: textconv not used on unstaged files

2012-11-27 Thread Peter Oberndorfer
On 2012-11-26 21:54, Junio C Hamano wrote: > Peter Oberndorfer writes: > >> Does anybody have a idea which git command would output the diff >> of a untracked file against /dev/null? > The "--no-index" option is meant as a bolt-on to let you use various > feat

Re: Ignoring boring lines(that do not contain information) in git diff

2012-11-26 Thread Peter Oberndorfer
On 2012-10-08 18:44, Peter Oberndorfer wrote: > Hi, > > is there a way to tell git diff about lines that are uninteresting? > I mean lines which do not contain a lot of information and > appear several times in pre and post image. > > For example whitespace or language

Re: git-gui: textconv not used on unstaged files

2012-11-26 Thread Peter Oberndorfer
On 2012-10-24 20:33, Peter Oberndorfer wrote: > Hi, > > i am using a textconv filter to display .doc files as plain text. > It seems git gui does not use this textconv filter for displaying new > unstaged files > (other files? = _O) > It seems diff.tcl start_show_diff

Re: crash on git diff-tree -Ganything for new files with textconv filter

2012-11-07 Thread Peter Oberndorfer
On 2012-10-29 23:35, Jeff King wrote: > On Mon, Oct 29, 2012 at 09:19:48PM +0100, Peter Oberndorfer wrote: > >> I could reproduce with my 0x3000 bytes file on linux. The buffer is not >> read with a trailing null byte it is mapped by mmap in >> diff_populate_filespec... &

gitk: crash when pressing Shift-F5 while still loading a diff

2012-10-29 Thread Peter Oberndorfer
Hi, i recently tested gitk a bit more myself and on some people in the office. And i noticed when I repeatedly press Shift-F5 gitk crashes/displays a message box [1]. my current version: c83ae78864493a30ed5b544b4910a384371a5eaf This also happens a lot when gitk is still loading a big diff and usi

Re: crash on git diff-tree -Ganything for new files with textconv filter

2012-10-29 Thread Peter Oberndorfer
On 2012-10-29 07:05, Jeff King wrote: > On Sun, Oct 28, 2012 at 08:56:39PM +0100, Peter Oberndorfer wrote: > >>> The patch below should fix it. I added tests, but please try your >>> real-world test case on it to double-check. >> I tested your patch, but now

Re: crash on git diff-tree -Ganything for new files with textconv filter

2012-10-28 Thread Peter Oberndorfer
On 2012-10-28 13:01, Jeff King wrote: > On Sat, Oct 27, 2012 at 08:37:24PM +0200, Peter Oberndorfer wrote: > >> It seems "git diff-tree -Ganything " crashes[1] with a null >> pointer dereference >> when run on a commit that adds a file (pdf) with a textconv filte

crash on git diff-tree -Ganything for new files with textconv filter

2012-10-27 Thread Peter Oberndorfer
Hi, It seems "git diff-tree -Ganything " crashes[1] with a null pointer dereference when run on a commit that adds a file (pdf) with a textconv filter. It can be reproduced with vanilla git by having a commit on top that adds a file with a textconv filter and executing git diff-tree -Ganything HE

[PATCH] gitk: Do not select file list entries during diff loading

2012-10-26 Thread Peter Oberndorfer
when the current view never changed. Every time scrolltext{} is executed, a entry in the file list is selected and scrolled to. This makes it impossible for a user to scroll the file list while a long diff is still loading. Signed-off-by: Peter Oberndorfer --- Hi, i used v3 of the Synchronize

git-gui: textconv not used on unstaged files

2012-10-24 Thread Peter Oberndorfer
Hi, i am using a textconv filter to display .doc files as plain text. It seems git gui does not use this textconv filter for displaying new unstaged files (other files? = _O) It seems diff.tcl start_show_diff calls show_other_diff because of this. This manually loads the file and does not care

Ignoring boring lines(that do not contain information) in git diff

2012-10-08 Thread Peter Oberndorfer
Hi, is there a way to tell git diff about lines that are uninteresting? I mean lines which do not contain a lot of information and appear several times in pre and post image. For example whitespace or language dependent stuff like. { } END_IF; END_FOR; end sub I have seen diffs that containing

Re: [PATCH] gitk: Synchronize highlighting in file view when scrolling diff

2012-09-18 Thread Peter Oberndorfer
On 2012-09-18 07:57, Stefan Haller wrote: Whenever the diff pane scrolls, highlight the corresponding file in the file list on the right. For a large commit with many files and long per-file diffs, this makes it easier to keep track of what you're looking at. Hi, i like this function! I have of