Re: [PATCH 2/2] Use 'env' to find perl instead of fixed path

2017-01-12 Thread Pat Pannuto
I'm happy to let this drop. I've filed the missing perl library as a homebrew issue [1], so hopefully this won't be an issue for folks in the future. You may still want the 1/2 patch in this series, just to make things internally consistent with "-w" vs "use warnings;" inside git's perl scripts.

Re: [PATCH 2/2] Use 'env' to find perl instead of fixed path

2017-01-11 Thread Pat Pannuto
.perl | 2 +- be more acceptable? On Thu, Jan 12, 2017 at 1:27 AM, Johannes Sixt wrote: > Am 12.01.2017 um 06:51 schrieb Pat Pannuto: >> >> diff --git a/git-add--interactive.perl b/git-add--interactive.perl >> index cf6fc926a..6d7b6c35d 100755 >> --- a/git-ad

Re: [PATCH 0/2] Use env for all perl invocations

2017-01-11 Thread Pat Pannuto
me as opposed to run-time discovery -- this means users can't change their perl install without breaking git? On Thu, Jan 12, 2017 at 1:21 AM, Junio C Hamano wrote: > Pat Pannuto writes: > >> I spent a little while debugging why git-format-patch refused to believe >> th

[PATCH 2/2] Use 'env' to find perl instead of fixed path

2017-01-11 Thread Pat Pannuto
plugins such as Net/SMTP/SSL.pm to be installed, it is very confusing when git fails to work after installation because it chose the wrong perl installation. This patch converts all shebangs to use env for consistency across the project. Signed-off-by: Pat Pannuto --- Documentation/build

[PATCH 0/2] Use env for all perl invocations

2017-01-11 Thread Pat Pannuto
l; changing the shebang allowed git format-patch to work as expected. This patch set converts all perl invocations in git to use env so that the user-preferred perl interpreter is always used. Pat Pannuto (2): Convert all 'perl -w' to 'perl' + 'use warnings;'

[PATCH 1/2] Convert all 'perl -w' to 'perl' + 'use warnings;'

2017-01-11 Thread Pat Pannuto
This commit is in preparation for converting all shebangs to use 'env' instead of a fixed perl path, which will not allow for arguments to 'perl'. Signed-off-by: Pat Pannuto --- Documentation/cat-texi.perl | 4 +++- Documentation/cmd-list.perl | 4 +++- Documen