Re: [PATCH] simplifying branch.c:install_branch_config() if()

Is this safe? Today branch.c::create_branch checks that the argument > to e.g. --set-upstream-to is either in refs/heads/* or the image of > some remote, but what is making sure that remains true tomorrow? > > So if changing this, I would be happier if the "if" condition were > still (!remot

[PATCH] simplifying branch.c:install_branch_config() if()

Signed-off-by: Nemina Amarasinghe --- branch.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/branch.c b/branch.c index 723a36b..fd93603 100644 --- a/branch.c +++ b/branch.c @@ -87,16 +87,11 @@ void install_branch_config(int flag, const char *local, const char *origin

Re: [PATCH][GSoC]simplified branch.c:install_branch_config() if() statement

I hope this is the correct format for patch. Please comment on this if something is wrong. Signed-off-by:Nemina Amarasinghe --- branch.c | 7 +-- 1 file changed, 1 insertion(+), 6 deletions(-) diff --git a/branch.c b/branch.c index 0304a7a..fd93603 100644 --- a/branch.c +++ b/branch.c @@

Re: [PATCH] simplified the chain if() statements of install_branch_config() function in branch.c

Eric Sunshine sunshineco.com> writes: > > On Mon, Mar 10, 2014 at 3:58 AM, Nemina Amarasinghe gmail.com> wrote: > > Nemina Amarasinghe gmail.com> writes: > > > > Sorry for the first patch. Something went wrong. This is the correct one > > In addition t

Re: [PATCH] simplified the chain if() statements of install_branch_config() function in branch.c

> > ((!remote_is_branch && origin) || (!remote_is_branch || !origin)) > > Is it? > > The above is the same as (!remote_is_branch || !origin). What you wrote > before is the same as (!remote_is_branch). > > Maybe you should try copy&paste from the expressions you are trying to > combine to make

Re: [PATCH] simplified the chain if() statements of install_branch_config() function in branch.c

> > Nemina Amarasinghe gmail.com> writes: > > Is it me, or is (origin || !origin) a tautology? > Thanks for the advices Matthieu. I will go through the documentations again. Is there anything wrong with my logic? What I wanted to express is ((!remote_i

Re: [PATCH] simplified the chain if() statements of install_branch_config() function in branch.c

Nemina Amarasinghe gmail.com> writes: Sorry for the first patch. Something went wrong. This is the correct one >From aebfa60feb643280c89b54e5ab87f9d960cde452 Mon Sep 17 00:00:00 2001 From: Nemina Amarasinghe Date: Mon, 10 Mar 2014 13:02:55 +0530 Subject: [PATCH] simplified the ch

[PATCH] simplified the chain if() statements of install_branch_config() function in branch.c

Did some simple changing to the chain of if() statements in function install_branch_config() of branch.c This was a micro-project for GSOC 2014 >From aebfa60feb643280c89b54e5ab87f9d960cde452 Mon Sep 17 00:00:00 2001 From: Nemina Amarasinghe Date: Mon, 10 Mar 2014 13:02:55 +0530 Subject: [PA