Re: [PATCH 2/1] t6300: format missing tagger

2019-08-22 Thread Mischa POSLAWSKY
Junio wrote: > > Mischa POSLAWSKY writes: > > Strip an annotated tag of its tagger header and verify it's ignored > > correctly in all cases, as fixed in commit e2a81276e8 (ref-filter: > > initialize empty name or email fields, 2019-08-19). > > I am incli

[PATCH 2/1] t6300: format missing tagger

2019-08-22 Thread Mischa POSLAWSKY
Junio wrote: > Junio C Hamano writes: > > > Mischa POSLAWSKY writes: > > > >> If I understand correctly, such tags cannot be produced normally anymore. > >> Therefore I'm unsure how to make tests, and if that is even warranted. > > > > Than

Re: [PATCH] ref-filter: initialize empty name or email fields

2019-08-22 Thread Mischa POSLAWSKY
Junio wrote: > Junio C Hamano writes: > > > Mischa POSLAWSKY writes: > > > >> Formatting $(taggername) on headerless tags such as v0.99 in Git > >> causes a SIGABRT with error "munmap_chunk(): invalid pointer", > >> because of an oversight

[PATCH] ref-filter: initialize empty name or email fields

2019-08-17 Thread Mischa POSLAWSKY
Formatting $(taggername) on headerless tags such as v0.99 in Git causes a SIGABRT with error "munmap_chunk(): invalid pointer", because of an oversight in commit f0062d3b74 (ref-filter: free item->value and item->value->s, 2018-10-19). Signed-off-by: Mischa POSLAWSKY

Re: the opposite of .gitignore, whitelist

2018-10-26 Thread Mischa POSLAWSKY
Jeff King wrote 2018-10-26 5:36 (-0400): > I think what Junio meant is to ignore everything by default, like: > > echo '*' >.gitignore > > and then selectively use negative patterns (and being in .gitignore, > that makes them positive "yes, include this") to add things back: > > echo 'foo' >

Re: [PATCH] grep: provide a noop --recursive option

2018-10-05 Thread Mischa POSLAWSKY
Junio C Hamano wrote 2018-10-05 1:19 (-0700): > Stefan Beller writes: > > > git-grep is always file/tree recursive, but there is --recurse-submodules > > which is off by default. Instead of providing a short alias to a noop, > > we could use -r for submodules. (And if you happen to have no > > su

Re: [PATCH 3/4] http: drop support for curl < 7.19.4

2017-08-10 Thread Mischa POSLAWSKY
Jeff King wrote: > -#if LIBCURL_VERSION_NUM >= 0x071301 > curl_easy_setopt(result, CURLOPT_POSTREDIR, CURL_REDIR_POST_ALL); > -#elif LIBCURL_VERSION_NUM >= 0x071101 > curl_easy_setopt(result, CURLOPT_POST301, 1); > -#endif This seems to be an unintended behavioural change: the second c

Re: [PATCH] git-jump: ignore (custom) prefix in diff mode

2012-09-17 Thread Mischa POSLAWSKY
Junio C Hamano skribis 2012-9-16 22:22 (-0700): > Mischa POSLAWSKY writes: > > > Subject: [PATCH/RFC] format-patch: force default file prefixes in diff > > > > Override user configuration (eg. diff.noprefix) in patches intended for > > external consumption to match

Re: [PATCH] git-jump: ignore (custom) prefix in diff mode

2012-09-16 Thread Mischa POSLAWSKY
against diff options creating non-standard patches. -- >8 -- Subject: [PATCH/RFC] format-patch: force default file prefixes in diff Override user configuration (eg. diff.noprefix) in patches intended for external consumption to match the default prefixes expected by git-am. Signed-off-by: M

[PATCH] git-jump: ignore (custom) prefix in diff mode

2012-09-16 Thread Mischa POSLAWSKY
Matching the default file prefix b/ does not yield any results if config option diff.noprefix or diff.mnemonicprefix is enabled. Signed-off-by: Mischa POSLAWSKY --- Very useful script otherwise; thanks. contrib/git-jump/git-jump | 4 ++-- 1 file changed, 2 insertions(+), 2 deletions(-) diff