Re: [PATCH] clone: check if server supports shallow clones

2015-06-11 Thread Michael Edgar
it would be more dangerous for users to include a testing backdoor (eg a flag overriding the advertised capabilities). Is that an accurate assessment, or is there a safer way to test these sorts of interop cases? Cheers! -- Michael Edgar | Software Engineer | ad...@google.com -- To unsubscribe from this list: send the line "unsubscribe git" in the body of a message to majord...@vger.kernel.org More majordomo info at http://vger.kernel.org/majordomo-info.html

Re: [PATCH] clone: check if server supports shallow clones

2015-06-10 Thread Michael Edgar
> On Wed, Jun 10, 2015 at 3:05 PM, Jeff King wrote: > I see that do_fetch_pack checks server_supports("shallow"). Is that > enough to cover all fetch cases? And if it is, why does it not cover the > matching clone cases? > -Peff Great question. I determined that the do_fetch_pack logic doesn't wo