Re: [PATCH] completion: add missing completions for log, diff, show

2019-09-11 Thread Max Rothman
Just pinging again, I'd love to move this forward! On Thu, Aug 1, 2019 at 8:54 PM Max Rothman wrote: > > Ping :) > > > On Thu, Aug 1, 2019 at 8:50 PM Max Rothman wrote: > > > > The bash completion script knows some options to "git log" and >

Re: [PATCH] completion: add missing completions for log, diff, show

2019-08-01 Thread Max Rothman
Ping :) On Thu, Aug 1, 2019 at 8:50 PM Max Rothman wrote: > > The bash completion script knows some options to "git log" and > "git show" only in the positive form, (e.g. "--abbrev-commit"), but not > in their negative form (e.g. "--no-abbrev-co

[PATCH] completion: add missing completions for log, diff, show

2019-07-01 Thread Max Rothman
tions to "git diff", and "git show" (and thus, all other commands that take "git diff"'s options). Add them. Of note, since "--indent-heuristic" is no longer experimental, add that too. Signed-off-by: Max Rothman --- contrib/completion/git-completion

Re: [PATCH] completion: add missing completions for log, diff, show

2017-11-07 Thread Max Rothman
>> Teach git-log tab completion about the --no-* options for ease of use >> at the command line. >> >> Similarly, teach git-show tab completion about the --no-abbrev-commit, >> --expand-tabs, and --no-expand-tabs options. >> >> Also, teach git-diff (and all commands that use its options) tab >> com

[PATCH] completion: add missing completions for log, diff, show

2017-11-07 Thread Max Rothman
From: Max Rothman Teach git-log tab completion about the --no-* options for ease of use at the command line. Similarly, teach git-show tab completion about the --no-abbrev-commit, --expand-tabs, and --no-expand-tabs options. Also, teach git-diff (and all commands that use its options) tab

Re: No log --no-decorate completion?

2017-11-07 Thread Max Rothman
Thanks for the feedback! >> * Add bash completion for the missing --no-* options on git log >> * Add bash completion for --textconv and --indent-heuristic families to >> git diff and all commands that use diff's options >> * Add bash completion for --no-abbrev-commit, --expand-tabs, and >> --n

Re: No log --no-decorate completion?

2017-11-02 Thread Max Rothman
--oneline --show-signature --patch + --expand-tabs --expand-tabs= --no-expand-tabs $__git_diff_common_options " return On Tue, Oct 24, 2017 at 11:32 AM, Stefan Beller wrote: > On Tue, Oct

Re: No log --no-decorate completion?

2017-10-24 Thread Max Rothman
Just re-discovered this in my inbox. So is this worth fixing? I could (probably) figure out a patch. Thanks, Max On Thu, Oct 12, 2017 at 1:41 PM, Max Rothman wrote: > To be fair, other --no* options complete, it's just --no-decorate, > --no-walk, --no-abbrev-commit, --no-expand-tabs,

Re: No log --no-decorate completion?

2017-10-12 Thread Max Rothman
--not --no-ext-diff --no-merges--no-notes --no-renames --notes Thanks, Max On Wed, Oct 11, 2017 at 2:09 PM, Stefan Beller wrote: > On Wed, Oct 11, 2017 at 7:47 AM, Max Rothman wrote: >> I recently noticed that in the git-completion script, there's >

No log --no-decorate completion?

2017-10-11 Thread Max Rothman
I recently noticed that in the git-completion script, there's completion for --decorate={full,yes,no} for git log and family, but not for --no-decorate. Is that intentional? If not, I *think* I see how it could be added. Thanks, Max