Re: [PATCH] interpret-trailers: load default config

On Wed, Jun 19, 2019 at 12:37 PM Jeff King wrote: > > On Sat, Jun 15, 2019 at 10:41:44AM +0200, Christian Couder wrote: > > > On Fri, Jun 14, 2019 at 5:10 PM Jeff King wrote: > > > > > > On Fri, Jun 14, 2019 at 08:35:04PM +0900, Masahiro Yamada wrote: >

Re: 'git interpret-trailers' is tripped by comment characters other than '#'

On Tue, Jun 18, 2019 at 5:08 AM Christian Couder wrote: > > On Mon, Jun 17, 2019 at 7:31 PM Junio C Hamano wrote: > > > > Christian Couder writes: > > > > > On Mon, Jun 17, 2019 at 6:33 AM Masahiro Yamada > > > wrote: > > >> > > >&

Re: 'git interpret-trailers' is tripped by comment characters other than '#'

On Sat, Jun 15, 2019 at 12:08 AM Jeff King wrote: > > On Fri, Jun 14, 2019 at 08:35:04PM +0900, Masahiro Yamada wrote: > > > Perhaps, 'git interpret-trailers' should be changed > > to recognize core.commentChar ? > > It looks like the trailer code does res

Re: 'git interpret-trailers' is tripped by comment characters other than '#'

On Sat, Jun 15, 2019 at 5:41 PM Christian Couder wrote: > > On Fri, Jun 14, 2019 at 5:10 PM Jeff King wrote: > > > > On Fri, Jun 14, 2019 at 08:35:04PM +0900, Masahiro Yamada wrote: > > > > > Perhaps, 'git interpret-trailers' should be changed >

'git interpret-trailers' is tripped by comment characters other than '#'

is commit subject Blah Blah Change-Id: old tag Signed-off-by: Masahiro Yamada ; This is a comment line with non-default char Change-Id: new tag The same trailer 'Change-Id' was appended, ignoring trailer.ifexists=doNothing Details --- For Gerrit Code Review, we add "C