Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-04 Thread Marco Stornelli
2012/9/4 Junio C Hamano : > Marco Stornelli writes: > >> kernel, load the patch and send, really easy. So I don't think it's a >> regression, it's only a change in the work flow. > > Any change that forces the user to change an established work flow > su

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-04 Thread Marco Stornelli
Il 04/09/2012 17:49, Junio C Hamano ha scritto: Marco Stornelli writes: 2012/9/4 Junio C Hamano : I would expect, at least when you are responding to an existing message, some of them are filled already (and if so, I think appp.sh wants to know exactly how, for example, has RFC2047 quoting

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-04 Thread Marco Stornelli
2012/9/4 Junio C Hamano : > Marco Stornelli writes: > >> I don't have thunderbird now but actually it's really simple: >> >> Subject: >> To: >> Cc: >> $SEP > > The above is not a very useful "example" to advance this discussion,

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-03 Thread Marco Stornelli
2012/9/3 Junio C Hamano : > Marco Stornelli writes: > >> I tried the Johannes's script, but it seems it doesn't work well with >> the pattern of format-patch (To: ,\n ,\n >> ). The multilines are not well managed. > > I am guessing that the reason why

[PATCH v6] Thunderbird: fix appp.sh format problems

2012-09-03 Thread Marco Stornelli
ch in the email header. Added comments for point 1), added parsing of To: for point 2) and added parsing of Cc: in the email header for point 3), removing the Cc: parsing from commit message. Signed-off-by: Marco Stornelli --- v6: replaced single quotas with double quotas in perl embedded scri

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-03 Thread Marco Stornelli
Il 02/09/2012 22:42, Junio C Hamano ha scritto: Marco Stornelli writes: Il 01/09/2012 15:59, Johannes Sixt ha scritto: Look how you write: perl -e '... $ENV{'PATCHTMP'} ...' That is, perl actually sees this script: ... $ENV{PATCHTMP} ... (no quotes around P

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-03 Thread Marco Stornelli
2012/9/2 Junio C Hamano : > Marco Stornelli writes: > >> Il 01/09/2012 15:59, Johannes Sixt ha scritto: >> >>> Look how you write: >>> >>>perl -e '... $ENV{'PATCHTMP'} ...' >>> >>> That is, perl actually see

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-01 Thread Marco Stornelli
Il 01/09/2012 15:59, Johannes Sixt ha scritto: Am 01.09.2012 09:43, schrieb Marco Stornelli: Il 31/08/2012 23:35, Johannes Sixt ha scritto: Am 31.08.2012 16:09, schrieb Marco Stornelli: +CCS=`perl -e 'local $/=undef; open FILE, $ENV{'PATCHTMP'}; $text=; +close FILE; $addr = $1

[PATCH v5] Thunderbird: fix appp.sh format problems

2012-09-01 Thread Marco Stornelli
ch in the email header. Added comments for point 1), added parsing of To: for point 2) and added parsing of Cc: in the email header for point 3), removing the Cc: parsing from commit message. Signed-off-by: Marco Stornelli --- v5: fixed comments by Junio C Hamano v4: create a tmp file to

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-01 Thread Marco Stornelli
Il 31/08/2012 19:08, Junio C Hamano ha scritto: Marco Stornelli writes: The current script has got the following problems: 1) It doesn't work if the language used by Thunderbird is not english; 2) The field To: filled by format-patch is not evaluated; 3) The field Cc: is loaded from Cc

Re: [PATCH v4] Thunderbird: fix appp.sh format problems

2012-09-01 Thread Marco Stornelli
Il 31/08/2012 23:35, Johannes Sixt ha scritto: Am 31.08.2012 16:09, schrieb Marco Stornelli: +CCS=`perl -e 'local $/=undef; open FILE, $ENV{'PATCHTMP'}; $text=; +close FILE; $addr = $1 if $text =~ /Cc: (.*?(,\n .*?)*)\n/s; $addr =~ s/\n//g; +print $addr;'` The quoting is

[PATCH v4] Thunderbird: fix appp.sh format problems

2012-08-31 Thread Marco Stornelli
ch in the email header. Added comments for point 1), added parsing of To: for point 2) and added parsing of Cc: in the email header for point 3), removing the Cc: parsing from commit message. Signed-off-by: Marco Stornelli --- v4: create a tmp file to allow correct perl parsing v3: parse only To

[PATCH v3] Thunderbird: fix appp.sh format problems

2012-08-31 Thread Marco Stornelli
ch in the email header. Added comments for point 1), added parsing of To: for point 2) and added parsing of Cc: in the email header for point 3), removing the Cc: parsing from commit message. Signed-off-by: Marco Stornelli --- v3: parse only To: and Cc: in the email header, fix some commen

Re: [PATCH v2] Thunderbird: fix appp.sh format problems

2012-08-31 Thread Marco Stornelli
Il 30/08/2012 19:00, Junio C Hamano ha scritto: Marco Stornelli writes: The current script has got the following problems: 1) It doesn't work if the language used by Thunderbird is not English; 2) The field To: filled by format-patch is not evaluated; 3) The field Cc: is loaded only fr

[PATCH v2] Thunderbird: fix appp.sh format problems

2012-08-30 Thread Marco Stornelli
ed by format-patch in the email header. Added comments for point 1). Fixed point 2) and 3). Signed-off-by: Marco Stornelli --- v2: changed the commit message to reflect better the script implementation contrib/thunderbird-patch-inline/appp.sh | 18 ++ 1 files changed, 14 insertions(

[PATCH] Thunderbird: fix appp.sh format problems

2012-08-30 Thread Marco Stornelli
ch in the email header. In addition, in the commit message we can find several tags (acked-by, tested-by, reported-by...), so it'd better to use only the information provided by format-patch. Added comments for point 1). Fixed point 2) and 3). Signed-off-by: Marco Stornelli --- contrib/t