Re: [PATCH] fix global bash variable leak on __gitcompappend

2015-04-09 0:56 GMT-03:00 Junio C Hamano : > "Márcio Almada" writes: > >> --- >> contrib/completion/git-completion.bash | 2 +- >> 1 file changed, 1 insertion(+), 1 deletion(-) > > Nicely found and corrected. Please sign-off your patch and Cc area > experts if you can find them (I'll do that thi

Bug: global bash variable leak on __gitcompappend

Hi, This is how to reproduce the bug: ``` git checkout [tab-tab] echo $x # outputs the name of the last branch on completion list ``` Or more directly: ``` __gitcompappend "something" echo $x # outputs 'something' ``` No big deal, but it's annoying to know that `$x` is lurking. Cheers, Márcio