Re: GNU diff and git diff - difference on myers algorithm?

2015-07-16 Thread Luis R. Rodriguez
On Fri, Jun 12, 2015 at 11:52 AM, Luis R. Rodriguez wrote: > OK wells I'm curious about more research / effort when trying to > evaluate a diff with two seprate but adjoining preprocessor directives > and if anyone has implemented an optimizaiton option to let the diff > ge

Re: GNU diff and git diff - difference on myers algorithm?

2015-06-12 Thread Luis R. Rodriguez
On Tue, Jun 9, 2015 at 1:25 AM, Johannes Schindelin wrote: > Hi Luis, > > On 2015-06-08 20:34, Luis R. Rodriguez wrote: >> Based on a cursory review of the git code I get the impression that >> GNU diff and git 'diff' do not share any code for the possible diff &

GNU diff and git diff - difference on myers algorithm?

2015-06-08 Thread Luis R. Rodriguez
Based on a cursory review of the git code I get the impression that GNU diff and git 'diff' do not share any code for the possible diff algorithms. I'm in particularly curious more about the default "myers" algorithm. I can take time to do a precise code review of the algorithms used on both GNU di

[PATCH] git.c: treat RUN_SETUP_GENTLY and RUN_SETUP as mutually exclusive

2014-04-21 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" This saves us a few branches when RUN_SETUP is set up. Signed-off-by: Luis R. Rodriguez --- git.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/git.c b/git.c index 9efd1a3..7780572 100644 --- a/git.c +++ b/git.c @@ -290,7 +290,7 @@

Re: [PATCH] tag: add -i and --introduced modifier for --contains

2014-04-21 Thread Luis R. Rodriguez
On Fri, Apr 18, 2014 at 4:36 PM, Junio C Hamano wrote: > "Luis R. Rodriguez" writes: > >> I think ultimately this reveals that given that tags *can* be >> arbitrary and subjective,... > > Yes; see the part at the bottom. > >>> Commit A can be descr

Re: [PATCH] tag: add -i and --introduced modifier for --contains

2014-04-18 Thread Luis R. Rodriguez
On Thu, Apr 17, 2014 at 10:04 AM, Junio C Hamano wrote: > "Luis R. Rodriguez" writes: > >>> And between v3.4 and v3.5-rc1, the latter is a closer anchor point >>> for that commit (v3.5-rc1 only needs about 200 hops to reach the >>> commit, while

Re: [PATCH] tag: add -i and --introduced modifier for --contains

2014-04-16 Thread Luis R. Rodriguez
On Wed, Apr 16, 2014 at 3:02 PM, Junio C Hamano wrote: > "Luis R. Rodriguez" writes: > >> From: "Luis R. Rodriguez" >> >> Upstream Linux kernel commit c5905afb was introduced on v3.4 but >> git describe --contains yields v3.5 > > Actually

[PATCH] tag: add -i and --introduced modifier for --contains

2014-04-16 Thread Luis R. Rodriguez
From: "Luis R. Rodriguez" Upstream Linux kernel commit c5905afb was introduced on v3.4 but git describe --contains yields v3.5 while if we use git to look for the first parent with git describe --first-parent yields v3.3. The reason for this seems to be that the merge commit that