Re: [RFC PATCH v2 0/4] contrib/credential/netrc Makefile & test improvements

need the primary author (Ted) to acknowledge before the maintainer (Junio) can approve. > Luis Marsano (2): > git-credential-netrc: use in-tree Git.pm for tests > git-credential-netrc: fix exit status when tests fail > > Todd Zullinger (2): > git-credential-netrc:

Re: [RFC PATCH 0/2] contrib/credential/netrc Makefile & test improvements

On Tue, Jun 12, 2018 at 11:08 PM Todd Zullinger wrote: > As far as removing the autodie dep, is there anything more > to that than dropping the 'use autodie' line? It looks like > doing so leaves us no worse than we were before, but I > haven't written any perl in a long time. Erasing that line

Re: [RFC PATCH 0/2] contrib/credential/netrc Makefile & test improvements

Thanks for looking into this and addressing these issues. On Thu, Jun 7, 2018 at 1:20 AM Todd Zullinger wrote: > > Hi, > > I noticed failures from the contrib/credential/netrc tests > while building 2.18.0 release candidates. I was surprised > to see the tests being run when called with a simple

Re: [PATCH 2/2] git-credential-netrc: accept gpg option

Junio C Hamano wrote: > Luis Marsano writes: > > > git-credential-netrc was hardcoded to decrypt with 'gpg' regardless of the > > gpg.program option > > this now uses the gpg command option if set, else, the gpg.program option > > set in the git

Re: [PATCH 1/2] git-credential-netrc: adapt to test framework for git

Junio C Hamano wrote: > Luis Marsano writes: > > > until this change, git-credential-netrc did not test in a repository > > this change reuses the main test framework, which provides such tests > > specific changes > > Sorry, but I cannot quite parse w

[PATCH v2 2/2] git-credential-netrc: accept gpg option

mand options - write documentation placeholders according to main standards Signed-off-by: Luis Marsano Acked-by: Ted Zlatanov --- contrib/credential/netrc/git-credential-netrc | 58 --- .../netrc/t-git-credential-netrc.sh | 2 +- .../credential/netrc/test.command-opti

[PATCH v2 0/2] Configurable GnuPG command for git-credential-netrc

03:27:45 -0400) ---- Luis Marsano (2): git-credential-netrc: adapt to test framework for git git-credential-netrc: accept gpg option contrib/credential/netrc/Makefile | 4 +- contrib/credential/netrc/git-credential-n

[PATCH v2 1/2] git-credential-netrc: adapt to test framework for git

git-credential-netrc tests did not run in a test repository. Reuse the main test framework to stage a temporary repository. To imitate Perl tests under t/ - switch to Test::More module - use File::Basename & File::Spec::Functions Signed-off-by: Luis Marsano Acked-by: Ted Zlatanov --- con

[PATCH 1/2] git-credential-netrc: adapt to test framework for git

until this change, git-credential-netrc did not test in a repository this change reuses the main test framework, which provides such tests specific changes - switch to Test::More module - use File::Basename & File::Spec::Functions Signed-off-by: Luis Marsano Acked-by: Ted Zlatanov --- con

[PATCH 2/2] git-credential-netrc: accept gpg option

it.pm for repository and global option queries - add -g|--gpg command option & document it in command usage - test repository & command options - support unicode Signed-off-by: Luis Marsano Acked-by: Ted Zlatanov --- contrib/credential/netrc/git-credential-netrc | 69 +--

[PATCH 0/2] Configurable GnuPG command for git-credential-netrc

-0700 (PDT) Return-Path: In-Reply-To: <1524160133-8877-1-git-send-email-luis.mars...@gmail.com> References: <1524160133-8877-1-git-send-email-luis.mars...@gmail.com> From: Ted Zlatanov Date: Fri, 20 Apr 2018 19:18:32 -0400 Message-ID: Subject: Re: [RFC PATCH 0/2] Configurable GnuPG command f