Re: no-xmailer tests fail under Mac OS

2014-12-11 Thread Luis Henriques
Jeff King writes: > On Thu, Dec 11, 2014 at 02:11:04PM -0800, Junio C Hamano wrote: > >> Jeff King writes: >> >> > On Fri, Dec 05, 2014 at 11:07:37PM -0800, Michael Blume wrote: >> > >> >> > Ah, right, we might be looking for 0 sometimes. The right way to do it >> >> > without destroying the &&

Re: [RFC][PATCH] send-email: add --[no-]xmailer option

2014-12-04 Thread Luis Henriques
On Thu, Dec 04, 2014 at 11:33:24AM -0800, Junio C Hamano wrote: > Luis Henriques writes: > > > On Wed, Dec 03, 2014 at 08:56:45AM -0800, Junio C Hamano wrote: > > > >> I actually do not think this is a good idea from debuggability. > > > > Do you thin

[PATCH] test/send-email: --[no-]xmailer tests

2014-12-04 Thread Luis Henriques
Add tests for the --[no-]xmailer option. Signed-off-by: Luis Henriques --- t/t9001-send-email.sh | 32 1 file changed, 32 insertions(+) diff --git a/t/t9001-send-email.sh b/t/t9001-send-email.sh index e37efef..7a3f996 100755 --- a/t/t9001-send-email.sh +++ b/t

Re: [RFC][PATCH] send-email: add --[no-]xmailer option

2014-12-04 Thread Luis Henriques
On Wed, Dec 03, 2014 at 08:56:45AM -0800, Junio C Hamano wrote: > Eric Wong writes: > > > Luis Henriques wrote: > >> On Mon, Mar 24, 2014 at 09:38:27PM +, Luis Henriques wrote: > >> > Add --[no-]xmailer that allows a user to disable adding the 'X-Mai

[PATCH v2] send-email: add --[no-]xmailer option

2014-12-03 Thread Luis Henriques
Add --[no-]xmailer that allows a user to disable adding the 'X-Mailer:' header to the email being sent. Acked-by: Eric Wong Signed-off-by: Luis Henriques --- Documentation/config.txt | 1 + Documentation/git-send-email.txt | 5 + git-send-email.perl

Re: [RFC][PATCH] send-email: add --[no-]xmailer option

2014-12-03 Thread Luis Henriques
On Wed, Dec 03, 2014 at 09:23:11AM -0800, Junio C Hamano wrote: > Junio C Hamano writes: > > > Two problems here. > > ... > > tests? > > Something like this squashed into the patch you posted earlier, > perhaps, would be a good place to start. > Awesome, thank you for your review. I'll post a

Re: [RFC][PATCH] send-email: add --[no-]xmailer option

2014-12-03 Thread Luis Henriques
On Tue, Dec 02, 2014 at 07:22:10PM -0800, Kyle J. McKay wrote: > On Dec 2, 2014, at 18:34, Eric Wong wrote: > > >Luis Henriques wrote: > >>On Mon, Mar 24, 2014 at 09:38:27PM +, Luis Henriques wrote: > >>>Add --[no-]xmailer that allows a user to disable addi

Re: [RFC][PATCH] send-email: add --[no-]xmailer option

2014-12-02 Thread Luis Henriques
On Mon, Mar 24, 2014 at 09:38:27PM +, Luis Henriques wrote: > Add --[no-]xmailer that allows a user to disable adding the 'X-Mailer:' > header to the email being sent. > Ping It's been a while since I sent this patch. Is there any interest in having this swit

[RFC][PATCH] send-email: add --[no-]xmailer option

2014-03-24 Thread Luis Henriques
Add --[no-]xmailer that allows a user to disable adding the 'X-Mailer:' header to the email being sent. Signed-off-by: Luis Henriques --- Documentation/config.txt | 1 + Documentation/git-send-email.txt | 3 +++ git-send-email.perl | 12 ++-- 3 files c