[RFC WIP PATCH 3/3] tag: add full support for --edit and --no-edit

2019-10-08 Thread Lucas Oshiro
git tag --edit and --no-edit flags are not currently fully supported. This patch fixes the functionality that allows the editor to be opened on demand. Co-authored-by: Bárbara Fernandes Signed-off-by: Lucas Oshiro Signed-off-by: Bárbara Fernandes --- builtin/tag.c | 16 +--- t

[RFC WIP PATCH 2/3] tag: factor out prepare tag template code

2019-10-08 Thread Lucas Oshiro
code refactoring is part of a series of commits that intend to implement the git tag --amend flag and fix the functionality of --no-edit. Co-authored-by: Bárbara Fernandes Helped-by: Matheus Tavares Signed-off-by: Lucas Oshiro Signed-off-by: Bárbara Fernandes --- builtin/tag.c | 65

[RFC WIP PATCH 0/3] tag: fix --edit and --no-edit flags

2019-10-08 Thread Lucas Oshiro
n the implementation of a new flag --amend, as discussed on the mail thread started on https://public-inbox.org/git/CAHd499BM6M+=zre1wfvxr7b+vhjhfedind5xlqxcwzlv7qe...@mail.gmail.com/. Lucas Oshiro (3): tag: factor out tag reading from write_tag_body() tag: factor out prepare tag template code tag: add

[RFC WIP PATCH 1/3] tag: factor out tag reading from write_tag_body()

2019-10-08 Thread Lucas Oshiro
-by: Bárbara Fernandes Signed-off-by: Lucas Oshiro Helped-by: Matheus Tavares --- builtin/tag.c | 42 ++ 1 file changed, 34 insertions(+), 8 deletions(-) diff --git a/builtin/tag.c b/builtin/tag.c index e0a4c25382..e1e3549af9 100644 --- a/builtin/tag.c