Re: feature request: better support for typos

2015-08-16 Thread Lawrence Siebert
I believe They mean that if you type "clone --branch mister", it should ask if you meant to "clone --branch master" instead, or something. Basically if you type a non existent branch name, calculate edit distance for each branch name, probably either using a timeout or edit distance to stop if som

Re: [PATCH] --count feature for git shortlog

2015-07-03 Thread Lawrence Siebert
On Fri, Jul 3, 2015 at 10:31 AM, Junio C Hamano wrote: > John Keeping writes: > >> On Tue, Jun 30, 2015 at 02:10:49PM +0200, Johannes Schindelin wrote: >>> On 2015-06-29 18:46, Lawrence Siebert wrote: >>> >>> > I appreciate your help. Okay, That all

Re: [PATCH v2 3/4] log --count: added test

2015-07-03 Thread Lawrence Siebert
stuff up, so I appreciate your clarification. Thank you for your time, Lawrence Siebert On Fri, Jul 3, 2015 at 12:34 AM, Matthieu Moy wrote: > Lawrence Siebert writes: > >> added test comparing output between git log --count HEAD and >> git rev-list --count HEAD > > Unl

Re: [PATCH v2 1/4] list-object: add get_commit_count function

2015-07-03 Thread Lawrence Siebert
Mattieu, Understood. I don't suppose there is any commonly code formatting tool to automate formatting in the git style, is there? Thanks, Lawrence On Fri, Jul 3, 2015 at 12:24 AM, Matthieu Moy wrote: > Lawrence Siebert writes: > >> +void get_commit_count(struct rev_info * r

Re: [PATCH v2 2/4] log: add --count option to git log

2015-07-03 Thread Lawrence Siebert
ces a single value, a numeric count. I think walking the entire list is necessary to get the final value, which is what we want with --count. Thanks, Lawrence Siebert On Fri, Jul 3, 2015 at 12:29 AM, Matthieu Moy wrote: > Lawrence Siebert writes: > >> +static void show_object(s

[PATCH v2 4/4] git-log: update man documentation for --count

2015-07-02 Thread Lawrence Siebert
I'm not altogether sure the best way to update the internal usage from git-log -h, but this at least updates the man page. Signed-off-by: Lawrence Siebert --- Documentation/git-log.txt | 2 ++ Documentation/rev-list-options.txt | 2 +- 2 files changed, 3 insertions(+), 1 del

[PATCH v2 0/4] git log --count

2015-07-02 Thread Lawrence Siebert
This should fix the whitespace issues this had previously. Lawrence Siebert (4): list-object: add get_commit_count function log: add --count option to git log log --count: added test git-log: update man documentation for --count Documentation/git-log.txt | 2

[PATCH v2 2/4] log: add --count option to git log

2015-07-02 Thread Lawrence Siebert
adds --count from git rev-list to git log, without --use-bitmap-index for the moment. Signed-off-by: Lawrence Siebert --- builtin/log.c | 29 + 1 file changed, 29 insertions(+) diff --git a/builtin/log.c b/builtin/log.c index 8781049..4aaff3a 100644 --- a/builtin

[PATCH v2 3/4] log --count: added test

2015-07-02 Thread Lawrence Siebert
added test comparing output between git log --count HEAD and git rev-list --count HEAD Signed-off-by: Lawrence Siebert --- t/t4202-log.sh | 7 +++ 1 file changed, 7 insertions(+) diff --git a/t/t4202-log.sh b/t/t4202-log.sh index 1b2e981..35f8d82 100755 --- a/t/t4202-log.sh +++ b/t/t4202

[PATCH v2 1/4] list-object: add get_commit_count function

2015-07-02 Thread Lawrence Siebert
Moving commit counting from rev-list into list-object which is a step toward letting git log do counting as well. Signed-off-by: Lawrence Siebert --- builtin/rev-list.c | 12 ++-- list-objects.c | 14 ++ list-objects.h | 1 + 3 files changed, 17 insertions(+), 10

Re: [PATCH 2/4] log: add --count option to git log

2015-07-02 Thread Lawrence Siebert
Thanks. I've modified my vim config to avoid this happening again, and i'll submit a fixed version of these patches. I'd love if there was a precommit hook to test for this. Lawrence On Thu, Jul 2, 2015 at 2:14 AM, Remi Galan Alfonso wrote: > Lawren

[PATCH 4/4] git-log: update man documentation for --count

2015-07-01 Thread Lawrence Siebert
I'm not altogether sure the best way to update the internal usage from git-log -h, but this at least updates the man page. Signed-off-by: Lawrence Siebert --- Documentation/git-log.txt | 2 ++ Documentation/rev-list-options.txt | 2 +- 2 files changed, 3 insertions(+), 1 del

[PATCH 1/4] list-object: add get_commit_count function

2015-07-01 Thread Lawrence Siebert
Moving commit counting from rev-list into list-object which is a step toward letting git log do counting as well. Signed-off-by: Lawrence Siebert --- builtin/rev-list.c | 12 ++-- list-objects.c | 14 ++ list-objects.h | 1 + 3 files changed, 17 insertions(+), 10

[PATCH 2/4] log: add --count option to git log

2015-07-01 Thread Lawrence Siebert
adds --count from git rev-list to git log, without --use-bitmap-index for the moment. Signed-off-by: Lawrence Siebert --- builtin/log.c | 29 + 1 file changed, 29 insertions(+) diff --git a/builtin/log.c b/builtin/log.c index 8781049..ce6df1e 100644 --- a/builtin

[PATCH 3/4] log --count: added test

2015-07-01 Thread Lawrence Siebert
added test comparing output between git log --count HEAD and git rev-list --count HEAD Signed-off-by: Lawrence Siebert --- t/t4202-log.sh | 7 +++ 1 file changed, 7 insertions(+) diff --git a/t/t4202-log.sh b/t/t4202-log.sh index 1b2e981..077952b 100755 --- a/t/t4202-log.sh +++ b/t/t4202

[PATCH] rev-list: add --count to usage guide

2015-07-01 Thread Lawrence Siebert
--count should be mentioned in the usage guide, this updates code and documentation. Signed-off-by: Lawrence Siebert --- Documentation/git-rev-list.txt | 1 + builtin/rev-list.c | 1 + 2 files changed, 2 insertions(+) diff --git a/Documentation/git-rev-list.txt b/Documentation/git

Re: [PATCH] --count feature for git shortlog

2015-06-30 Thread Lawrence Siebert
he wrong results in certain circumstances. Vincent, could you clarify? Thanks, Lawrence Siebert http://www.github.com/gryftir On Tue, Jun 30, 2015 at 5:23 AM, John Keeping wrote: > > On Tue, Jun 30, 2015 at 02:10:49PM +0200, Johannes Schindelin wrote: > > On 2015-06-29 18:46, La

Re: [PATCH] --count feature for git shortlog

2015-06-29 Thread Lawrence Siebert
My apologies, I misunderstood and thought rev-list didn't take filenames. Lawrence Siebert On Mon, Jun 29, 2015 at 10:04 AM, Junio C Hamano wrote: > Lawrence Siebert writes: > >> I was using it to sort files >> by commit count when provided a list of files, which git rev

Re: [PATCH] --count feature for git shortlog

2015-06-29 Thread Lawrence Siebert
sing it to sort files by commit count when provided a list of files, which git rev-list doesn't really work for. Anyway I can try and put it in log proper, if you think that's the best place. Thank you, Lawrence Siebert -- To unsubscribe from this list: send the line "unsubscribe gi

[PATCH] --count feature for git shortlog

2015-06-28 Thread Lawrence Siebert
Signed-off-by: Lawrence Siebert --- t/t4201-shortlog.sh | 5 + 1 file changed, 5 insertions(+) diff --git a/t/t4201-shortlog.sh b/t/t4201-shortlog.sh index 7600a3e..33ecb4a 100755 --- a/t/t4201-shortlog.sh +++ b/t/t4201-shortlog.sh @@ -194,4 +194,9 @@ test_expect_success 'shortlog

[PATCH] --count feature for git shortlog

2015-06-28 Thread Lawrence Siebert
--summary is per author --count counts all Signed-off-by: Lawrence Siebert --- builtin/shortlog.c | 14 +- shortlog.h | 1 + 2 files changed, 10 insertions(+), 5 deletions(-) diff --git a/builtin/shortlog.c b/builtin/shortlog.c index c0bab6a..4b79dc8 100644 --- a/builtin

[PATCH] --count feature for git shortlog

2015-06-28 Thread Lawrence Siebert
purpose. I also created a test. It's not a great test, but it works. I'm sure I've make a beginner mistake in some part of the process; I've done my best to follow documentation, so please be explicit when you tell me I've done something wrong. Thanks, Lawrence Sieb