On Tue, 2014-03-04 at 11:44 -0800, Junio C Hamano wrote:
> Krzesimir Nowak writes:
>
> > It might be possible (in "Gerrited" setups) to have local branches
> > outside refs/heads/, like for example in following fetch config:
> >
> > [remote "ori
---
transport.c | 41 ++---
1 file changed, 34 insertions(+), 7 deletions(-)
diff --git a/transport.c b/transport.c
index ca7bb44..ac933ee 100644
--- a/transport.c
+++ b/transport.c
@@ -143,6 +143,25 @@ static void insert_packed_refs(const char *packed_refs,
s
y the
get_local_refs() would need to compute the actual list of local
hierarchies (if it is possible at all). And it probably should get a
better name. And probably something else.
What do you think?
Krzesimir Nowak (1):
RFC: make --set-upstream work for branches not in refs/heads/
transport.c
Given two branches residing in refs/heads/master and refs/wip/feature
the list-of-branches view will present them in following way:
master
feature (wip)
When getting a snapshot of a 'feature' branch, the tarball is going to
have name like 'project-wip-feature-.tgz'.
Sign
Users of validate_* passing "0" might get failures on correct name
because of coercion of "0" to false in code like:
die_error(500, "invalid ref") unless (check_ref_format ("0"));
Also, the validate_foo subs are renamed to is_valid_foo.
Signed-off-by:
Allow extra-branch-refs feature to tell gitweb to show refs from
additional hierarchies in addition to branches in the list-of-branches
view.
Signed-off-by: Krzesimir Nowak
---
Documentation/gitweb.conf.txt | 37
gitweb/gitweb.perl| 80
directories.
Krzesimir Nowak (4):
gitweb: Move check-ref-format code into separate function
gitweb: Return 1 on validation success instead of passed input
gitweb: Add a feature for adding more branch refs
gitweb: Denote non-heads, non-remotes branches
Documentation/gitweb.conf.txt | 37
This check will be used in more than one place later.
Signed-off-by: Krzesimir Nowak
---
gitweb/gitweb.perl | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 68c77f6..46bd6ac 100755
--- a/gitweb/gitweb.perl
+++ b
On Thu, 2013-12-05 at 11:00 +0100, Krzesimir Nowak wrote:
> On Wed, 2013-12-04 at 19:06 +0100, Jakub Narębski wrote:
> > On Wed, Dec 4, 2013 at 2:43 PM, Krzesimir Nowak
> > wrote:
> > > ++
> > > +It is an error to specify a ref that does not pass "
On Wed, 2013-12-04 at 19:06 +0100, Jakub Narębski wrote:
> On Wed, Dec 4, 2013 at 2:43 PM, Krzesimir Nowak
> wrote:
> >
> > Allow extra-branch-refs feature to tell gitweb to show refs from
> > additional hierarchies in addition to branches in the list-of-branches
> &g
On Wed, 2013-12-04 at 17:07 +0100, Jakub Narębski wrote:
> On Wed, Dec 4, 2013 at 2:43 PM, Krzesimir Nowak
> wrote:
>
> > Users of validate_* passing "0" might get failures on correct name
> > because of coercion of "0" to false in code like:
On Wed, 2013-12-04 at 16:56 +0100, Jakub Narębski wrote:
> On Wed, Dec 4, 2013 at 2:43 PM, Krzesimir Nowak
> wrote:
>
> > This check will be used in more than one place later.
> >
> > Signed-off-by: Krzesimir Nowak
> > Reviewed-by: Junio C Hamano
> >
On Wed, 2013-12-04 at 12:31 -0800, Junio C Hamano wrote:
> Krzesimir Nowak writes:
>
> > This check will be used in more than one place later.
> >
> > Signed-off-by: Krzesimir Nowak
> > Reviewed-by: Junio C Hamano
>
> Again, I do not think I reviewed this
On Wed, 2013-12-04 at 12:28 -0800, Junio C Hamano wrote:
> Martin Langhoff writes:
>
> > On Wed, Dec 4, 2013 at 10:46 AM, Krzesimir Nowak
> > wrote:
> >> On Wed, 2013-12-04 at 16:11 +0100, Jakub Narębski wrote:
> >>> On Wed, Dec 4, 2013 at
On Wed, 2013-12-04 at 16:11 +0100, Jakub Narębski wrote:
> On Wed, Dec 4, 2013 at 2:42 PM, Krzesimir Nowak
> wrote:
>
> > So future reader will know what does it mean without running "perldoc
> > perlvar".
>
> Hmmm... shouldn't future reader know it
On Tue, 2013-12-03 at 15:56 +0100, Krzesimir Nowak wrote:
> First patch just splits some code to a function, second patch adds the
> extra-branch-refs feature and third one adds some visual
> differentation of branches from non-standard ref directories.
>
> Krzesimir Nowak (3):
&
Given two branches residing in refs/heads/master and refs/wip/feature
the list-of-branches view will present them in following way:
master
feature (wip)
When getting a snapshot of a 'feature' branch, the tarball is going to
have name like 'project-wip-feature-.tgz'.
Sign
Allow extra-branch-refs feature to tell gitweb to show refs from
additional hierarchies in addition to branches in the list-of-branches
view.
Signed-off-by: Krzesimir Nowak
Reviewed-by: Junio C Hamano
Reviewed-by: Jakub Narębski
---
Documentation/gitweb.conf.txt | 37
Users of validate_* passing "0" might get failures on correct name
because of coercion of "0" to false in code like:
die_error(500, "invalid ref") unless (check_ref_format ("0"));
Signed-off-by: Krzesimir Nowak
---
gitweb/gitweb.perl | 45 +
So future reader will know what does it mean without running "perldoc
perlvar".
Signed-off-by: Krzesimir Nowak
---
gitweb/gitweb.perl | 2 ++
1 file changed, 2 insertions(+)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
index 68c77f6..ee61f9e 100755
--- a/gitweb/gitweb.perl
++
-feature and some documentation.
Fifth patch adds some visual differentation of branches from
non-standard ref directories.
Krzesimir Nowak (5):
gitweb: Add a comment explaining the meaning of $/
gitweb: Move check-ref-format code into separate function
gitweb: Return plain booleans in validation
This check will be used in more than one place later.
Signed-off-by: Krzesimir Nowak
Reviewed-by: Junio C Hamano
Reviewed-by: Jakub Narębski
---
gitweb/gitweb.perl | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/gitweb/gitweb.perl b/gitweb/gitweb.perl
On Tue, 2013-12-03 at 20:38 +0100, Jakub Narębski wrote:
> On Tue, Dec 3, 2013 at 8:02 PM, Junio C Hamano wrote:
> > Krzesimir Nowak writes:
>
> >> +sub check_ref_format {
> >> + my $input = shift || return undef;
> >> +
> >> + # res
On Tue, 2013-12-03 at 21:38 +0100, Jakub Narębski wrote:
> On Tue, Dec 3, 2013 at 9:15 PM, Junio C Hamano wrote:
> > Krzesimir Nowak writes:
> >
> >> @@ -626,6 +640,17 @@ sub feature_avatar {
> >> return @val ? @val : @_;
> >> }
> >>
First patch just splits some code to a function, second patch adds the
extra-branch-refs feature and third one adds some visual
differentation of branches from non-standard ref directories.
Krzesimir Nowak (3):
gitweb: Move check-ref-format code into separate function
gitweb: Add a feature
On Tue, 2013-12-03 at 14:02 +0100, Jakub Narębski wrote:
> On Tue, Dec 3, 2013 at 11:53 AM, Krzesimir Nowak
> wrote:
> > On Mon, 2013-12-02 at 18:34 +0100, Jakub Narębski wrote:
> >> W dniu 2013-12-02 13:06, Krzesimir Nowak pisze:
> >>> On Mon, 2013-12-02 at
Allow extra-branch-refs feature to tell gitweb to show refs from
additional hierarchies in addition to branches in the list-of-branches
view.
Signed-off-by: Krzesimir Nowak
Reviewed-by: Junio C Hamano
Reviewed-by: Jakub Narębski
Reviewed-by: Eric Sunshine
---
Documentation/gitweb.conf.txt
Given two branches residing in refs/heads/master and refs/wip/feature
the list-of-branches view will present them in following way:
master
feature (wip)
When getting a snapshot of a 'feature' branch, the tarball is going to
have name like 'project-wip-feature-.tgz'.
Sign
This check will be used in more than one place later.
Signed-off-by: Krzesimir Nowak
Reviewed-by: Junio C Hamano
Reviewed-by: Jakub Narębski
Reviewed-by: Eric Sunshine
---
gitweb/gitweb.perl | 17 +
1 file changed, 13 insertions(+), 4 deletions(-)
diff --git a/gitweb
On Mon, 2013-12-02 at 18:34 +0100, Jakub Narębski wrote:
> W dniu 2013-12-02 13:06, Krzesimir Nowak pisze:
> > On Mon, 2013-12-02 at 01:21 +0100, Jakub Narębski wrote:
> >> On Thu, Nov 28, 2013 at 12:44 PM, Krzesimir Nowak
> >> wrote:
> >>
> >>
On Mon, 2013-12-02 at 01:21 +0100, Jakub Narębski wrote:
> On Thu, Nov 28, 2013 at 12:44 PM, Krzesimir Nowak
> wrote:
>
> > Allow @additional_branch_refs configuration variable to tell gitweb to
> > show refs from additional hierarchies in addition to branches in the
>
On Thu, 2013-11-28 at 20:13 -0500, Eric Sunshine wrote:
> On Thu, Nov 28, 2013 at 6:44 AM, Krzesimir Nowak
> wrote:
> > Allow @additional_branch_refs configuration variable to tell gitweb to
> > show refs from additional hierarchies in addition to branches in the
> &g
Allow @additional_branch_refs configuration variable to tell gitweb to
show refs from additional hierarchies in addition to branches in the
list-of-branches view.
Signed-off-by: Krzesimir Nowak
---
Documentation/gitweb.conf.txt | 13
gitweb/gitweb.perl| 75
On Wed, 2013-11-27 at 12:55 -0800, Junio C Hamano wrote:
> Eric Sunshine writes:
>
> > On Wed, Nov 27, 2013 at 3:34 PM, Eric Sunshine
> > wrote:
> >> On Wed, Nov 27, 2013 at 10:30 AM, Krzesimir Nowak
> >> wrote:
> >>> Overriding an @ad
On Wed, 2013-11-27 at 16:56 +0100, Jakub Narębski wrote:
> Krzesimir Nowak wrote:
>
> > Overriding an @additional_branch_refs configuration variable with
> > value ('wip') will make gitweb to show branches that appear in
> > refs/heads and refs/wip (refs/heads
On Tue, 2013-11-26 at 13:48 -0800, Junio C Hamano wrote:
> Krzesimir Nowak writes:
>
> > Overriding an @additional_branch_refs configuration variable with
> > value ('wip') will make gitweb to show branches that appear in
> > refs/heads and refs/wip (refs/heads
Overriding an @additional_branch_refs configuration variable with
value ('wip') will make gitweb to show branches that appear in
refs/heads and refs/wip (refs/heads is hardcoded). Might be useful for
gerrit setups where user branches are not stored under refs/heads/.
Signed-off-by:
On Mon, 2013-11-25 at 11:32 -0800, Junio C Hamano wrote:
> Krzesimir Nowak writes:
>
> > On Fri, 2013-11-22 at 09:34 -0800, Junio C Hamano wrote:
> >> Krzesimir Nowak writes:
> >>
> >> > Running 'make GITWEB_WANTED_REFS="heads wip" g
Overriding an @additional_branch_refs configuration variable with
value ('wip') will make gitweb to show branches that appear in
refs/heads and refs/wip (refs/heads is hardcoded). Might be useful for
gerrit setups where user branches are not stored under refs/heads/.
Signed-off-by:
On Fri, 2013-11-22 at 09:34 -0800, Junio C Hamano wrote:
> Krzesimir Nowak writes:
>
> > Running 'make GITWEB_WANTED_REFS="heads wip" gitweb.cgi' will create a
> > gitweb CGI script showing branches that appear in refs/heads/ and in
> > refs/wip/.
Running 'make GITWEB_WANTED_REFS="heads wip" gitweb.cgi' will create a
gitweb CGI script showing branches that appear in refs/heads/ and in
refs/wip/. Might be useful for gerrit setups where user branches are
not stored under refs/heads/.
Signed-off-by: Krzesimir Nowak
41 matches
Mail list logo
