[PATCH v2] diff: ensure correct lifetime of external_diff_cmd

x27;Documentation/RelNotes/2.17.2.txt' Launch 'bc3' [Y/n]? Viewing (8/404): 'Documentation/RelNotes/2.18.1.txt' Launch 'bc3' [Y/n]? Viewing (9/404): 'Documentation/RelNotes/2.19.0.txt' Launch 'bc3' [Y/n]? error: cannot

[PATCH] diff: ensure correct lifetime of external_diff_cmd

x27;Documentation/RelNotes/2.17.2.txt' Launch 'bc3' [Y/n]? Viewing (8/404): 'Documentation/RelNotes/2.18.1.txt' Launch 'bc3' [Y/n]? Viewing (9/404): 'Documentation/RelNotes/2.19.0.txt' Launch 'bc3' [Y/n]? error: cannot spawn ¦?:

[PATCH v3] gc --auto: release pack files before auto packing

or-windows/git/issues/500 Signed-off-by: Kim Gybels --- Changes since v2: - revert fix back to v1: use close_all_packs instead of repo_clear - use test_i18ngrep only for translated string builtin/gc.c | 1 + t/t5510-fetch.sh | 2 ++ 2 files changed, 3 insertions(+) diff --git a/builtin/gc.c

Re: [PATCH] builtin/config: work around an unsized array forward declaration

On (06/07/18 12:24), Junio C Hamano wrote: > > Jeff King writes: > > > On Thu, Jul 05, 2018 at 09:50:53PM +0200, Beat Bolli wrote: > > > >> > Your patch is obviously correct, but I think here there might be an even > >> > simpler solution: just bump option_parse_type() below the declaration, > >

Re: [PATCH] gc --auto: release pack files before auto packing

On (07/07/18 11:40), SZEDER Gábor wrote: > > On Fri, Jul 6, 2018 at 6:39 PM Junio C Hamano wrote: > > > > Duy Nguyen writes: > > > > > On Sat, Jun 30, 2018 at 03:38:21PM +0200, Kim Gybels wrote: > > >> Teach gc --auto to release pack files before

Re: What's (not) cooking

On (07/07/18 08:34), Elijah Newren wrote: > Hi Dscho, > > On Sat, Jul 7, 2018 at 5:11 AM, Johannes Schindelin > wrote: > > Hi Elijah, > > > > On Fri, 6 Jul 2018, Elijah Newren wrote: > > > >> On Fri, Jul 6, 2018 at 3:57 PM, Junio C Hamano wrote: > >> > I'll be pushing out the integration branche

[PATCH v2] gc --auto: clear repository before auto packing

or-windows/git/issues/500 Signed-off-by: Kim Gybels --- Updated after Duy Nguyen's comments: - use repo_clear instead of close_all_packs, and add the call in gc_before_repack intead of just before executing git repack - use test_i18ngrep instead of grep in updated test builtin/gc.c

[PATCH] gc --auto: release pack files before auto packing

or-windows/git/issues/500 Signed-off-by: Kim Gybels --- Patch based on master, since problem doesn't reproduce on maint, however, the improvement to the test might be valuable on maint. builtin/gc.c | 1 + t/t5510-fetch.sh | 2 ++ 2 files changed, 3 insertions(+) diff --git a/builtin

Re: [PATCH 1/2] daemon: use timeout for uninterruptible poll

On (19/04/18 06:51), Junio C Hamano wrote: > Johannes Schindelin writes: > > In other words, you scolded Kim for something that this patch did not > > introduce, but which was already there. I didn't feel scolded, just Junio raising a concern about maintainability of the code. > > Unless I am m

Re: [PATCH 2/2] daemon: graceful shutdown of client connection

On (13/04/18 15:03), Johannes Schindelin wrote: > I wonder whether you found a reliable way to trigger this? It would be > nice to have a regression test for this. On my system, it reproduced reliably using Oleg's example [1], below is my bash version of it. Script to generate repository with som

Re: [PATCH 1/2] daemon: use timeout for uninterruptible poll

On (13/04/18 14:36), Johannes Schindelin wrote: > > The poll provided in compat/poll.c is not interrupted by receiving > > SIGCHLD. Use a timeout for cleaning up dead children in a timely manner. > > Maybe say "When using this poll emulation, use a timeout ..."? I will rewrite the commit message

[PATCH 1/2] daemon: use timeout for uninterruptible poll

The poll provided in compat/poll.c is not interrupted by receiving SIGCHLD. Use a timeout for cleaning up dead children in a timely manner. Signed-off-by: Kim Gybels --- daemon.c | 10 -- 1 file changed, 8 insertions(+), 2 deletions(-) diff --git a/daemon.c b/daemon.c index fe833ea7de

[PATCH 0/2] Fix early EOF with GfW daemon

d argument fatal: early EOF fatal: index-pack failed These patches solve the issue by only changing git-daemon, its child processes can remain unaware that stdin/stdout are actually network connections. [1] https://github.com/git-for-windows/git/issues/304 Kim Gybels (2): daemon: use t

[PATCH 2/2] daemon: graceful shutdown of client connection

child process has finished. This allows all the data to be sent to the client, instead of being discarded. Fixes https://github.com/git-for-windows/git/issues/304 Signed-off-by: Kim Gybels --- daemon.c | 9 ++--- 1 file changed, 6 insertions(+), 3 deletions(-) diff --git a/daemon.c b/daemon.c

[PATCH v3] packed_ref_cache: don't use mmap() for small files

ws/git/issues/1410 [2] Logic introduced in commit 9130ac1e196 (Better error messages for corrupt databases, 2007-01-11) Signed-off-by: Kim Gybels --- Change since v2: removed separate case for zero length as suggested by Peff, ensuring that snapshot->buf is always a valid pointer. refs/packe

Re: [PATCH] packed_ref_cache: don't use mmap() for small files

On (15/01/18 16:15), Jeff King wrote: > On Sat, Jan 13, 2018 at 05:11:49PM +0100, Kim Gybels wrote: > > > Take a hint from commit ea68b0ce9f8ce8da3e360aed3cbd6720159ffbee and use > > read() instead of mmap() for small packed-refs files. > > > > This also fi

[PATCH v2] packed_ref_cache: don't use mmap() for small files

could simply check for NULL before munmap(), or introduce xmunmap() that could be used together with xmmap(). [1] https://github.com/git-for-windows/git/issues/1410 [2] Logic introduced in commit 9130ac1e196 (Better error messages for corrupt databases, 2007-01-11) Signed-off-by: Kim Gybels --- C

[PATCH] packed_ref_cache: don't use mmap() for small files

(), or introduce an xmunmap() that could be used together with xmmap(). [1] https://github.com/git-for-windows/git/issues/1410 [2] Logic introduced in commit 9130ac1e1966adb9922e64f645730d0d45383495 Signed-off-by: Kim Gybels --- refs/packed-backend.c | 14 -- 1 file changed, 8